[ 
https://issues.apache.org/jira/browse/YARN-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124143#comment-15124143
 ] 

Jian He edited comment on YARN-4617 at 1/29/16 8:25 PM:
--------------------------------------------------------

thanks [~sunilg] and  [~Naganarasimha] for reviewing the patch too !


was (Author: jianhe):
thanks [~Naganarasimha] for reviewing the patch too !

> LeafQueue#pendingOrderingPolicy should always use fixed ordering policy 
> instead of using same as active applications ordering policy
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4617
>                 URL: https://issues.apache.org/jira/browse/YARN-4617
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 2.8.0
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>             Fix For: 2.8.0
>
>         Attachments: 0001-YARN-4617.patch, 0001-YARN-4617.patch, 
> 0002-YARN-4617.patch, 0003-YARN-4617.patch, 0004-YARN-4617.patch, 
> 0005-YARN-4617.patch, 0006-YARN-4617.patch
>
>
> In discussion with [~leftnoteasy] in the JIRA 
> [comment|https://issues.apache.org/jira/browse/YARN-4479?focusedCommentId=15108236&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15108236]
>  pointed out that {{LeafQueue#pendingOrderingPolicy}} should NOT be assumed 
> to be same as active applications ordering policy. It causes an issue when 
> using fair ordering policy.
> Expectations of this JIRA should include
> # Create FifoOrderingPolicyForPendingApps which extends FifoOrderingPolicy.
> # Comparator of new ordering policy should use 
> RecoveryComparator,PriorityComparator and Fifocomparator in order 
> respectively.
> # Clean up {{LeafQueue#pendingOPForRecoveredApps}} which is no more required 
> once new fixed ordering policy is created pending applications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to