[jira] [Comment Edited] (YARN-5132) Exclude generated protobuf sources from YARN Javadoc build
[ https://issues.apache.org/jira/browse/YARN-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301173#comment-15301173 ] Karthik Kambatla edited comment on YARN-5132 at 5/26/16 12:06 AM: -- I see several reasons to get this in: # As Subru, Chris and others mentioned, I don't see why we should publish javadocs of these proto generated classes. We should actually update the release script to remove javadoc from proto files. [~vinodkv], [~leftnoteasy] - you have been working on the releases recently, do we publish javadocs for these? # All JIRAs see these javadoc errors. It is painstakingly hard to figure out what javadoc issues the patch introduces. was (Author: kasha): I see several reasons to get this in: # As Subru, Chris and others mentioned, I don't see why we should publish javadocs of these proto generated classes. We should actually update the release script to remove javadoc from proto files. [~vinodkv], [~leftnoteasy] - you have been working on the releases recently, do we publish javadocs for these? # All JIRAs see these javadoc errors. It is painstakingly hard to figure out what javadoc issues the patch introduces. The example I ran into YARN-5035. > Exclude generated protobuf sources from YARN Javadoc build > -- > > Key: YARN-5132 > URL: https://issues.apache.org/jira/browse/YARN-5132 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Subru Krishnan >Priority: Critical > Attachments: YARN-5132-v1.patch > > > Currently YARN build includes Javadoc from generated protobuf sources which > is causing CI to fail. This JIRA proposes to exclude generated protobuf > sources from YARN Javadoc build -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5132) Exclude generated protobuf sources from YARN Javadoc build
[ https://issues.apache.org/jira/browse/YARN-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299333#comment-15299333 ] Arun Suresh edited comment on YARN-5132 at 5/25/16 2:22 AM: bq. then that means that non-Java clients are basically screwed. It also makes the Go example by Hortonworks extremely problematic. [~aw], appoligize but I do NOT see the connection between generated java classes and go clients. A go client would generate its own go files from the protobuf and use it. was (Author: asuresh): bq. then that means that non-Java clients are basically screwed. It also makes the Go example by Hortonworks extremely problematic. [~aw], appoligize but I do see the connection between generated java classes and go clients. A go client would generate its own go files from the protobuf and use it. > Exclude generated protobuf sources from YARN Javadoc build > -- > > Key: YARN-5132 > URL: https://issues.apache.org/jira/browse/YARN-5132 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Subru Krishnan >Priority: Critical > Attachments: YARN-5132-v1.patch > > > Currently YARN build includes Javadoc from generated protobuf sources which > is causing CI to fail. This JIRA proposes to exclude generated protobuf > sources from YARN Javadoc build -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5132) Exclude generated protobuf sources from YARN Javadoc build
[ https://issues.apache.org/jira/browse/YARN-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297492#comment-15297492 ] Subru Krishnan edited comment on YARN-5132 at 5/24/16 1:35 AM: --- Adding an exclusion for protobuf-generated sources from YARN build as [suggested | https://issues.apache.org/jira/browse/YARN-4887?focusedCommentId=15295122] by [~cnauroth]. I ran test-patch locally with and without this change for YARN-4887 to verify it works correctly. was (Author: subru): Adding an exclusion for protobuf-generated sources from YARN build as [suggested | https://issues.apache.org/jira/browse/YARN-4887?focusedCommentId=15295122] by [~cnauroth] > Exclude generated protobuf sources from YARN Javadoc build > -- > > Key: YARN-5132 > URL: https://issues.apache.org/jira/browse/YARN-5132 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Subru Krishnan >Priority: Critical > Attachments: YARN-5132-v1.patch > > > Currently YARN build includes Javadoc from generated protobuf sources which > is causing CI to fail. This JIRA proposes to exclude generated protobuf > sources from YARN Javadoc build -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
