[jira] [Comment Edited] (YARN-5277) When localizers fail due to resource timestamps being out, provide more diagnostics
[ https://issues.apache.org/jira/browse/YARN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081058#comment-17081058 ] Siddharth Ahuja edited comment on YARN-5277 at 4/11/20, 12:40 AM: -- Ok, patching for both branch-3.2 and branch-3.3 was seamless. I have attached patches for both branches. Waiting on Jenkins build now. was (Author: sahuja): Ok, patching for both branch-3.2 and branch-3.3 was seamless. I have attached patches for both patches and I hope the jenkins build goes through fine. > When localizers fail due to resource timestamps being out, provide more > diagnostics > --- > > Key: YARN-5277 > URL: https://issues.apache.org/jira/browse/YARN-5277 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Steve Loughran >Assignee: Siddharth Ahuja >Priority: Major > Fix For: 3.4.0 > > Attachments: YARN-5277-branch-3.2.003.patch, > YARN-5277-branch-3.3.004.patch, YARN-5277.001.patch, YARN-5277.002.patch > > > When an NM fails a resource D/L as the timestamps are wrong, there's not much > info, just two long values. > It would be good to also include the local time values, *and the current wall > time*. These are the things people need to know when trying to work out what > went wrong -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5277) When localizers fail due to resource timestamps being out, provide more diagnostics
[
https://issues.apache.org/jira/browse/YARN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081037#comment-17081037
]
Siddharth Ahuja edited comment on YARN-5277 at 4/10/20, 11:32 PM:
--
Thank you very much for your review and commit [~snemeth]!
In regards to the following:
{quote}
Next steps:
Siddharth Ahuja: Could you please check how this would affect branch-3.3 and
branch-3.2 and if the same fix can be applied, provide patches targeting these
branches?
Thanks in advance.
{quote}
I have just uploaded a patch for branch-3.2. I am now checking branch-3.3. Will
update the JIRA soon.
was (Author: sahuja):
Thank you very much for your review and commit [~snemeth]!
In regards to the following:
{bq}
Next steps:
Siddharth Ahuja: Could you please check how this would affect branch-3.3 and
branch-3.2 and if the same fix can be applied, provide patches targeting these
branches?
Thanks in advance.
{bq}
I have just uploaded a patch for branch-3.2. I am now checking branch-3.3. Will
update the JIRA soon.
> When localizers fail due to resource timestamps being out, provide more
> diagnostics
> ---
>
> Key: YARN-5277
> URL: https://issues.apache.org/jira/browse/YARN-5277
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.8.0
>Reporter: Steve Loughran
>Assignee: Siddharth Ahuja
>Priority: Major
> Fix For: 3.4.0
>
> Attachments: YARN-5277-branch-3.2.003.patch, YARN-5277.001.patch,
> YARN-5277.002.patch
>
>
> When an NM fails a resource D/L as the timestamps are wrong, there's not much
> info, just two long values.
> It would be good to also include the local time values, *and the current wall
> time*. These are the things people need to know when trying to work out what
> went wrong
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5277) when localizers fail due to resource timestamps being out, provide more diagnostics
[
https://issues.apache.org/jira/browse/YARN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065269#comment-17065269
]
Siddharth Ahuja edited comment on YARN-5277 at 3/24/20, 2:56 AM:
-
Hi [~aajisaka], I am working on this JIRA and have a potential
fix/implementation in terms of non-test source code. However, I did have a
question regarding the Junit code coverage tool -> _Clover_ .
I tried to run the following command:
{code}
mvn test -Pclover
{code}
but it resulted in the following error:
{code}
Failed to execute goal
com.atlassian.maven.plugins:maven-clover2-plugin:3.3.0:setup (clover-setup) on
project hadoop-main: Failed to load resource as file
[/Users//.clover.license]: Could not find resource
'/Users//.clover.license'. -> [Help 1]
that I tried to run to see if we are already covering the impacted code through
Junit testing or not. I used the following command to run it:
{code}
I could try and supply a clover license through :
{code}
mvn test -Pclover [-DcloverLicenseLocation=${user.name}/.clover.license]
{code}
as per
https://svn.apache.org/repos/asf/hadoop/common/branches/MR-4327/BUILDING.txt,
however, I need the clover.license.
I somehow found a link where I could get that potentially -
https://svn.apache.org/repos/private/committers/donated-licenses/clover/2.6.x/clover.license
but as I am not a committer, I don't have the credentials (I get asked for
username/password).
As such, can you kindly help me with a clover license? I am really interesting
in getting this so that I know if we already have an existing test method in
the test class that already covers what I am trying to modify and hence, I can
just update that method. If it is not covered yet, then, I will have to write
up a new junit test for that. I don't want to be reviewing multiple existing
test methods to understand if something is covered or not as this approach is
not robust.
Thanks in advance for your kind assistance!
was (Author: sahuja):
Hi [~aajisaka], I am working on this JIRA and have a potential
fix/implementation in terms of non-test source code. However, I did have a
question regarding the Junit code coverage tool -> _Clover_ .
I tried to run the following command:
{code}
mvn test -Pclover
{code}
but it resulted in the following error:
{code}
Failed to execute goal
com.atlassian.maven.plugins:maven-clover2-plugin:3.3.0:setup (clover-setup) on
project hadoop-main: Failed to load resource as file
[/Users//.clover.license]: Could not find resource
'/Users//.clover.license'. -> [Help 1]
that I tried to run to see if we are already covering the impacted code through
Junit testing or not. I used the following command to run it:
{code}
I could try and supply a clover license through :
{code}
mvn test -Pclover [-DcloverLicenseLocation=${user.name}/.clover.license]
{code}
as per
https://svn.apache.org/repos/asf/hadoop/common/branches/MR-4327/BUILDING.txt,
however, I need the clover.license.
I somehow found a link where I could get that potentially -
https://svn.apache.org/repos/private/committers/donated-licenses/clover/2.6.x/clover.license
but as I am not a committer, I don't have the credentials (I get asked for
username/password).
As such, can you kindly help me with a clover license? I am really interesting
in getting this so that I know if we already have an existing test method in
the test class that already covers what I am trying to modify and hence, I can
just update that method. If it is not covered yet, then, I will have to write
up a new junit test for that.
Thanks in advance for your kind assistance!
> when localizers fail due to resource timestamps being out, provide more
> diagnostics
> ---
>
> Key: YARN-5277
> URL: https://issues.apache.org/jira/browse/YARN-5277
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.8.0
>Reporter: Steve Loughran
>Assignee: Siddharth Ahuja
>Priority: Major
>
> When an NM fails a resource D/L as the timestamps are wrong, there's not much
> info, just two long values.
> It would be good to also include the local time values, *and the current wall
> time*. These are the things people need to know when trying to work out what
> went wrong
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5277) when localizers fail due to resource timestamps being out, provide more diagnostics
[
https://issues.apache.org/jira/browse/YARN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065269#comment-17065269
]
Siddharth Ahuja edited comment on YARN-5277 at 3/24/20, 2:54 AM:
-
Hi [~aajisaka], I am working on this JIRA and have a potential
fix/implementation in terms of non-test source code. However, I did have a
question regarding the Junit code coverage tool -> _Clover_ .
I tried to run the following command:
{code}
mvn test -Pclover
{code}
but it resulted in the following error:
{code}
Failed to execute goal
com.atlassian.maven.plugins:maven-clover2-plugin:3.3.0:setup (clover-setup) on
project hadoop-main: Failed to load resource as file
[/Users//.clover.license]: Could not find resource
'/Users//.clover.license'. -> [Help 1]
that I tried to run to see if we are already covering the impacted code through
Junit testing or not. I used the following command to run it:
{code}
I could try and supply a clover license through :
{code}
mvn test -Pclover [-DcloverLicenseLocation=${user.name}/.clover.license]
{code}
as per
https://svn.apache.org/repos/asf/hadoop/common/branches/MR-4327/BUILDING.txt,
however, I need the clover.license.
I somehow found a link where I could get that potentially -
https://svn.apache.org/repos/private/committers/donated-licenses/clover/2.6.x/clover.license
but as I am not a committer, I don't have the credentials (I get asked for
username/password).
As such, can you kindly help me with a clover license? I am really interesting
in getting this so that I know if we already have an existing test method in
the test class that already covers what I am trying to modify and hence, I can
just update that method. If it is not covered yet, then, I will have to write
up a new junit test for that.
Thanks in advance for your kind assistance!
was (Author: sahuja):
Hi [~aajisaka], I am working on this JIRA and have a potential
fix/implementation in terms of non-test source code. However, I did have a
question regarding the Junit code coverage tool -> _Clover_ .
I tried to run the following command:
{code}
mvn test -Pclover
{code}
but it resulted in the following error:
{code}
Failed to execute goal
com.atlassian.maven.plugins:maven-clover2-plugin:3.3.0:setup (clover-setup) on
project hadoop-main: Failed to load resource as file
[/Users//.clover.license]: Could not find resource
'/Users/sidtheadmin/.clover.license'. -> [Help 1]
that I tried to run to see if we are already covering the impacted code through
Junit testing or not. I used the following command to run it:
{code}
I could try and supply a clover license through :
{code}
mvn test -Pclover [-DcloverLicenseLocation=${user.name}/.clover.license]
{code}
as per
https://svn.apache.org/repos/asf/hadoop/common/branches/MR-4327/BUILDING.txt,
however, I need the clover.license.
I somehow found a link where I could get that potentially -
https://svn.apache.org/repos/private/committers/donated-licenses/clover/2.6.x/clover.license
but as I am not a committer, I don't have the credentials (I get asked for
username/password).
As such, can you kindly help me with a clover license? I am really interesting
in getting this so that I know if we already have an existing test method in
the test class that already covers what I am trying to modify and hence, I can
just update that method. If it is not covered yet, then, I will have to write
up a new junit test for that.
Thanks in advance for your kind assistance!
> when localizers fail due to resource timestamps being out, provide more
> diagnostics
> ---
>
> Key: YARN-5277
> URL: https://issues.apache.org/jira/browse/YARN-5277
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
>Affects Versions: 2.8.0
>Reporter: Steve Loughran
>Assignee: Siddharth Ahuja
>Priority: Major
>
> When an NM fails a resource D/L as the timestamps are wrong, there's not much
> info, just two long values.
> It would be good to also include the local time values, *and the current wall
> time*. These are the things people need to know when trying to work out what
> went wrong
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-5277) when localizers fail due to resource timestamps being out, provide more diagnostics
[ https://issues.apache.org/jira/browse/YARN-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939189#comment-16939189 ] Adam Antal edited comment on YARN-5277 at 9/27/19 7:39 AM: --- Customer of ours is hitting this. If [~ste...@apache.org] is not working on this/does not have a patch, someone else could grab this. was (Author: adam.antal): Customer of ours is hitting this. If [~ste...@apache.org] is not working on this/does not have a patch, someone could grab this. > when localizers fail due to resource timestamps being out, provide more > diagnostics > --- > > Key: YARN-5277 > URL: https://issues.apache.org/jira/browse/YARN-5277 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager >Affects Versions: 2.8.0 >Reporter: Steve Loughran >Priority: Major > > When an NM fails a resource D/L as the timestamps are wrong, there's not much > info, just two long values. > It would be good to also include the local time values, *and the current wall > time*. These are the things people need to know when trying to work out what > went wrong -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
