[ https://issues.apache.org/jira/browse/YARN-5504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436967#comment-15436967 ]
Sunil G edited comment on YARN-5504 at 8/25/16 5:46 PM: -------------------------------------------------------- I tested patch with {{keep-ui-build-cache}}, and it works fine. However i am confused whether we need {{test}}. I think we can keep another ticket open for UT itself. I think we must have some UT's and I ll help to get them in soon. +1 for current patch, i will commit if there are no other objections. was (Author: sunilg): I tested patch with {{keep-ui-build-cache}}, and it works fine. However i am confused whether we need {{test}}. I think we can keep another ticket open for UT itself. I think we must have some UT's and I ll help to get them in soon. +1 for current patch, i will commit if there are no other objections. I will wait for a day. > [YARN-3368] Fix the YARN UI build > --------------------------------- > > Key: YARN-5504 > URL: https://issues.apache.org/jira/browse/YARN-5504 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Sreenath Somarajapuram > Assignee: Sreenath Somarajapuram > Attachments: YARN-5504-YARN-3368-0001.patch, > YARN-5504-YARN-3368-0002.patch > > > - Disable tests as we don't have UTs. > - Disable lint & hint as they are not followed by the current codebase, and > are throwing build errors. > - Disable clearing of UI package on building, so that n/w is required only in > the first build. > - Remove duplicate bower installs. > -Change the default packaging.type to 'war' as our UI is a Web application- - > Will keep it in the profile > -Final war should just contain the end result of the build and not all files- > [~wangda] [~vinodkv] [~sunilg] please share your thoughts. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org