[jira] [Comment Edited] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

2016-09-26 Thread Wilfred Spiegelenburg (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523246#comment-15523246
 ] 

Wilfred Spiegelenburg edited comment on YARN-5554 at 9/26/16 2:38 PM:
--

The test failure is logged as YARN-5043 and is not related to the changes made


was (Author: wilfreds):
The test failure is logged as YARN-5043 and i snot related to the changes made

> MoveApplicationAcrossQueues does not check user permission on the target queue
> --
>
> Key: YARN-5554
> URL: https://issues.apache.org/jira/browse/YARN-5554
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.7.2
>Reporter: Haibo Chen
>Assignee: Wilfred Spiegelenburg
> Attachments: YARN-5554.2.patch, YARN-5554.3.patch, YARN-5554.4.patch, 
> YARN-5554.5.patch
>
>
> moveApplicationAcrossQueues operation currently does not check user 
> permission on the target queue. This incorrectly allows one user to move 
> his/her own applications to a queue that the user has no access to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

2016-08-31 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453039#comment-15453039
 ] 

Yufei Gu edited comment on YARN-5554 at 8/31/16 8:12 PM:
-

Thanks [~wilfreds] for working on this. The patch looks good to me generally. 
My one concern is that {{moveApplicationAcrossQueues}} doesn't check if the 
queue exists first, neither do its callers. It's OK since its callee like 
{{queueACLsManager.checkAccess}} did the NULL check of the target queue, but 
the LOG information seems vague. What about to do the NULL check in 
{{moveApplicationAcrossQueues}} and provide the explicitly information of 
"target queue does't exist" and remove the NULL check in its callee like 
function {{queueACLsManager.checkAccess}} added in this patch.


was (Author: yufeigu):
Thanks [~wilfreds] for working on this. The patch looks good to me generally. 
My one concern is that {{moveApplicationAcrossQueues}} doesn't check if the 
queue exists first, neither do its callers. I can see it's OK its callee like 
{{queueACLsManager.checkAccess}} did the NULL check of the target queue but the 
LOG information seems vague. What about to do the NULL check in 
{{moveApplicationAcrossQueues}} and provide the explicitly information of 
"target queue does't exist" and remove the NULL check in its callee like 
function {{queueACLsManager.checkAccess}} added in this patch.

> MoveApplicationAcrossQueues does not check user permission on the target queue
> --
>
> Key: YARN-5554
> URL: https://issues.apache.org/jira/browse/YARN-5554
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.7.2
>Reporter: Haibo Chen
>Assignee: Wilfred Spiegelenburg
> Attachments: YARN-5554.2.patch, YARN-5554.3.patch
>
>
> moveApplicationAcrossQueues operation currently does not check user 
> permission on the target queue. This incorrectly allows one user to move 
> his/her own applications to a queue that the user has no access to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

2016-08-31 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453039#comment-15453039
 ] 

Yufei Gu edited comment on YARN-5554 at 8/31/16 8:13 PM:
-

Thanks [~wilfreds] for working on this. The patch looks good to me generally. 
My one thought is that {{moveApplicationAcrossQueues}} doesn't check if the 
queue exists first, neither do its callers. It's OK since its callee like 
{{queueACLsManager.checkAccess}} did the NULL check of the target queue, but 
the LOG information seems vague. What about to do the NULL check in 
{{moveApplicationAcrossQueues}} and provide the explicitly information of 
"target queue does't exist" and remove the NULL check in its callee like 
function {{queueACLsManager.checkAccess}} added in this patch.


was (Author: yufeigu):
Thanks [~wilfreds] for working on this. The patch looks good to me generally. 
My one concern is that {{moveApplicationAcrossQueues}} doesn't check if the 
queue exists first, neither do its callers. It's OK since its callee like 
{{queueACLsManager.checkAccess}} did the NULL check of the target queue, but 
the LOG information seems vague. What about to do the NULL check in 
{{moveApplicationAcrossQueues}} and provide the explicitly information of 
"target queue does't exist" and remove the NULL check in its callee like 
function {{queueACLsManager.checkAccess}} added in this patch.

> MoveApplicationAcrossQueues does not check user permission on the target queue
> --
>
> Key: YARN-5554
> URL: https://issues.apache.org/jira/browse/YARN-5554
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.7.2
>Reporter: Haibo Chen
>Assignee: Wilfred Spiegelenburg
> Attachments: YARN-5554.2.patch, YARN-5554.3.patch
>
>
> moveApplicationAcrossQueues operation currently does not check user 
> permission on the target queue. This incorrectly allows one user to move 
> his/her own applications to a queue that the user has no access to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (YARN-5554) MoveApplicationAcrossQueues does not check user permission on the target queue

2016-08-31 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453039#comment-15453039
 ] 

Yufei Gu edited comment on YARN-5554 at 8/31/16 8:13 PM:
-

Thanks [~wilfreds] for working on this. The patch looks good to me generally. 
My one thought is that {{moveApplicationAcrossQueues}} doesn't check if the 
queue exists before ACL checking, neither do its callers. It's OK since its 
callee like {{queueACLsManager.checkAccess}} did the NULL check of the target 
queue, but the LOG information seems vague. What about to do the NULL check in 
{{moveApplicationAcrossQueues}} and provide the explicitly information of 
"target queue does't exist" and remove the NULL check in its callee like 
function {{queueACLsManager.checkAccess}} added in this patch.


was (Author: yufeigu):
Thanks [~wilfreds] for working on this. The patch looks good to me generally. 
My one thought is that {{moveApplicationAcrossQueues}} doesn't check if the 
queue exists first, neither do its callers. It's OK since its callee like 
{{queueACLsManager.checkAccess}} did the NULL check of the target queue, but 
the LOG information seems vague. What about to do the NULL check in 
{{moveApplicationAcrossQueues}} and provide the explicitly information of 
"target queue does't exist" and remove the NULL check in its callee like 
function {{queueACLsManager.checkAccess}} added in this patch.

> MoveApplicationAcrossQueues does not check user permission on the target queue
> --
>
> Key: YARN-5554
> URL: https://issues.apache.org/jira/browse/YARN-5554
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: resourcemanager
>Affects Versions: 2.7.2
>Reporter: Haibo Chen
>Assignee: Wilfred Spiegelenburg
> Attachments: YARN-5554.2.patch, YARN-5554.3.patch
>
>
> moveApplicationAcrossQueues operation currently does not check user 
> permission on the target queue. This incorrectly allows one user to move 
> his/her own applications to a queue that the user has no access to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org