[jira] [Comment Edited] (YARN-7143) FileNotFound handling in ResourceUtils is inconsistent

2017-11-07 Thread Daniel Templeton (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242852#comment-16242852
 ] 

Daniel Templeton edited comment on YARN-7143 at 11/7/17 8:49 PM:
-

Rebased to trunk and removed the return value from {{addResourcesFileToConf()}} 
since we weren't doing anything with it.  If we can't find the file, I don't 
think there's any need to do more than just log that fact, which we do.


was (Author: templedf):
Rebased to trunk and removed the return value from {{addResourcesFileToConf()}} 
since we weren't doing anything with it.  If we can't find the file, I don't 
think there's any need to more than just log that fact, which we do.

> FileNotFound handling in ResourceUtils is inconsistent
> --
>
> Key: YARN-7143
> URL: https://issues.apache.org/jira/browse/YARN-7143
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>Assignee: Daniel Templeton
> Attachments: YARN-7143.002.patch, YARN-7143.YARN-3926.001.patch
>
>
> When loading the resource-types.xml file, we warn and move on if it's not 
> found.  When loading the node-resource.xml file, we abort loading resource 
> types if the file isn't found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (YARN-7143) FileNotFound handling in ResourceUtils is inconsistent

2017-09-01 Thread Sunil G (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150581#comment-16150581
 ] 

Sunil G edited comment on YARN-7143 at 9/1/17 3:23 PM:
---

Yes. Thats correct. In case of node-resources also we have to do. Sounds like 
we are not handling the return value of *addResourcesFileToConf* in this patch. 
Please help to log and handle in case of error.


was (Author: sunilg):
Yes. Thats correct. In case of node-resources also we have to do. Sounds like 
we are handling the return value of *addResourcesFileToConf* in this patch. 
Please help to log and handle in case of error.

> FileNotFound handling in ResourceUtils is inconsistent
> --
>
> Key: YARN-7143
> URL: https://issues.apache.org/jira/browse/YARN-7143
> Project: Hadoop YARN
>  Issue Type: Sub-task
>  Components: resourcemanager
>Affects Versions: YARN-3926
>Reporter: Daniel Templeton
>Assignee: Daniel Templeton
> Attachments: YARN-7143.YARN-3926.001.patch
>
>
> When loading the resource-types.xml file, we warn and move on if it's not 
> found.  When loading the node-resource.xml file, we abort loading resource 
> types if the file isn't found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org