[jira] [Comment Edited] (YARN-8435) NPE when the same client simultaneously contact for the first time Yarn Router

2018-07-03 Thread Giovanni Matteo Fumarola (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532071#comment-16532071
 ] 

Giovanni Matteo Fumarola edited comment on YARN-8435 at 7/3/18 11:43 PM:
-

Thanks [~tanujnay] for testing it and [~NeoMatrix]  for the patch.
Few days ago we hit the same bug in one of our test machines.

The javadoc and the comments have few typos and imperfection. I tried to 
correct them. [~NeoMatrix]  Can you update the patch with typo-free comments 
below?
{code:java}
This test validates if the ClientRequestInterceptor chain for the user can 
build and init correctly when a multi-client process begins to request 
RouterClientRMService for the same user simultaneously.
{code}
{noformat}
ClientTestThread is a thread to simulate a client request to get a 
ClientRequestInterceptor for the user.
{noformat}
{noformat}
We start the first thread. It should not finish initing a chainWrapper before 
the other thread starts. In this way, the second thread can init at the same 
time of the first one. In the end, we validate that the 2 threads get the same 
chainWrapper without going into error.{noformat}


was (Author: giovanni.fumarola):
Thanks [~tanujnay] for testing it and [~NeoMatrix]  for the patch.
Few days ago we hit the same bug in one of our test machines.


The javadoc and the comments have few typos. I tried to correct them. 
[~NeoMatrix]  Can you update the patch with typo-free comments below?
{code:java}
This test validates if the ClientRequestInterceptor chain for the user can 
build and init correctly when a multi-client process begins to request 
RouterClientRMService for the same user simultaneously.
{code}
{noformat}
ClientTestThread is a thread to simulate a client request to get a 
ClientRequestInterceptor for the user.
{noformat}
{noformat}
We start the first thread. It should not finish initing a chainWrapper before 
the other thread starts. In this way, the second thread can init at the same 
time of the first one. In the end, we validate that the 2 threads get the same 
chainWrapper without going into error.{noformat}

> NPE when the same client simultaneously contact for the first time Yarn Router
> --
>
> Key: YARN-8435
> URL: https://issues.apache.org/jira/browse/YARN-8435
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: router
>Affects Versions: 2.9.0, 3.0.2
>Reporter: rangjiaheng
>Priority: Critical
> Attachments: YARN-8435.v1.patch, YARN-8435.v2.patch, 
> YARN-8435.v3.patch, YARN-8435.v4.patch, YARN-8435.v5.patch, YARN-8435.v6.patch
>
>
> When Two client process (with the same user name and the same hostname) begin 
> to connect to yarn router at the same time, to submit application, kill 
> application, ... and so on, then a java.lang.NullPointerException may throws 
> from yarn router.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (YARN-8435) NPE when the same client simultaneously contact for the first time Yarn Router

2018-06-29 Thread Giovanni Matteo Fumarola (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528350#comment-16528350
 ] 

Giovanni Matteo Fumarola edited comment on YARN-8435 at 6/29/18 10:59 PM:
--

Thanks [~tanujnay] for validating the fix and to find the performance 
regression.
 [~NeoMatrix]  do you mind changing the code in a way that does not create the 
pipeline for every request?


was (Author: giovanni.fumarola):
Thanks [~tanujnay] for validating the fix and to find the performance 
regression.
[~NeoMatrix]  do you mind changing the code in a way that does not create the 
pipeline for every requests?

> NPE when the same client simultaneously contact for the first time Yarn Router
> --
>
> Key: YARN-8435
> URL: https://issues.apache.org/jira/browse/YARN-8435
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: router
>Affects Versions: 2.9.0, 3.0.2
>Reporter: rangjiaheng
>Priority: Critical
> Attachments: YARN-8435.v1.patch, YARN-8435.v2.patch, 
> YARN-8435.v3.patch, YARN-8435.v4.patch, YARN-8435.v5.patch
>
>
> When Two client process (with the same user name and the same hostname) begin 
> to connect to yarn router at the same time, to submit application, kill 
> application, ... and so on, then a java.lang.NullPointerException may throws 
> from yarn router.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org