[
https://issues.apache.org/jira/browse/YARN-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797023#comment-16797023
]
Peter Bacsko edited comment on YARN-9267 at 3/20/19 10:32 AM:
--
[~devaraj.k] the reason I introduced the method reference is because I wanted
to avoid unnecessary file creation/deletion in the unit tests, so I can replace
it with a simple piece of code which returns a string. It's usually a good
practice to do in unit tests, but I'm not a fundamentalist so I can go a
file-creation way if you think it's better. Or we keep this solution and add a
comment to make it clear.
Regarding the loop: that's a valid comment.
was (Author: pbacsko):
[~devaraj.k] the reason I introduced the method reference is because I wanted
to avoid unnecessary file creation/deletion in the unit tests, so I can replace
it with a simple code which returns a string. It's usually a good practice to
do in unit tests, but I'm not a fundamentalist so I can go a file-creation way
if you think it's better. Or we keep this solution and add a comment to make it
clear.
Regarding the loop: that's a valid comment.
> General improvements in FpgaResourceHandlerImpl
> ---
>
> Key: YARN-9267
> URL: https://issues.apache.org/jira/browse/YARN-9267
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
> Attachments: YARN-9267-001.patch, YARN-9267-002.patch,
> YARN-9267-003.patch, YARN-9267-004.patch, YARN-9267-005.patch,
> YARN-9267-006.patch, YARN-9267-007.patch
>
>
> Fix some problems in {{FpgaResourceHandlerImpl}}:
> * {{preStart()}} does not reconfigure card with the same IP - we see it as a
> problem. If you recompile the FPGA application, you must rename the aocx file
> because the card will not be reprogrammed. Suggestion: instead of storing
> Node<\->IPID mapping, store Node<\->IPID hash (like the SHA-256 of the
> localized file).
> * Switch to slf4j from Apache Commons Logging
> * Some unused imports
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
