[jira] [Comment Edited] (YARN-9398) Javadoc error on FPGA related java files

2019-03-20 Thread Daniel Templeton (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797185#comment-16797185
 ] 

Daniel Templeton edited comment on YARN-9398 at 3/20/19 1:46 PM:
-

I went ahead and posted a patch.


was (Author: templedf):
I went ahead and posted patch.

> Javadoc error on FPGA related java files
> 
>
> Key: YARN-9398
> URL: https://issues.apache.org/jira/browse/YARN-9398
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Eric Yang
>Assignee: Daniel Templeton
>Priority: Major
> Attachments: YARN-9398.001.patch
>
>
> {code}
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:46:
>  warning: no @param for conf
> [ERROR]   boolean initPlugin(Configuration conf);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:46:
>  warning: no @return
> [ERROR]   boolean initPlugin(Configuration conf);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:51:
>  warning: no @param for timeout
> [ERROR]   boolean diagnose(int timeout);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:51:
>  warning: no @return
> [ERROR]   boolean diagnose(int timeout);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:64:
>  warning: no @return
> [ERROR]   String getFpgaType();
> [ERROR]  ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/FpgaDiscoverer.java:119:
>  warning: no @return
> [ERROR]   public List discover()
> [ERROR] ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/FpgaDiscoverer.java:119:
>  warning: no @throws for 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.ResourceHandlerException
> [ERROR]   public List discover()
> [ERROR] ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/IntelFpgaOpenclPlugin.java:156:
>  error: bad HTML entity
> [ERROR]*  Helper class to run aocl diagnose & determine major/minor 
> numbers.
> {code}
> YARN-9266 introduced some javadoc compilation errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (YARN-9398) Javadoc error on FPGA related java files

2019-03-19 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796244#comment-16796244
 ] 

Eric Yang edited comment on YARN-9398 at 3/19/19 4:25 PM:
--

[~templedf] There is only one that is introduced 6 days ago that breaks the 
build, which is the last item on my list.  The other are warning messages but 
the build can still succeed.

{code}
[ERROR] 
/home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/IntelFpgaOpenclPlugin.java:156:
 error: bad HTML entity
[ERROR]*  Helper class to run aocl diagnose & determine major/minor numbers.
{code}

I didn't capture all of the warnings, but a subset of them that were introduced 
in YARN-9266.


was (Author: eyang):
[~templedf] There is only one that is introduced 6 days ago that breaks the 
build, which is the last item on my list.  The other are warning messages but 
the build can still succeed.

{code}
[ERROR] 
/home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/IntelFpgaOpenclPlugin.java:156:
 error: bad HTML entity
[ERROR]*  Helper class to run aocl diagnose & determine major/minor numbers.
{code}

I didn't capture all of the errors, but a subset of them that were introduced 
in YARN-9266.

> Javadoc error on FPGA related java files
> 
>
> Key: YARN-9398
> URL: https://issues.apache.org/jira/browse/YARN-9398
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Eric Yang
>Assignee: Peter Bacsko
>Priority: Major
>
> {code}
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:46:
>  warning: no @param for conf
> [ERROR]   boolean initPlugin(Configuration conf);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:46:
>  warning: no @return
> [ERROR]   boolean initPlugin(Configuration conf);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:51:
>  warning: no @param for timeout
> [ERROR]   boolean diagnose(int timeout);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:51:
>  warning: no @return
> [ERROR]   boolean diagnose(int timeout);
> [ERROR]   ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/AbstractFpgaVendorPlugin.java:64:
>  warning: no @return
> [ERROR]   String getFpgaType();
> [ERROR]  ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/FpgaDiscoverer.java:119:
>  warning: no @return
> [ERROR]   public List discover()
> [ERROR] ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/FpgaDiscoverer.java:119:
>  warning: no @throws for 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.ResourceHandlerException
> [ERROR]   public List discover()
> [ERROR] ^
> [ERROR] 
> /home/eyang/test/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/resourceplugin/fpga/IntelFpgaOpenclPlugin.java:156:
>  error: bad HTML entity
> [ERROR]*  Helper class to run aocl diagnose & determine major/minor 
> numbers.
> {code}
> YARN-9266 introduced some javadoc compilation errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-