[jira] [Commented] (YARN-10087) ATS possible NPE on REST API when data is missing
[ https://issues.apache.org/jira/browse/YARN-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17565959#comment-17565959 ] Samrat Deb commented on YARN-10087: --- picking this up! > ATS possible NPE on REST API when data is missing > - > > Key: YARN-10087 > URL: https://issues.apache.org/jira/browse/YARN-10087 > Project: Hadoop YARN > Issue Type: Bug > Components: ATSv2 >Reporter: Wilfred Spiegelenburg >Assignee: Tanu Ajmera >Priority: Major > Labels: newbie > Attachments: ats_stack.txt > > > If the data stored by the ATS is not complete REST calls to the ATS can > return a NPE instead of results. > {{{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException"}}} > The issue shows up when the ATS was down for a short period and in that time > new applications were started. This causes certain parts of the application > data to be missing in the ATS store. In most cases this is not a problem and > data will be returned but when you start filtering data the filtering fails > throwing the NPE. > In this case the request was for: > {{http://:8188/ws/v1/applicationhistory/apps?user=hive'}} > If certain pieces of data are missing the ATS should not even consider > returning that data, filtered or not. We should not display partial or > incomplete data. > In case of the missing user information ACL checks cannot be correctly > performed and we could see more issues. > A similar issue was fixed in YARN-7118 where the queue details were missing. > It just _skips_ the app to prevent the NPE but that is not the correct thing > when the user is missing -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10087) ATS possible NPE on REST API when data is missing
[ https://issues.apache.org/jira/browse/YARN-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541682#comment-17541682 ] Samrat Deb commented on YARN-10087: --- [~tanu.ajmera] , if you are not actively working on this bug ! can i pick this up ? as a newbie , it would help me go deep dive into code and understand some of working and code working associated with ATSĀ > ATS possible NPE on REST API when data is missing > - > > Key: YARN-10087 > URL: https://issues.apache.org/jira/browse/YARN-10087 > Project: Hadoop YARN > Issue Type: Bug > Components: ATSv2 >Reporter: Wilfred Spiegelenburg >Assignee: Tanu Ajmera >Priority: Major > Labels: newbie > Attachments: ats_stack.txt > > > If the data stored by the ATS is not complete REST calls to the ATS can > return a NPE instead of results. > {{{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException"}}} > The issue shows up when the ATS was down for a short period and in that time > new applications were started. This causes certain parts of the application > data to be missing in the ATS store. In most cases this is not a problem and > data will be returned but when you start filtering data the filtering fails > throwing the NPE. > In this case the request was for: > {{http://:8188/ws/v1/applicationhistory/apps?user=hive'}} > If certain pieces of data are missing the ATS should not even consider > returning that data, filtered or not. We should not display partial or > incomplete data. > In case of the missing user information ACL checks cannot be correctly > performed and we could see more issues. > A similar issue was fixed in YARN-7118 where the queue details were missing. > It just _skips_ the app to prevent the NPE but that is not the correct thing > when the user is missing -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10087) ATS possible NPE on REST API when data is missing
[ https://issues.apache.org/jira/browse/YARN-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016530#comment-17016530 ] Wilfred Spiegelenburg commented on YARN-10087: -- Attached the NPE as logged in the ATS logs. The logs point to these lines of code in the release that was running: {code:java} 188 if (userQuery != null && !userQuery.isEmpty()) { 189 if (!appReport.getUser().equals(userQuery)) { 190 continue; 191 } 192 } {code} > ATS possible NPE on REST API when data is missing > - > > Key: YARN-10087 > URL: https://issues.apache.org/jira/browse/YARN-10087 > Project: Hadoop YARN > Issue Type: Bug > Components: ATSv2 >Reporter: Wilfred Spiegelenburg >Priority: Major > Attachments: ats_stack.txt > > > If the data stored by the ATS is not complete REST calls to the ATS can > return a NPE instead of results. > {{{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException"}}} > The issue shows up when the ATS was down for a short period and in that time > new applications were started. This causes certain parts of the application > data to be missing in the ATS store. In most cases this is not a problem and > data will be returned but when you start filtering data the filtering fails > throwing the NPE. > In this case the request was for: > {{http://:8188/ws/v1/applicationhistory/apps?user=hive'}} > If certain pieces of data are missing the ATS should not even consider > returning that data, filtered or not. We should not display partial or > incomplete data. > In case of the missing user information ACL checks cannot be correctly > performed and we could see more issues. > A similar issue was fixed in YARN-7118 where the queue details were missing. > It just _skips_ the app to prevent the NPE but that is not the correct thing > when the user is missing -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org