[jira] [Commented] (YARN-10388) RMNode updatedCapability flag not set while RecommissionNodeTransition
[ https://issues.apache.org/jira/browse/YARN-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172764#comment-17172764 ] Íñigo Goiri commented on YARN-10388: +1 on [^YARN-10388.001.patch]. I missed it in YARN-999. > RMNode updatedCapability flag not set while RecommissionNodeTransition > -- > > Key: YARN-10388 > URL: https://issues.apache.org/jira/browse/YARN-10388 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Pranjal Protim Borah >Assignee: Pranjal Protim Borah >Priority: Major > Attachments: YARN-10388.001.patch > > > RMNode updatedCapability flag is not set while RecommissionNodeTransition > happens. RM gets updated of new totalcapability when recommissioning of node > happens. But the nodemanager still has old totalcapability and is not aware > of the change. Setting this flag while RecommissionNodeTransition would > update nodemanager of totalcapability change as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10388) RMNode updatedCapability flag not set while RecommissionNodeTransition
[
https://issues.apache.org/jira/browse/YARN-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172238#comment-17172238
]
Hadoop QA commented on YARN-10388:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
2s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
29s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
54s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_252-8u252-b09-1~18.04-b09 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 32s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_252-8u252-b09-1~18.04-b09 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
41s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
56s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
12s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
38s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_252-8u252-b09-1~18.04-b09 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 48s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed with JDK Private
Build-1.8.0_252-8u252-b09-1~18.04-b09 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit
[jira] [Commented] (YARN-10388) RMNode updatedCapability flag not set while RecommissionNodeTransition
[ https://issues.apache.org/jira/browse/YARN-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172128#comment-17172128 ] Bibin Chundatt commented on YARN-10388: --- Over all the patch looks good to me.. +1. Wait for jenkins result.. cc : [~inigoiri] > RMNode updatedCapability flag not set while RecommissionNodeTransition > -- > > Key: YARN-10388 > URL: https://issues.apache.org/jira/browse/YARN-10388 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Pranjal Protim Borah >Assignee: Pranjal Protim Borah >Priority: Major > Attachments: YARN-10388.001.patch > > > RMNode updatedCapability flag is not set while RecommissionNodeTransition > happens. RM gets updated of new totalcapability when recommissioning of node > happens. But the nodemanager still has old totalcapability and is not aware > of the change. Setting this flag while RecommissionNodeTransition would > update nodemanager of totalcapability change as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-10388) RMNode updatedCapability flag not set while RecommissionNodeTransition
[ https://issues.apache.org/jira/browse/YARN-10388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172043#comment-17172043 ] Bibin Chundatt commented on YARN-10388: --- Good catch [~lapjarn] . > RMNode updatedCapability flag not set while RecommissionNodeTransition > -- > > Key: YARN-10388 > URL: https://issues.apache.org/jira/browse/YARN-10388 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Pranjal Protim Borah >Assignee: Pranjal Protim Borah >Priority: Major > > RMNode updatedCapability flag is not set while RecommissionNodeTransition > happens. RM gets updated of new totalcapability when recommissioning of node > happens. But the nodemanager still has old totalcapability and is not aware > of the change. Setting this flag while RecommissionNodeTransition would > update nodemanager of totalcapability change as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
