[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803786#comment-17803786 ] Shilun Fan commented on YARN-11588: --- [~jchanggg] Add to YARN’s Contributor list. Welcome to hadoop! > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Jeffrey Chang >Assignee: Jeffrey Chang >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780089#comment-17780089 ] ASF GitHub Bot commented on YARN-11588: --- goiri merged PR #6222: URL: https://github.com/apache/hadoop/pull/6222 > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779992#comment-17779992
]
ASF GitHub Bot commented on YARN-11588:
---
hadoop-yetus commented on PR #6222:
URL: https://github.com/apache/hadoop/pull/6222#issuecomment-1781464355
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 15m 47s | | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 32m 45s |
[/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6222/2/artifact/out/branch-mvninstall-root.txt)
| root in trunk failed. |
| +1 :green_heart: | compile | 7m 41s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 7m 0s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 2m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 57s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 3s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 2m 44s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 5m 31s | | trunk passed |
| +1 :green_heart: | shadedclient | 34m 49s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 34s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 39s | | the patch passed |
| +1 :green_heart: | compile | 6m 46s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 6m 46s | | the patch passed |
| +1 :green_heart: | compile | 6m 52s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 6m 52s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 54s | | the patch passed |
| +1 :green_heart: | mvnsite | 2m 49s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 42s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 2m 38s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 5m 39s | | the patch passed |
| +1 :green_heart: | shadedclient | 34m 31s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 19s | | hadoop-yarn-api in the patch
passed. |
| +1 :green_heart: | unit | 5m 52s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 0m 48s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | asflicense | 1m 5s | | The patch does not
generate ASF License warnings. |
| | | 197m 27s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6222/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6222 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux 6d5f7d339530 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / de918dc65603dcb8d239a5724f543169c4571ccf |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779576#comment-17779576
]
ASF GitHub Bot commented on YARN-11588:
---
hadoop-yetus commented on PR #6222:
URL: https://github.com/apache/hadoop/pull/6222#issuecomment-1779674301
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 25s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 15m 54s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 20m 1s | | trunk passed |
| +1 :green_heart: | compile | 4m 30s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 4m 7s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 1m 14s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 15s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 19s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 2m 8s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 43s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 58s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 12s | | the patch passed |
| +1 :green_heart: | compile | 3m 47s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 3m 47s | | the patch passed |
| +1 :green_heart: | compile | 3m 58s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 3m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 8s |
[/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6222/1/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt)
| hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 164 unchanged
- 0 fixed = 166 total (was 164) |
| +1 :green_heart: | mvnsite | 2m 1s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 1s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 57s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 3m 49s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 41s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 57s | | hadoop-yarn-api in the patch
passed. |
| +1 :green_heart: | unit | 4m 51s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 0m 37s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | asflicense | 0m 47s | | The patch does not
generate ASF License warnings. |
| | | 132m 29s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6222/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6222 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux f75dc89380ff 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 45701476559d7b849363f17cbb696efdc8b13843 |
| Default Java |
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779534#comment-17779534 ] ASF GitHub Bot commented on YARN-11588: --- slfan1989 opened a new pull request, #6222: URL: https://github.com/apache/hadoop/pull/6222 ### Description of PR JIRA: YARN-11588. [Federation] [Addendum] Fix uncleaned threads in yarn router thread pool executor. ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774442#comment-17774442 ] ASF GitHub Bot commented on YARN-11588: --- slfan1989 commented on PR #6159: URL: https://github.com/apache/hadoop/pull/6159#issuecomment-1759410254 @jchanggg Thank you for your contribution! @goiri Thank you for your help reviewing the code! > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774441#comment-17774441 ] ASF GitHub Bot commented on YARN-11588: --- slfan1989 merged PR #6159: URL: https://github.com/apache/hadoop/pull/6159 > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774263#comment-17774263 ] ASF GitHub Bot commented on YARN-11588: --- jchanggg commented on PR #6159: URL: https://github.com/apache/hadoop/pull/6159#issuecomment-1758693970 Thanks for helping review folks. If there are no other issues, could we merge in the patch? > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773496#comment-17773496
]
ASF GitHub Bot commented on YARN-11588:
---
jchanggg commented on code in PR #6159:
URL: https://github.com/apache/hadoop/pull/6159#discussion_r1351004555
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##
@@ -230,6 +230,9 @@ public void init(String userName) {
this.executorService = new ThreadPoolExecutor(numMinThreads, numMaxThreads,
keepAliveTime, TimeUnit.MILLISECONDS, workQueue, threadFactory);
+// Adding this line so that unused user threads will exit and be cleaned
up if idle for too long
+this.executorService.allowCoreThreadTimeOut(true);
Review Comment:
Yea, seems there is some extra whitespace, removed them.
> Fix uncleaned threads in YARN Federation interceptor threadpool
> ---
>
> Key: YARN-11588
> URL: https://issues.apache.org/jira/browse/YARN-11588
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jeffrey Chang
>Priority: Major
> Labels: pull-request-available
>
> In YARN Federation a new interceptor is generated for each new user that
> calls YARN Router. This also generates a threadpool which is used to call
> YARN RM. However, when the call is finished the threadpool threads never
> exits, causing the interceptor object for the user to never be cleaned up.
> This causes an issue when the number of users is large in the YARN cluster,
> as the number of idle, uncleaned thread can reach # of users calling router
> times number of active core threads in thread pool. This causes performance
> issues in router due to too many idle threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773494#comment-17773494
]
ASF GitHub Bot commented on YARN-11588:
---
hadoop-yetus commented on PR #6159:
URL: https://github.com/apache/hadoop/pull/6159#issuecomment-1754051300
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 41m 56s | | trunk passed |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 34s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 0m 34s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 41s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 1m 1s | | trunk passed |
| +1 :green_heart: | shadedclient | 33m 22s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 25s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | compile | 0m 23s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 0m 23s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 19s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 26s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 25s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 0m 56s | | the patch passed |
| +1 :green_heart: | shadedclient | 32m 49s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 31s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | asflicense | 0m 39s | | The patch does not
generate ASF License warnings. |
| | | 123m 17s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6159 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux d0dbdacc3035 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 6982147ca9db9132856ae584b57dd712bb0c2049 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/2/testReport/ |
| Max. process+thread count | 555 (vs. ulimit of 5500) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773472#comment-17773472
]
ASF GitHub Bot commented on YARN-11588:
---
goiri commented on code in PR #6159:
URL: https://github.com/apache/hadoop/pull/6159#discussion_r1350774738
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##
@@ -230,6 +230,9 @@ public void init(String userName) {
this.executorService = new ThreadPoolExecutor(numMinThreads, numMaxThreads,
keepAliveTime, TimeUnit.MILLISECONDS, workQueue, threadFactory);
+// Adding this line so that unused user threads will exit and be cleaned
up if idle for too long
+this.executorService.allowCoreThreadTimeOut(true);
Review Comment:
There's a checkstyle warning here?
> Fix uncleaned threads in YARN Federation interceptor threadpool
> ---
>
> Key: YARN-11588
> URL: https://issues.apache.org/jira/browse/YARN-11588
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Jeffrey Chang
>Priority: Major
> Labels: pull-request-available
>
> In YARN Federation a new interceptor is generated for each new user that
> calls YARN Router. This also generates a threadpool which is used to call
> YARN RM. However, when the call is finished the threadpool threads never
> exits, causing the interceptor object for the user to never be cleaned up.
> This causes an issue when the number of users is large in the YARN cluster,
> as the number of idle, uncleaned thread can reach # of users calling router
> times number of active core threads in thread pool. This causes performance
> issues in router due to too many idle threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773248#comment-17773248 ] ASF GitHub Bot commented on YARN-11588: --- slfan1989 commented on PR #6159: URL: https://github.com/apache/hadoop/pull/6159#issuecomment-1752786105 @jchanggg I think we shouldn't modify this value. Instead, we should ensure a minimum number of core threads. > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > Labels: pull-request-available > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[
https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773230#comment-17773230
]
ASF GitHub Bot commented on YARN-11588:
---
hadoop-yetus commented on PR #6159:
URL: https://github.com/apache/hadoop/pull/6159#issuecomment-1752738299
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 42m 56s | | trunk passed |
| +1 :green_heart: | compile | 0m 37s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 34s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 0m 33s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 39s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 41s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 1m 1s | | trunk passed |
| +1 :green_heart: | shadedclient | 33m 6s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 24s |
[/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/1/artifact/out/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt)
| hadoop-yarn-server-router in the patch failed. |
| -1 :x: | compile | 0m 26s |
[/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/1/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt)
| hadoop-yarn-server-router in the patch failed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04. |
| -1 :x: | javac | 0m 26s |
[/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/1/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt)
| hadoop-yarn-server-router in the patch failed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04. |
| -1 :x: | compile | 0m 24s |
[/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/1/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt)
| hadoop-yarn-server-router in the patch failed with JDK Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05. |
| -1 :x: | javac | 0m 24s |
[/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/1/artifact/out/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt)
| hadoop-yarn-server-router in the patch failed with JDK Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05. |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6159/1/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 0m 19s | | the patch passed |
| -1 :x: | mvnsite | 0m 25s |
[jira] [Commented] (YARN-11588) Fix uncleaned threads in YARN Federation interceptor threadpool
[ https://issues.apache.org/jira/browse/YARN-11588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773179#comment-17773179 ] ASF GitHub Bot commented on YARN-11588: --- jchanggg opened a new pull request, #6159: URL: https://github.com/apache/hadoop/pull/6159 JIRA: [YARN-11588](https://issues.apache.org/jira/browse/YARN-11588). [Router] Fix uncleaned threads in yarn router thread pool executor ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > Fix uncleaned threads in YARN Federation interceptor threadpool > --- > > Key: YARN-11588 > URL: https://issues.apache.org/jira/browse/YARN-11588 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Jeffrey Chang >Priority: Major > > In YARN Federation a new interceptor is generated for each new user that > calls YARN Router. This also generates a threadpool which is used to call > YARN RM. However, when the call is finished the threadpool threads never > exits, causing the interceptor object for the user to never be cleaned up. > This causes an issue when the number of users is large in the YARN cluster, > as the number of idle, uncleaned thread can reach # of users calling router > times number of active core threads in thread pool. This causes performance > issues in router due to too many idle threads. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
