[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767497#comment-13767497
 ] 

Hudson commented on YARN-1189:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1548 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1548/])
YARN-1189. NMTokenSecretManagerInNM is not being told when applications have 
finished. Contributed by Omkar Vinit Joshi (jlowe: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1523158)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/TestApplication.java


 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta, 2.1.1-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
Priority: Blocker
 Fix For: 3.0.0, 2.1.1-beta

 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Omkar Vinit Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766208#comment-13766208
 ] 

Omkar Vinit Joshi commented on YARN-1189:
-

Yes this is clearly a leak... I had this locally when I was working on 
it..somehow missed the change.. It should be called when application completely 
finishes..Attaching a quick patch...

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi

 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766221#comment-13766221
 ] 

Hadoop QA commented on YARN-1189:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12602954/YARN-1189-20130912.1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:

  
org.apache.hadoop.yarn.server.nodemanager.containermanager.application.TestApplication
  
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestLocalResourcesTrackerImpl

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/1910//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1910//console

This message is automatically generated.

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
 Attachments: YARN-1189-20130912.1.patch


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Omkar Vinit Joshi (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766713#comment-13766713
 ] 

Omkar Vinit Joshi commented on YARN-1189:
-

looks good to me.. thanks [~jlowe] 

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta, 2.1.1-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
Priority: Blocker
 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Daryn Sharp (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766738#comment-13766738
 ] 

Daryn Sharp commented on YARN-1189:
---

Oops, I thought the .1 patch was the latest so I didn't see the test.

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta, 2.1.1-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
Priority: Blocker
 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Daryn Sharp (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766728#comment-13766728
 ] 

Daryn Sharp commented on YARN-1189:
---

+1 but a test, even a mock that spies appFinished would be great to avoid a 
regression

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta, 2.1.1-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
Priority: Blocker
 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766499#comment-13766499
 ] 

Hadoop QA commented on YARN-1189:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12603017/YARN-1189-20130913.txt
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/1913//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1913//console

This message is automatically generated.

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Jason Lowe (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767214#comment-13767214
 ] 

Jason Lowe commented on YARN-1189:
--

Thanks for the review, Daryn.  Committing this.

 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta, 2.1.1-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
Priority: Blocker
 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (YARN-1189) NMTokenSecretManagerInNM is not being told when applications have finished

2013-09-13 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767231#comment-13767231
 ] 

Hudson commented on YARN-1189:
--

SUCCESS: Integrated in Hadoop-trunk-Commit #4412 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/4412/])
YARN-1189. NMTokenSecretManagerInNM is not being told when applications have 
finished. Contributed by Omkar Vinit Joshi (jlowe: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1523158)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/TestApplication.java


 NMTokenSecretManagerInNM is not being told when applications have finished 
 ---

 Key: YARN-1189
 URL: https://issues.apache.org/jira/browse/YARN-1189
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 2.1.0-beta, 2.1.1-beta
Reporter: Jason Lowe
Assignee: Omkar Vinit Joshi
Priority: Blocker
 Attachments: YARN-1189-20130912.1.patch, YARN-1189-20130913.txt


 The {{appFinished}} method is not being called when applications have 
 finished.  This causes a couple of leaks as {{oldMasterKeys}} and 
 {{appToAppAttemptMap}} are never being pruned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira