[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899546#comment-13899546
]
Tsuyoshi OZAWA commented on YARN-1296:
--
[~sandyr], do you have any comment about this JIRA?
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899578#comment-13899578
]
Sandy Ryza commented on YARN-1296:
--
I'm not super familiar with this code, but [~ywskycn] might be?
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899608#comment-13899608
]
Wei Yan commented on YARN-1296:
---
Sorry I missed this jira before.
I'll look into the patch. thanks.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899909#comment-13899909
]
Wei Yan commented on YARN-1296:
---
+1, the patch looks good to me. Looks also need to hold lock in the
handle(SchedulerEvent schedulerEvent) function.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900068#comment-13900068
]
Wei Yan commented on YARN-1296:
---
Re-look the code. Do we really need to add a lock to lock the
schedulerAllocateTimer? schedulerAllocateTimer is only updated in the
allocate() function.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898433#comment-13898433
]
Ted Yu commented on YARN-1296:
--
Is more review needed ?
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13898475#comment-13898475
]
Hadoop QA commented on YARN-1296:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12607939/yarn-1296-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-tools/hadoop-sls.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3070//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3070//console
This message is automatically generated.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793966#comment-13793966
]
Tsuyoshi OZAWA commented on YARN-1296:
--
+1. For now we don't have a big issue because of this, but we should fix it to
make the code extendable.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13792849#comment-13792849
]
Ted Yu commented on YARN-1296:
--
The test failure should be solved by YARN-1300
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13792297#comment-13792297
]
Hadoop QA commented on YARN-1296:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12607939/yarn-1296-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-tools/hadoop-sls:
org.apache.hadoop.yarn.sls.TestSLSRunner
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2165//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2165//console
This message is automatically generated.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1296) schedulerAllocateTimer is accessed without holding samplerLock in ResourceSchedulerWrapper
[
https://issues.apache.org/jira/browse/YARN-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13792303#comment-13792303
]
Ted Yu commented on YARN-1296:
--
I found these two fair-scheduler-allocation.xml :
./hadoop-tools/hadoop-sls/src/main/sample-conf/fair-scheduler-allocation.xml
./hadoop-tools/hadoop-sls/src/test/resources/fair-scheduler-allocation.xml
But they seem to have 'allocations' as top-level element.
schedulerAllocateTimer is accessed without holding samplerLock in
ResourceSchedulerWrapper
--
Key: YARN-1296
URL: https://issues.apache.org/jira/browse/YARN-1296
Project: Hadoop YARN
Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
Attachments: yarn-1296-v1.patch
Here is related code:
{code}
public Allocation allocate(ApplicationAttemptId attemptId,
ListResourceRequest resourceRequests,
ListContainerId containerIds,
ListString strings, ListString strings2) {
if (metricsON) {
final Timer.Context context = schedulerAllocateTimer.time();
{code}
samplerLock should be used to guard the access.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
