[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873395#comment-13873395 ] Hudson commented on YARN-1351: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1646 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1646/]) YARN-1351. Invalid string format in Fair Scheduler log warn message (Konstantin Weitz via Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1558597) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java > Invalid string format in Fair Scheduler log warn message > > > Key: YARN-1351 > URL: https://issues.apache.org/jira/browse/YARN-1351 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Konstantin Weitz >Assignee: Konstantin Weitz > Fix For: 2.4.0 > > Attachments: fixprnt.patch > > > While trying to print a warning, two values of the wrong type (Resource > instead of int) are passed into a String.format method call, leading to a > runtime exception, in the file: > _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_. > The warning was intended to be printed whenever the resources don't fit into > each other, either because the number of virtual cores or the memory is too > small. I changed the %d's into %s, this way the warning will contain both the > cores and the memory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873373#comment-13873373 ] Hudson commented on YARN-1351: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1671 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1671/]) YARN-1351. Invalid string format in Fair Scheduler log warn message (Konstantin Weitz via Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1558597) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java > Invalid string format in Fair Scheduler log warn message > > > Key: YARN-1351 > URL: https://issues.apache.org/jira/browse/YARN-1351 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Konstantin Weitz >Assignee: Konstantin Weitz > Fix For: 2.4.0 > > Attachments: fixprnt.patch > > > While trying to print a warning, two values of the wrong type (Resource > instead of int) are passed into a String.format method call, leading to a > runtime exception, in the file: > _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_. > The warning was intended to be printed whenever the resources don't fit into > each other, either because the number of virtual cores or the memory is too > small. I changed the %d's into %s, this way the warning will contain both the > cores and the memory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873283#comment-13873283 ] Hudson commented on YARN-1351: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #454 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/454/]) YARN-1351. Invalid string format in Fair Scheduler log warn message (Konstantin Weitz via Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1558597) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java > Invalid string format in Fair Scheduler log warn message > > > Key: YARN-1351 > URL: https://issues.apache.org/jira/browse/YARN-1351 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Konstantin Weitz >Assignee: Konstantin Weitz > Fix For: 2.4.0 > > Attachments: fixprnt.patch > > > While trying to print a warning, two values of the wrong type (Resource > instead of int) are passed into a String.format method call, leading to a > runtime exception, in the file: > _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_. > The warning was intended to be printed whenever the resources don't fit into > each other, either because the number of virtual cores or the memory is too > small. I changed the %d's into %s, this way the warning will contain both the > cores and the memory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872786#comment-13872786 ] Hudson commented on YARN-1351: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5006 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5006/]) YARN-1351. Invalid string format in Fair Scheduler log warn message (Konstantin Weitz via Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1558597) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java > Invalid string format in Fair Scheduler log warn message > > > Key: YARN-1351 > URL: https://issues.apache.org/jira/browse/YARN-1351 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Konstantin Weitz >Assignee: Konstantin Weitz > Fix For: 2.4.0 > > Attachments: fixprnt.patch > > > While trying to print a warning, two values of the wrong type (Resource > instead of int) are passed into a String.format method call, leading to a > runtime exception, in the file: > _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_. > The warning was intended to be printed whenever the resources don't fit into > each other, either because the number of virtual cores or the memory is too > small. I changed the %d's into %s, this way the warning will contain both the > cores and the memory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872767#comment-13872767 ] Sandy Ryza commented on YARN-1351: -- (Sorry for the delay) > Invalid string format in Fair Scheduler log warn message > > > Key: YARN-1351 > URL: https://issues.apache.org/jira/browse/YARN-1351 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Konstantin Weitz >Assignee: Konstantin Weitz > Fix For: 2.4.0 > > Attachments: fixprnt.patch > > > While trying to print a warning, two values of the wrong type (Resource > instead of int) are passed into a String.format method call, leading to a > runtime exception, in the file: > _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_. > The warning was intended to be printed whenever the resources don't fit into > each other, either because the number of virtual cores or the memory is too > small. I changed the %d's into %s, this way the warning will contain both the > cores and the memory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[ https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872698#comment-13872698 ] Konstantin Weitz commented on YARN-1351: Because of the simplicity of the fix, writing a test case would not be worthwhile. Because of the locality and size of the change, I used manual inspection to verify that the patch fixes the problem and does not introduce new problems. Sandy Ryza, do agree with this reasoning, or do you have any suggestions on how to improve the patch? > Invalid string format in Fair Scheduler log warn message > > > Key: YARN-1351 > URL: https://issues.apache.org/jira/browse/YARN-1351 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager >Reporter: Konstantin Weitz > Attachments: fixprnt.patch > > > While trying to print a warning, two values of the wrong type (Resource > instead of int) are passed into a String.format method call, leading to a > runtime exception, in the file: > _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_. > The warning was intended to be printed whenever the resources don't fit into > each other, either because the number of virtual cores or the memory is too > small. I changed the %d's into %s, this way the warning will contain both the > cores and the memory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[
https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805599#comment-13805599
]
Sandy Ryza commented on YARN-1351:
--
+1
> Invalid string format in Fair Scheduler log warn message
>
>
> Key: YARN-1351
> URL: https://issues.apache.org/jira/browse/YARN-1351
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Konstantin Weitz
> Attachments: fixprnt.patch
>
>
> While trying to print a warning, two values of the wrong type (Resource
> instead of int) are passed into a String.format method call, leading to a
> runtime exception, in the file:
> _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_.
> The warning was intended to be printed whenever the resources don't fit into
> each other, either because the number of virtual cores or the memory is too
> small. I changed the %d's into %s, this way the warning will contain both the
> cores and the memory.
> Following the patch that fixes the issue:
> Index:
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> ===
> ---
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (revision 1535589)
> +++
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (working copy)
> @@ -471,7 +471,7 @@
> if (maxQueueResources.containsKey(queueName) &&
> minQueueResources.containsKey(queueName)
> && !Resources.fitsIn(minQueueResources.get(queueName),
> maxQueueResources.get(queueName))) {
> - LOG.warn(String.format("Queue %s has max resources %d less than min
> resources %d",
> + LOG.warn(String.format("Queue %s has max resources %s less than min
> resources %s",
>queueName, maxQueueResources.get(queueName),
> minQueueResources.get(queueName)));
> }
>}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[
https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805560#comment-13805560
]
Hadoop QA commented on YARN-1351:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12610355/fixprnt.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/2284//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2284//console
This message is automatically generated.
> Invalid string format in Fair Scheduler log warn message
>
>
> Key: YARN-1351
> URL: https://issues.apache.org/jira/browse/YARN-1351
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Konstantin Weitz
> Attachments: fixprnt.patch
>
>
> While trying to print a warning, two values of the wrong type (Resource
> instead of int) are passed into a String.format method call, leading to a
> runtime exception, in the file:
> _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_.
> The warning was intended to be printed whenever the resources don't fit into
> each other, either because the number of virtual cores or the memory is too
> small. I changed the %d's into %s, this way the warning will contain both the
> cores and the memory.
> Following the patch that fixes the issue:
> Index:
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> ===
> ---
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (revision 1535589)
> +++
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (working copy)
> @@ -471,7 +471,7 @@
> if (maxQueueResources.containsKey(queueName) &&
> minQueueResources.containsKey(queueName)
> && !Resources.fitsIn(minQueueResources.get(queueName),
> maxQueueResources.get(queueName))) {
> - LOG.warn(String.format("Queue %s has max resources %d less than min
> resources %d",
> + LOG.warn(String.format("Queue %s has max resources %s less than min
> resources %s",
>queueName, maxQueueResources.get(queueName),
> minQueueResources.get(queueName)));
> }
>}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[
https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805103#comment-13805103
]
Hadoop QA commented on YARN-1351:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12610284/patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2280//console
This message is automatically generated.
> Invalid string format in Fair Scheduler log warn message
>
>
> Key: YARN-1351
> URL: https://issues.apache.org/jira/browse/YARN-1351
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Konstantin Weitz
> Attachments: patch
>
>
> While trying to print a warning, two values of the wrong type (Resource
> instead of int) are passed into a String.format method call, leading to a
> runtime exception, in the file:
> _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_.
> The warning was intended to be printed whenever the resources don't fit into
> each other, either because the number of virtual cores or the memory is too
> small. I changed the %d's into %s, this way the warning will contain both the
> cores and the memory.
> Following the patch that fixes the issue:
> Index:
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> ===
> ---
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (revision 1535589)
> +++
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (working copy)
> @@ -471,7 +471,7 @@
> if (maxQueueResources.containsKey(queueName) &&
> minQueueResources.containsKey(queueName)
> && !Resources.fitsIn(minQueueResources.get(queueName),
> maxQueueResources.get(queueName))) {
> - LOG.warn(String.format("Queue %s has max resources %d less than min
> resources %d",
> + LOG.warn(String.format("Queue %s has max resources %s less than min
> resources %s",
>queueName, maxQueueResources.get(queueName),
> minQueueResources.get(queueName)));
> }
>}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (YARN-1351) Invalid string format in Fair Scheduler log warn message
[
https://issues.apache.org/jira/browse/YARN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804865#comment-13804865
]
Sandy Ryza commented on YARN-1351:
--
Thanks for finding and working on this [~konnew88]! Can you upload the patch
as an attachment and then hit "Submit Patch" so that jenkins will run on it?
> Invalid string format in Fair Scheduler log warn message
>
>
> Key: YARN-1351
> URL: https://issues.apache.org/jira/browse/YARN-1351
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Reporter: Konstantin Weitz
>
> While trying to print a warning, two values of the wrong type (Resource
> instead of int) are passed into a String.format method call, leading to a
> runtime exception, in the file:
> _trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java_.
> The warning was intended to be printed whenever the resources don't fit into
> each other, either because the number of virtual cores or the memory is too
> small. I changed the %d's into %s, this way the warning will contain both the
> cores and the memory.
> Following the patch that fixes the issue:
> Index:
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> ===
> ---
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (revision 1535589)
> +++
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueueManager.java
> (working copy)
> @@ -471,7 +471,7 @@
> if (maxQueueResources.containsKey(queueName) &&
> minQueueResources.containsKey(queueName)
> && !Resources.fitsIn(minQueueResources.get(queueName),
> maxQueueResources.get(queueName))) {
> - LOG.warn(String.format("Queue %s has max resources %d less than min
> resources %d",
> + LOG.warn(String.format("Queue %s has max resources %s less than min
> resources %s",
>queueName, maxQueueResources.get(queueName),
> minQueueResources.get(queueName)));
> }
>}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
