[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881888#comment-13881888 ] Hudson commented on YARN-1607: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1653 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1653/]) YARN-1607. TestRM relies on the scheduler assigning multiple containers in a single node update (Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560533) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRM.java > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.4.0 > > Attachments: YARN-1607-1.patch, YARN-1607-2.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881870#comment-13881870 ] Hudson commented on YARN-1607: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1678 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1678/]) YARN-1607. TestRM relies on the scheduler assigning multiple containers in a single node update (Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560533) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRM.java > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.4.0 > > Attachments: YARN-1607-1.patch, YARN-1607-2.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881843#comment-13881843 ] Hudson commented on YARN-1607: -- FAILURE: Integrated in Hadoop-Yarn-trunk #461 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/461/]) YARN-1607. TestRM relies on the scheduler assigning multiple containers in a single node update (Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560533) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRM.java > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.4.0 > > Attachments: YARN-1607-1.patch, YARN-1607-2.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879302#comment-13879302 ] Hudson commented on YARN-1607: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5035 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5035/]) YARN-1607. TestRM relies on the scheduler assigning multiple containers in a single node update (Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1560533) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRM.java > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.4.0 > > Attachments: YARN-1607-1.patch, YARN-1607-2.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879203#comment-13879203 ] Hadoop QA commented on YARN-1607: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624425/YARN-1607-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2928//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2928//console This message is automatically generated. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607-1.patch, YARN-1607-2.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879167#comment-13879167 ] Karthik Kambatla commented on YARN-1607: Thanks Sandy. LGTM. +1, pending Jenkins. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607-1.patch, YARN-1607-2.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877804#comment-13877804 ] Karthik Kambatla commented on YARN-1607: I do agree timeouts are the easiest way to go here, and the timeouts are high enough in the patch that it shouldn't cause problems on slow machines. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607-1.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877803#comment-13877803 ] Karthik Kambatla commented on YARN-1607: I don't know the reason why, but I was told (forget by whom) that using timeouts is discouraged. Might want to check that too. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607-1.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877801#comment-13877801 ] Karthik Kambatla commented on YARN-1607: Looks mostly good. One more nit: instead of using inconsistent literal values for sleep intervals, can we define a constant SLEEP_INTERVAL and use it through out. Thanks. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607-1.patch, YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877766#comment-13877766 ] Sandy Ryza commented on YARN-1607: -- For the timeouts, I think the cleanest would be to add timeouts to the tests. I think some of the sleep intervals could be lowered further. Will attach a patch that does these. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877643#comment-13877643 ] Karthik Kambatla commented on YARN-1607: Not introduced by this patch, but the while() loops without a timeout (waiting for the right number of containers or otherwise) is an easy way to wait forever especially in a test case. Can we have bounds on how long we can be in each of those loops? Further, would it make sense to lower the sleep intervals further? > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877320#comment-13877320 ] Hadoop QA commented on YARN-1607: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624090/YARN-1607.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/2919//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/2919//console This message is automatically generated. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1607) TestRM expects the capacity scheduler
[ https://issues.apache.org/jira/browse/YARN-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877304#comment-13877304 ] Sandy Ryza commented on YARN-1607: -- The attached patch makes the tests agnostic to the scheduler being used by not expecting multiple containers to come on a single heartbeat. > TestRM expects the capacity scheduler > - > > Key: YARN-1607 > URL: https://issues.apache.org/jira/browse/YARN-1607 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-1607.patch > > > We should either explicitly set the Capacity Scheduler or make it > scheduler-agnostic -- This message was sent by Atlassian JIRA (v6.1.5#6160)