[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940538#comment-13940538 ] Hudson commented on YARN-1690: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1731 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1731/]) YARN-1690. Made DistributedShell send timeline entities+events. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579123) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940497#comment-13940497 ] Hudson commented on YARN-1690: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1706 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1706/]) YARN-1690. Made DistributedShell send timeline entities+events. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579123) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940400#comment-13940400 ] Hudson commented on YARN-1690: -- FAILURE: Integrated in Hadoop-Yarn-trunk #514 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/514/]) YARN-1690. Made DistributedShell send timeline entities+events. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579123) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940133#comment-13940133 ] Hudson commented on YARN-1690: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5357 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5357/]) YARN-1690. Made DistributedShell send timeline entities+events. Contributed by Mayank Bansal. (zjshen: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579123) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDistributedShell.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940129#comment-13940129 ] Zhijie Shen commented on YARN-1690: --- Committed to trunk, branch-2, and branch-2.4. Thanks, Mayank! There's another related issue: we should be able to disable timeline service, and the timeline client doesn't post the entities+events, because the timeline sever may be not up. Let's do that in the scope of timeline client. I'll file a separate ticket for this issue. > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Fix For: 2.4.0 > > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939976#comment-13939976 ] Zhijie Shen commented on YARN-1690: --- +1. the patch looks good to me. I've run through the test locally repeatedly, which keep successful. I've also did some simple single node test, and the DS data has been successfully posted to the timeline server. Will commit it. > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[
https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939930#comment-13939930
]
Hadoop QA commented on YARN-1690:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635409/YARN-1690-7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3391//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3391//console
This message is automatically generated.
> Sending timeline entities+events from Distributed shell
>
>
> Key: YARN-1690
> URL: https://issues.apache.org/jira/browse/YARN-1690
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch,
> YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch, YARN-1690-7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[
https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939703#comment-13939703
]
Hadoop QA commented on YARN-1690:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635363/YARN-1690-6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3389//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3389//console
This message is automatically generated.
> Sending timeline entities+events from Distributed shell
>
>
> Key: YARN-1690
> URL: https://issues.apache.org/jira/browse/YARN-1690
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Mayank Bansal
>Assignee: Mayank Bansal
> Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch,
> YARN-1690-4.patch, YARN-1690-5.patch, YARN-1690-6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell
[ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939598#comment-13939598 ] Mayank Bansal commented on YARN-1690: - Thanks [~zjshen] for the review bq . 1. Call it DSEvent? Done bq. 2. Chang it to Timeline Client? Done bq.3. Typo on "CLient" Done bq. config is the member field of ApplicationMaster Done bq. 5. Please merge the following duplicate exception handling as well Done bq. 6. Again, please do not mention "AHS" here Done bq.7. Please change publishContainerStartEvent, publishContainerEndEvent, publishApplicationAttemptEvent to static, which don't need to be per instance. Done bq.8. Please apply for the following to all the added error logs. Done bq.9. Please don't limit the output to 1. According to the args for this DS job, it should be 1 DS_APP_ATTEMPT entities and 2 DS_CONTAINER entities, which has 2 events each? And assert the number of returned entities/events? Done > Sending timeline entities+events from Distributed shell > > > Key: YARN-1690 > URL: https://issues.apache.org/jira/browse/YARN-1690 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Mayank Bansal >Assignee: Mayank Bansal > Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, > YARN-1690-4.patch, YARN-1690-5.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
