[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919254#comment-13919254 ] Hudson commented on YARN-1748: -- FAILURE: Integrated in Hadoop-Yarn-trunk #499 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/499/]) YARN-1748. Excluded core-site.xml from hadoop-yarn-server-tests package's jar and thus avoid breaking downstream tests. Contributed by Sravya Tirukkovalur. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573795) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/pom.xml hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Sravya Tirukkovalur Priority: Blocker Fix For: 2.4.0 Attachments: YARN-1748-1.patch, YARN-1748-1.patch Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919289#comment-13919289 ] Hudson commented on YARN-1748: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1691 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1691/]) YARN-1748. Excluded core-site.xml from hadoop-yarn-server-tests package's jar and thus avoid breaking downstream tests. Contributed by Sravya Tirukkovalur. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573795) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/pom.xml hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Sravya Tirukkovalur Priority: Blocker Fix For: 2.4.0 Attachments: YARN-1748-1.patch, YARN-1748-1.patch Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919479#comment-13919479 ] Hudson commented on YARN-1748: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1716 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1716/]) YARN-1748. Excluded core-site.xml from hadoop-yarn-server-tests package's jar and thus avoid breaking downstream tests. Contributed by Sravya Tirukkovalur. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573795) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/pom.xml hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Sravya Tirukkovalur Priority: Blocker Fix For: 2.4.0 Attachments: YARN-1748-1.patch, YARN-1748-1.patch Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918702#comment-13918702 ] Sravya Tirukkovalur commented on YARN-1748: --- Great, thanks Vinod! hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Sravya Tirukkovalur Priority: Blocker Fix For: 2.4.0 Attachments: YARN-1748-1.patch, YARN-1748-1.patch Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918745#comment-13918745 ] Hudson commented on YARN-1748: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5257 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5257/]) YARN-1748. Excluded core-site.xml from hadoop-yarn-server-tests package's jar and thus avoid breaking downstream tests. Contributed by Sravya Tirukkovalur. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573795) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/pom.xml hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Sravya Tirukkovalur Priority: Blocker Fix For: 2.4.0 Attachments: YARN-1748-1.patch, YARN-1748-1.patch Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916385#comment-13916385 ] Karthik Kambatla commented on YARN-1748: Excluding core-site.xml while building test.jar seems to work, and should be compatible. Thanks [~sravya] for verifying this. [~vinodkv] - do you think this is reasonable? hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Vinod Kumar Vavilapalli Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916723#comment-13916723 ] Sravya Tirukkovalur commented on YARN-1748: --- Test failure on this run looks like unrelated to YARN-1628. And I believe as long as the core-site.xml is in the resources, tests shouldnt really require to have the test jar packaging it right, as the test itself wouldnt even use its own test jar? hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Vinod Kumar Vavilapalli Attachments: YARN-1748-1.patch Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[
https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916738#comment-13916738
]
Hadoop QA commented on YARN-1748:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631901/YARN-1748-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3222//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3222//console
This message is automatically generated.
hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
-
Key: YARN-1748
URL: https://issues.apache.org/jira/browse/YARN-1748
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Sravya Tirukkovalur
Assignee: Vinod Kumar Vavilapalli
Attachments: YARN-1748-1.patch, YARN-1748-1.patch
Jars should not package config files, as this might come into the classpaths
of clients causing the clients to break.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1748) hadoop-yarn-server-tests packages core-site.xml breaking downstream tests
[ https://issues.apache.org/jira/browse/YARN-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909530#comment-13909530 ] Sravya Tirukkovalur commented on YARN-1748: --- Thanks for having a look Vinod, yes I agree it would be better to pull in the mini cluster to src/java. Another thing we could do is to simply have an exclude clause, something like: https://issues.apache.org/jira/browse/MAPREDUCE-5554 hadoop-yarn-server-tests packages core-site.xml breaking downstream tests - Key: YARN-1748 URL: https://issues.apache.org/jira/browse/YARN-1748 Project: Hadoop YARN Issue Type: Bug Affects Versions: 2.3.0 Reporter: Sravya Tirukkovalur Assignee: Vinod Kumar Vavilapalli Jars should not package config files, as this might come into the classpaths of clients causing the clients to break. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
