[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919245#comment-13919245 ] Hudson commented on YARN-1765: -- FAILURE: Integrated in Hadoop-Yarn-trunk #499 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/499/]) YARN-1765. Added test cases to verify that killApplication API works across ResourceManager failover. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573735) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Fix For: 2.4.0 Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch, YARN-1765.3.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919280#comment-13919280 ] Hudson commented on YARN-1765: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1691 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1691/]) YARN-1765. Added test cases to verify that killApplication API works across ResourceManager failover. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573735) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Fix For: 2.4.0 Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch, YARN-1765.3.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919470#comment-13919470 ] Hudson commented on YARN-1765: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1716 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1716/]) YARN-1765. Added test cases to verify that killApplication API works across ResourceManager failover. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573735) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Fix For: 2.4.0 Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch, YARN-1765.3.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918545#comment-13918545 ] Vinod Kumar Vavilapalli commented on YARN-1765: --- Looks good. +1. Checking this in. Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch, YARN-1765.3.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918557#comment-13918557 ] Hudson commented on YARN-1765: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5255 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5255/]) YARN-1765. Added test cases to verify that killApplication API works across ResourceManager failover. Contributed by Xuan Gong. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1573735) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Fix For: 2.4.0 Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch, YARN-1765.3.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917295#comment-13917295 ] Xuan Gong commented on YARN-1765: - bq. failOverAndKillAppWithoutAttempt - failOverAndKillApp. Let's just distinguish the methods by the number of args DONE bq. Reuse common code between failOverAndKillApp and failOverAndKillAppWithoutAttempt DONE bq. In both the methods, rename rmAppState to initialRMAppState, rmAppAttemptState to initialRMAppAttemptState, expectedAppState to expectedAppStateBeforeKillApp DONE bq. Reorder arguments of failOverAndKillApp to be initialRMAppState, initialRMAppAttemptState followed by expectedAppStateBeforeKillApp DONE bq. Reuse common code between startRMs, startRMsWithCustomizedRMAppManager and startRMsWithCustomizedClientRMService. DONE bq. In testKillAppWhenFailOverHappensDuringApplicationKill, can you ensure that the app is in running state before the first kill? DONE Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[
https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917303#comment-13917303
]
Hadoop QA commented on YARN-1765:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631993/YARN-1765.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3226//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3226//console
This message is automatically generated.
Write test cases to verify that killApplication API works in RM HA
--
Key: YARN-1765
URL: https://issues.apache.org/jira/browse/YARN-1765
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Xuan Gong
Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch,
YARN-1765.3.patch
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914223#comment-13914223 ] Xuan Gong commented on YARN-1765: - bq. No need for RMAppManager.getRMContext(). The context is already available in the constructor, just cache it. done bq. MockRM changes are completely unnecessary, the API you want already exists fixed bq. Move the test to a failover package? We should move all tests related to HA/fail-over to a new package. It's getting increasingly crowded in the base package. Can we do this at separate ticket ? It may need some time to figure out the proper directory to have all HA/fail-over tests bq. Document all the tests in the test-file and add timeouts. done bq. Doesn't like all the tests have the right names. Fix them to be more apt. done bq. In failOver* methods, assert the expected app and app-attempt state before killing the app. Also assert app-state immediately after fail-over succeeds. done bq. Validate the response from killApp() method in all tests. Specifically validate KillApplicationResponse.getIsKillCompleted(). done bq. There is one other important test that we need to write as follow added Write test cases to verify that killApplication API works in RM HA -- Key: YARN-1765 URL: https://issues.apache.org/jira/browse/YARN-1765 Project: Hadoop YARN Issue Type: Sub-task Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-1765.1.patch, YARN-1765.2.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[
https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914332#comment-13914332
]
Hadoop QA commented on YARN-1765:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631483/YARN-1765.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3204//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3204//console
This message is automatically generated.
Write test cases to verify that killApplication API works in RM HA
--
Key: YARN-1765
URL: https://issues.apache.org/jira/browse/YARN-1765
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Xuan Gong
Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (YARN-1765) Write test cases to verify that killApplication API works in RM HA
[
https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912590#comment-13912590
]
Hadoop QA commented on YARN-1765:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631158/YARN-1765.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3188//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3188//console
This message is automatically generated.
Write test cases to verify that killApplication API works in RM HA
--
Key: YARN-1765
URL: https://issues.apache.org/jira/browse/YARN-1765
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Xuan Gong
Assignee: Xuan Gong
Attachments: YARN-1765.1.patch
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
