[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974148#comment-13974148
]
Hudson commented on YARN-1870:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1761 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1761/])
YARN-1870. FileInputStream is not closed in
ProcfsBasedProcessTree#constructProcessSMAPInfo. (Fengdong Yu via junping_du)
(junping_du:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1588324)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Fix For: 2.5.0
>
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974074#comment-13974074
]
Hudson commented on YARN-1870:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1736 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1736/])
YARN-1870. FileInputStream is not closed in
ProcfsBasedProcessTree#constructProcessSMAPInfo. (Fengdong Yu via junping_du)
(junping_du:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1588324)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Fix For: 2.5.0
>
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973977#comment-13973977
]
Hudson commented on YARN-1870:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #544 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/544/])
YARN-1870. FileInputStream is not closed in
ProcfsBasedProcessTree#constructProcessSMAPInfo. (Fengdong Yu via junping_du)
(junping_du:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1588324)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Fix For: 2.5.0
>
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973229#comment-13973229
]
Hudson commented on YARN-1870:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5532 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5532/])
YARN-1870. FileInputStream is not closed in
ProcfsBasedProcessTree#constructProcessSMAPInfo. (Fengdong Yu via junping_du)
(junping_du:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1588324)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Fix For: 2.5.0
>
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973219#comment-13973219
]
Junping Du commented on YARN-1870:
--
I just commit this patch to trunk and branch2. Thanks Fengdong for the patch
and Ted for review!
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Fix For: 2.5.0
>
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973161#comment-13973161
]
Junping Du commented on YARN-1870:
--
+1. Thanks Fengdong for the patch! Will commit it shortly.
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Fix For: 2.4.1
>
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968030#comment-13968030
]
Fengdong Yu commented on YARN-1870:
---
who can commit this? Thanks.
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947515#comment-13947515
]
Fengdong Yu commented on YARN-1870:
---
[~vinodkv], can you add me as YARN contributor? I am HDFS contributor now, so
I don't think we also need send mail to the secretary.
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946032#comment-13946032
]
Hadoop QA commented on YARN-1870:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636489/YARN-1870.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3450//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3450//console
This message is automatically generated.
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946012#comment-13946012
]
Fengdong Yu commented on YARN-1870:
---
[~yuzhih...@gmail.com], can you add me as YARN contributor?
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945991#comment-13945991
]
Ted Yu commented on YARN-1870:
--
lgtm
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: YARN-1870.patch
>
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-1870) FileInputStream is not closed in ProcfsBasedProcessTree#constructProcessSMAPInfo()
[
https://issues.apache.org/jira/browse/YARN-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945968#comment-13945968
]
Fengdong Yu commented on YARN-1870:
---
Good catch [~yuzhih...@gmail.com], I've upload a simple patch to cover it.
> FileInputStream is not closed in
> ProcfsBasedProcessTree#constructProcessSMAPInfo()
> --
>
> Key: YARN-1870
> URL: https://issues.apache.org/jira/browse/YARN-1870
> Project: Hadoop YARN
> Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>
> {code}
> List lines = IOUtils.readLines(new FileInputStream(file));
> {code}
> FileInputStream is not closed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
