[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018858#comment-14018858 ] Hudson commented on YARN-2061: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1792 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1792/]) YARN-2061. Revisit logging levels in ZKRMStateStore. (Ray Chiang via kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1600498) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018798#comment-14018798 ] Hudson commented on YARN-2061: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1765 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1765/]) YARN-2061. Revisit logging levels in ZKRMStateStore. (Ray Chiang via kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1600498) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018682#comment-14018682 ] Hudson commented on YARN-2061: -- FAILURE: Integrated in Hadoop-Yarn-trunk #574 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/574/]) YARN-2061. Revisit logging levels in ZKRMStateStore. (Ray Chiang via kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1600498) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018308#comment-14018308 ] Hudson commented on YARN-2061: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5650 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5650/]) YARN-2061. Revisit logging levels in ZKRMStateStore. (Ray Chiang via kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1600498) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018228#comment-14018228 ] Karthik Kambatla commented on YARN-2061: My bad. Just realized we haven't run Jenkins on this patch. I ran ZKRMStateStore tests before committing. I ll keep an eye out for anything else that this could cause, and fix it up. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018226#comment-14018226 ] Karthik Kambatla commented on YARN-2061: Just committed to trunk and branch-2. Thanks Ray. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Fix For: 2.5.0 > > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018110#comment-14018110 ] Karthik Kambatla commented on YARN-2061: +1. Committing this. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999118#comment-13999118 ] Jian He commented on YARN-2061: --- bq. put info level in unusual condition I meant error level or something if it's an error condition. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000565#comment-14000565 ] Ray Chiang commented on YARN-2061: -- Hi Jian. Thanks for the summary of the various log levels. Your explanation is quite clear--I'll keep that in mind for similar modifications in the future. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999111#comment-13999111 ] Jian He commented on YARN-2061: --- Hi Ray, thanks for cleaning it up. I think a reasonable way is to put info level in unusual condition which helps debugging in most cases, and debug level in usual condition which avoids excessive loggings. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998911#comment-13998911 ] Ray Chiang commented on YARN-2061: -- One other observation. For the various LOG.info() statements in a catch block, should those be LOG.error() or does it make sense for those to stay LOG.info()? > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > Attachments: YARN2061-01.patch > > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998624#comment-13998624 ] Tsuyoshi OZAWA commented on YARN-2061: -- s/RACE/TRACE/ > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[
https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998623#comment-13998623
]
Tsuyoshi OZAWA commented on YARN-2061:
--
The logging in
removeRMDelegationTokenState()/updateRMDelegationTokenAndSequenceNumberInternal()/removeRMDTMasterKeyState()
can be for RACE and DEBUG levels.
{code}
LOG.info("Done Loading applications from ZK state store");
{code}
About this log, how about moving this to the tail of loadRMAppState()?
> Revisit logging levels in ZKRMStateStore
> -
>
> Key: YARN-2061
> URL: https://issues.apache.org/jira/browse/YARN-2061
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Karthik Kambatla
>Assignee: Ray Chiang
>Priority: Minor
> Labels: newbie
>
> ZKRMStateStore has a few places where it is logging at the INFO level. We
> should change these to DEBUG or TRACE level messages.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998524#comment-13998524 ] Karthik Kambatla commented on YARN-2061: We assume that the Log level is at least INFO, so we add *Enabled only for TRACE and DEBUG levels. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998254#comment-13998254 ] Karthik Kambatla commented on YARN-2061: I guess that is the only major case. Others are mostly justified and some of them are conditional too. > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[ https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998322#comment-13998322 ] Ray Chiang commented on YARN-2061: -- One minor question. Looking at the Apache Commons Log Interface, it looks like the API expects the developer to always call is*Enabled() API before calling the actual Log.* function, but that's not used consistently in this class. Should I add that as well? > Revisit logging levels in ZKRMStateStore > - > > Key: YARN-2061 > URL: https://issues.apache.org/jira/browse/YARN-2061 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager >Affects Versions: 2.4.0 >Reporter: Karthik Kambatla >Assignee: Ray Chiang >Priority: Minor > Labels: newbie > > ZKRMStateStore has a few places where it is logging at the INFO level. We > should change these to DEBUG or TRACE level messages. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2061) Revisit logging levels in ZKRMStateStore
[
https://issues.apache.org/jira/browse/YARN-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998251#comment-13998251
]
Karthik Kambatla commented on YARN-2061:
# After loading state corresponding to one application.
{code}
LOG.info("Done Loading applications from ZK state store");
{code}
> Revisit logging levels in ZKRMStateStore
> -
>
> Key: YARN-2061
> URL: https://issues.apache.org/jira/browse/YARN-2061
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
>Affects Versions: 2.4.0
>Reporter: Karthik Kambatla
>Assignee: Ray Chiang
>Priority: Minor
> Labels: newbie
>
> ZKRMStateStore has a few places where it is logging at the INFO level. We
> should change these to DEBUG or TRACE level messages.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
