[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166671#comment-14166671
]
Hudson commented on YARN-2493:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #707 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/707/])
YARN-2493. Added user-APIs for using node-labels. Contributed by Wangda Tan.
(vinodkv: rev 180afa2f86f9854c536c3d4ff7476880e41ac48d)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
* hadoop-yarn-project/CHANGES.txt
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Fix For: 2.6.0
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166953#comment-14166953
]
Hudson commented on YARN-2493:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1922 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1922/])
YARN-2493. Added user-APIs for using node-labels. Contributed by Wangda Tan.
(vinodkv: rev 180afa2f86f9854c536c3d4ff7476880e41ac48d)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Fix For: 2.6.0
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165482#comment-14165482
]
Vinod Kumar Vavilapalli commented on YARN-2493:
---
+1, looks good. Checking this in.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165491#comment-14165491
]
Wangda Tan commented on YARN-2493:
--
Thanks [~vinodkv] for review and commit!
Wangda
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Fix For: 2.6.0
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165492#comment-14165492
]
Hudson commented on YARN-2493:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6223 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6223/])
YARN-2493. Added user-APIs for using node-labels. Contributed by Wangda Tan.
(vinodkv: rev 180afa2f86f9854c536c3d4ff7476880e41ac48d)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceRequestPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ApplicationSubmissionContextPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceRequest.java
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Fix For: 2.6.0
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164172#comment-14164172
]
Vinod Kumar Vavilapalli commented on YARN-2493:
---
The latest patch looks good to me, can you debug the warnings from Jenkins?
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164258#comment-14164258
]
Hadoop QA commented on YARN-2493:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673714/YARN-2493-20141008.1.patch
against trunk revision 2217e2f.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5334//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5334//console
This message is automatically generated.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164272#comment-14164272
]
Wangda Tan commented on YARN-2493:
--
bq. -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.
I think the eclipse:eclipse failure is not caused by this patch, I can get
eclipse:eclipse passed in my local environment.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493-20141008.1.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159747#comment-14159747
]
Hadoop QA commented on YARN-2493:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12673034/YARN-2493.patch
against trunk revision 16333b4.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1290 javac
compiler warnings (more than the trunk's current 1269 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5270//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/5270//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5270//console
This message is automatically generated.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch, YARN-2493.patch,
YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151528#comment-14151528
]
Hadoop QA commented on YARN-2493:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12671760/YARN-2493.patch
against trunk revision b38e52b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1281 javac
compiler warnings (more than the trunk's current 1265 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5169//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/5169//artifact/PreCommit-HADOOP-Build-patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5169//console
This message is automatically generated.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch, YARN-2493.patch,
YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151280#comment-14151280
]
Vinod Kumar Vavilapalli commented on YARN-2493:
---
More comments:
h4. ApplicationSubmissionContext
- Call get|setAppLabelExpression() as simply (get|set)NodeLabelExpression?
'App' is already captured in the class-name.
- Similarly ApplicationSubmissionContextProto.app_label_expression -
node_label_expression
- Javadoc of {get|set}AppLabelExpression() should include what it really
means: Say Get Node-label expression for this app. If this is set, all
containers of this application will get allocated resources on only those nodes
that satisfy this node-label-expression.
- In the new constructor that you added, the priority is the AM-container
priority while the existing constructor assumes it to be application priority.
Let's definitely keep application-priority in all the APIs old and new.
bq. We will be supporting app-priorities via YARN-1963, let's not deprecate
these APIs for now.
Missed this in javadoc of getPriority()? Also setPriority(Priority priority)
was private, you made it public now.
h4. ResourceRequest
- Call ResourceRequest.get|setLabelExpression() as
(get|set)NodeLabelExpression?
- Similarly ResourceRequestProto.label_expression - node_label_expression
- bq. Let's mark the new APIs evolving
Missed this for this record?
- Similar to submission context, let's put this in the javadoc: Get Node
Label expression for this Resource Request. If this is set, all containers
allocated to satisfy this resource-request will be only on those nodes that
satisfy this node-label-expression
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147327#comment-14147327
]
Wangda Tan commented on YARN-2493:
--
Hi [~vinodkv],
Sorry I missed this comment, I think all suggestions make sense to me, will
modify and upload a patch soon.
Thanks,
Wangda
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125121#comment-14125121
]
Yuliya Feldman commented on YARN-2493:
--
to [~wangda]
I did not quite understand what is the purpose of
{code} ResourceRequest getAMContainerResourceRequest {code}
I can see in the above comment you are talking about the difference in ability
to specify number of containers in regular request unlike in AMRequest, so is
this new method to consolidate Priority, Resource into
AMContainerResourceRequest?
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125128#comment-14125128
]
Wangda Tan commented on YARN-2493:
--
Hi [~yufeldman],
Thanks for reviewing this, the purpose of add an AMContainerResourceRequest is
exactly as you said: Currently we have Priority, Resource, we're adding
labelExpression, in the future we will add resourceName and relaxLocality --
that is pretty much ResourceRequest, except numContainers, we don't need
duplicate them in ApplicationSubmissionContext.
Does this make sense to you?
Wangda
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125132#comment-14125132
]
Yuliya Feldman commented on YARN-2493:
--
[~wangda],
In this case why do you even bother adding labelExpression to
ApplicationSubmissionContext if you plan to have it as part of
AMResourceRequest, unless you want to keep it in both places for some reason?
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125133#comment-14125133
]
Wangda Tan commented on YARN-2493:
--
[~yufeldman],
The labelExpression added to ApplicationSubmissionContext is used to app-level
label expression, which will automatically set labelExpression for all
ResourceRequest (User can overwrite this by setting labelExpression in
individual ResourceRequest.
And the labelExpression of AMResourceRequest is only to set labelExpression on
AM container.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125135#comment-14125135
]
Yuliya Feldman commented on YARN-2493:
--
[~leftnoteasy]]
OK, so what is the logic going to be:
1. If label is specified in ApplicationSubmisisonContext and AMResourceRequest
the one from former will be set for all the ResourceRequests except
AMResourceRequest (and can be overwritten later on), is it true?
2. If label is specified in ApplicationSubmisisonContext and not in
AMResourceRequest it will be set for all resource requests including
AMResourceRequest, is it true?
3. If label is not specified in ApplicationSubmisisonContext and specified in
AMResourceRequest - then what - same as #2?
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125139#comment-14125139
]
Wangda Tan commented on YARN-2493:
--
1/2 are true,
For 3, only AM container will be set the labelExpression.
Do you think is this easy/straightforward to use in your perspective? Do you
have any suggestions?
Thanks,
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125146#comment-14125146
]
Yuliya Feldman commented on YARN-2493:
--
[~leftnoteasy]
I suspect that #2 will be the most common, since either somebody will set label
for whole application, or will set label for non-AM container resource requests
programmatically (kind of #3). I think I saw in the comments: ability to set it
separately for mappers and reducers.
In my personal opinion it is better to at least restrict input parameters to
one (not two), otherwise we would need to take care of 4 combinations instead
of just 1.
In any case I am fine with the changes.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125163#comment-14125163
]
Wangda Tan commented on YARN-2493:
--
[~yufeldman],
Thanks for the suggestion,
I agree with you that adding am/app labelExpression separately is harder for
user to set (4 combinations instead of one). But the downside is we treat AM
container separately (we cannot only set label for AM container request).
Assume a user want to set label of AM = x, label of non-AM = , he will set
label expression of app=x, and label expression of all other
ResourceRequests=. It's not very convenient for user if he wants to set label
expression of AM container different from non-AM containers.
I'm fine with your suggestions if most use cases don't need set label
expression of AM container different from non-AM containers. Let's wait more
suggestions from community.
Thanks,
Wangda
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119738#comment-14119738
]
Hadoop QA commented on YARN-2493:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12666201/YARN-2493.patch
against trunk revision 08a9ac7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1296 javac
compiler warnings (more than the trunk's current 1265 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
See
https://builds.apache.org/job/PreCommit-YARN-Build/4811//artifact/trunk/patchprocess/diffJavadocWarnings.txt
for details.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4811//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/4811//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4811//console
This message is automatically generated.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2493) [YARN-796] API changes for users
[
https://issues.apache.org/jira/browse/YARN-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119927#comment-14119927
]
Hadoop QA commented on YARN-2493:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12666233/YARN-2493.patch
against trunk revision 3425ae5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1296 javac
compiler warnings (more than the trunk's current 1265 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4812//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/4812//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4812//console
This message is automatically generated.
[YARN-796] API changes for users
Key: YARN-2493
URL: https://issues.apache.org/jira/browse/YARN-2493
Project: Hadoop YARN
Issue Type: Sub-task
Components: api
Reporter: Wangda Tan
Assignee: Wangda Tan
Attachments: YARN-2493.patch, YARN-2493.patch
This JIRA includes API changes for users of YARN-796, like changes in
{{ResourceRequest}}, {{ApplicationSubmissionContext}}, etc. This is a common
part of YARN-796.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
