[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125420#comment-14125420 ] Hudson commented on YARN-2512: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #674 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/674/]) YARN-2512. Allowed pattern matching for origins in CrossOriginFilter. Contributed by Jonathan Eagles. (zjshen: rev a092cdf32de4d752456286a9f4dda533d8a62bca) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java * hadoop-yarn-project/CHANGES.txt Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Fix For: 2.6.0 Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125511#comment-14125511 ] Hudson commented on YARN-2512: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1865 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1865/]) YARN-2512. Allowed pattern matching for origins in CrossOriginFilter. Contributed by Jonathan Eagles. (zjshen: rev a092cdf32de4d752456286a9f4dda533d8a62bca) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Fix For: 2.6.0 Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125886#comment-14125886 ] Hudson commented on YARN-2512: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1890 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1890/]) YARN-2512. Allowed pattern matching for origins in CrossOriginFilter. Contributed by Jonathan Eagles. (zjshen: rev a092cdf32de4d752456286a9f4dda533d8a62bca) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestCrossOriginFilter.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/CrossOriginFilter.java Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Fix For: 2.6.0 Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125113#comment-14125113 ] Zhijie Shen commented on YARN-2512: --- bq. I think there could be some confusion since URLs have a different RFC than hostnames and domains. My bad, I think you're right about the host name rule. bq. I'm slowly bringing hadoop up to feature parity with jetty so that users will have a full feature set and make the transition to jetty seamless when we move to jetty 7+. Sounds a good plan. +1, I'll commit the patch. Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124719#comment-14124719 ] Zhijie Shen commented on YARN-2512: --- [~jeagles], I'm not sure it's safe to support wildcard in URL matching, because * seems to be a valid char for an URL. See [RFC 1738|http://www.ietf.org/rfc/rfc1738.txt]. Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124735#comment-14124735 ] Jonathan Eagles commented on YARN-2512: --- [~zjshen], thank you for your continued patience with me. I think there could be some confusion since URLs have a different RFC than hostnames and domains. http://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names Just for further clarification of my purposes, I'm slowly bringing hadoop up to feature parity with jetty so that users will have a full feature set and make the transition to jetty seamless when we move to jetty 7+. Jetty quite thoughtfully documents the cross origin filter wildcard feature this jira is aiming to add. http://download.eclipse.org/jetty/stable-7/apidocs/org/eclipse/jetty/servlets/CrossOriginFilter.html Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[ https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124248#comment-14124248 ] Jonathan Eagles commented on YARN-2512: --- [~zjshen], can you please review this cross-origin change for use with the timeline server? Allow for origin pattern matching in cross origin filter Key: YARN-2512 URL: https://issues.apache.org/jira/browse/YARN-2512 Project: Hadoop YARN Issue Type: Sub-task Components: timelineserver Reporter: Jonathan Eagles Assignee: Jonathan Eagles Attachments: YARN-2512-v1.patch Extending the feature set of allowed origins. Now a * in a pattern indicates this allowed origin is a pattern and will be matched including multiple sub-domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2512) Allow for origin pattern matching in cross origin filter
[
https://issues.apache.org/jira/browse/YARN-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124271#comment-14124271
]
Hadoop QA commented on YARN-2512:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12666971/YARN-2512-v1.patch
against trunk revision e6420fe.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/4837//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4837//console
This message is automatically generated.
Allow for origin pattern matching in cross origin filter
Key: YARN-2512
URL: https://issues.apache.org/jira/browse/YARN-2512
Project: Hadoop YARN
Issue Type: Sub-task
Components: timelineserver
Reporter: Jonathan Eagles
Assignee: Jonathan Eagles
Attachments: YARN-2512-v1.patch
Extending the feature set of allowed origins. Now a * in a pattern
indicates this allowed origin is a pattern and will be matched including
multiple sub-domains.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
