[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258189#comment-14258189 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #51 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/51/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258196#comment-14258196 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-Yarn-trunk #785 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/785/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258276#comment-14258276 ] Hudson commented on YARN-2937: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1983 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1983/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258291#comment-14258291 ] Hudson commented on YARN-2937: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #48 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/48/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258320#comment-14258320 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #52 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/52/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258337#comment-14258337 ] Hudson commented on YARN-2937: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2002 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2002/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256994#comment-14256994 ] Varun Saxena commented on YARN-2937: [~zjshen], above piece of code is in finally block. I think we should not throw an exception in finally block. Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256993#comment-14256993 ] Varun Saxena commented on YARN-2937: [~zjshen], above piece of code is in finally block. I think we should not throw an exception in finally block. Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257081#comment-14257081
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688857/YARN-2937.005.patch
against trunk revision 5caebba.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6175//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6175//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257098#comment-14257098
]
Varun Saxena commented on YARN-2937:
[~zjshen], kindly review. Have rebased the patch.
Havent thrown Exception in code below though, as it is in finally block.
{code}
+if(pw.checkError()) {
+ LOG.warn(Error while closing cgroup file + path);
{code}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257302#comment-14257302
]
Zhijie Shen commented on YARN-2937:
---
bq. Havent thrown Exception in code below though, as it is in finally block.
I mean we SHOULD throw the exception. Before the patch, all I/O errors here
will results in exceptions. After the patch, PrintWriter hardly throws the
exceptions, but set error flag. It means that some possible I/O error which
were supposed to be thrown before is now just be recorded as WARN log.
Therefore, instead of
{code}
+if(pw.checkError()) {
+ LOG.warn(Error while closing cgroup file + path);
{code}
Shall we do the following?
{code}
+if(pw.checkError()) {
+ throw new IOException(Error while closing cgroup file + path);
{code}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257361#comment-14257361
]
Varun Saxena commented on YARN-2937:
[~zjshen], yes I had got your point. What I meant was that this code is
essentially like under :
{code}
PrintWriter pw = null;
try {
File file = new File(path + / + param);
Writer w = new OutputStreamWriter(new FileOutputStream(file), UTF-8);
pw = new PrintWriter(w);
pw.write(value);
} catch (IOException e) {
throw new IOException(Unable to set + param + = + value +
for cgroup at: + path, e);
} finally {
if (pw != null) {
pw.close();
if(pw.checkError()) {
LOG.warn(Error while closing cgroup file + path);
}
}
}
{code}
As you can see {{pw.close()}} is in finally block. If we throw an exception
from finally block, it may mask original IOException(if thrown from code
preceding finally block. AFAIK, this is not a good practice. Correct me if I am
wrong.
Even before this patch, code was like below. Here we catch the exception in
finally block and print a WARN log. The reason I checked for
{{PrintWriter#checkError}} and printed a WARN log was to keep the behavior
consistent with earlier code.
{code}
try {
f = new FileWriter(path + / + param, false);
f.write(value);
} catch (IOException e) {
throw new IOException(Unable to set + param + = + value +
for cgroup at: + path, e);
} finally {
if (f != null) {
try {
f.close();
} catch (IOException e) {
LOG.warn(Unable to close cgroup file: +
path, e);
}
}
}
{code}
Let me know your opinion.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257371#comment-14257371
]
Varun Saxena commented on YARN-2937:
[~zjshen], however you are correct that as {{PrintWriter}} doesnt throw
exception, we should probably check for error after call to {{pw.write()}}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257404#comment-14257404
]
Varun Saxena commented on YARN-2937:
[~zjshen], I think it can be changed as under. Because, as you said PrintWriter
doesnt throw exceptions. So, we should check for error after call to
{{PrintWriter#write}}. Let me know if you would want me to throw IOException
from finally block too. After that I will upload a new patch.
{code}
PrintWriter pw = null;
try {
File file = new File(path + / + param);
Writer w = new OutputStreamWriter(new FileOutputStream(file), UTF-8);
pw = new PrintWriter(w);
pw.write(value);
if(pw.checkError()) {
throw new IOException();
}
} catch (IOException e) {
throw new IOException(Unable to set + param + = + value +
for cgroup at: + path, e);
} finally {
if (pw != null) {
pw.close();
if(pw.checkError()) {
LOG.warn(Error while closing cgroup file + path);
}
}
}
{code}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257414#comment-14257414 ] Zhijie Shen commented on YARN-2937: --- IMHO, we can simply throw it at finally block. It's not necessary to throw IOException and then wrap it in another IOException. Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257427#comment-14257427
]
Varun Saxena commented on YARN-2937:
bq. IMHO, we can simply throw it at finally block. It's not necessary to throw
IOException and then wrap it in another IOException.
[~zjshen], thats true but the issue with that is what should be the exception
message. If there is exception in write() we should probably send back an
exception to the caller stating unable to set cgroup. If closing of
printwriter fails, it may not mean that cgroup hasnt been set.
{{throw new IOException(Unable to set + param + = + value +
for cgroup at: + path, e);}}
I feel code can be changed as under then. Pls note that we did not throw an
exception on close of FileWriter earlier.
} finally {
if (pw != null) {
boolean hasError = pw.checkError();
pw.close();
if(hasError) {
throw new IOException(Unable to set + param + = + value +
for cgroup at: + path);
}
if(pw.checkError()) {
throw new IOException(Error while closing cgroup file + path);
}
}
}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257430#comment-14257430
]
Varun Saxena commented on YARN-2937:
{code}
} finally {
if (pw != null) {
boolean hasError = pw.checkError();
pw.close();
if(hasError) {
throw new IOException(Unable to set + param + = + value + for cgroup
at: + path);
}
if(pw.checkError()) {
throw new IOException(Error while closing cgroup file + path); }
}
}
{code}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257525#comment-14257525
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688912/YARN-2937.006.patch
against trunk revision 5caebba.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6177//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6177//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch,
YARN-2937.006.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257848#comment-14257848 ] Zhijie Shen commented on YARN-2937: --- +1 for the last patch. Will commit it. Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257898#comment-14257898
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688972/YARN-2937.007.patch
against trunk revision ca3381d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6185//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6185//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch,
YARN-2937.006.patch, YARN-2937.007.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257954#comment-14257954 ] Hudson commented on YARN-2937: -- FAILURE: Integrated in Hadoop-trunk-Commit #6786 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6786/]) YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena. (zjshen: rev 41a548a916d4248164cb9495320f123ec215d70e) * hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/WindowsSecureContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/CgroupsLCEResourcesHandler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/ProcessIdFileReader.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsPage.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DockerContainerExecutor.java * hadoop-yarn-project/CHANGES.txt Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258022#comment-14258022 ] Varun Saxena commented on YARN-2937: Thanks [~zjshen] for the rebase, review and commit. Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch, YARN-2937.005.patch, YARN-2937.006.patch, YARN-2937.007.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256229#comment-14256229
]
Zhijie Shen commented on YARN-2937:
---
[~varun_saxena], thanks for your explanation, which makes sense to me. Again,
this patch doesn't apply too. Please kindly update it. And there's one
additional comment.
The
[document|http://docs.oracle.com/javase/7/docs/api/java/io/PrintWriter.html]
says {{Methods in this class never throw I/O exceptions, although some of its
constructors may. The client may inquire as to whether any errors have occurred
by invoking checkError().}} Previously if I/O error occurs, we will always
throw exception. Now some errors will be just recorded as WARN logs. IMHO, we
should throw IOException here.
{code}
+if(pw.checkError()) {
+ LOG.warn(Error while closing cgroup file + path);
{code}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: YARN-2937.001.patch, YARN-2937.002.patch,
YARN-2937.003.patch, YARN-2937.004.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246123#comment-14246123
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12687134/YARN-2937.004.patch
against trunk revision 25a0440.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6111//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6111//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch, YARN-2937.001.patch,
YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246124#comment-14246124 ] Varun Saxena commented on YARN-2937: [~zjshen], addressed your comments in a new patch. Kindly review Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: HADOOP-11373.patch, YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch, YARN-2937.004.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245801#comment-14245801 ] Varun Saxena commented on YARN-2937: bq. And yes, BufferedReader will close the underlying FileReader and FileReader will close the underlying stream. I meant BufferedReader will close the underlying InputStreamReader and InputStreamReader will close the underlying stream. Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: HADOOP-11373.patch, YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244628#comment-14244628
]
Zhijie Shen commented on YARN-2937:
---
1. What's the problem around Random?
{code}
-Random r = new Random();
-long randomPosition = Math.abs(r.nextLong()) % totalAvailable;
+long randomPosition = Math.abs(RandomUtils.nextLong()) % totalAvailable;
{code}
2. Can we use IOUtils?
{code}
- // Close the streams
- try {
-in.close();
- } catch (IOException e2) {
-LOG.warn(Error closing the stream: + getMtabFileName(), e2);
+ if(in != null) {
+// Close the streams
+try {
+ in.close();
+} catch (IOException e2) {
+ LOG.warn(Error closing the stream: + getMtabFileName(), e2);
+}
{code}
3. Is this removed because bufReader will consequently close fileReader too?
{code}
- if (fileReader != null) {
-fileReader.close();
- }
{code}
4. Again, would you mind explaining a bit about what have been excluded in
findbugs-exclude.xml? Thanks!
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch, YARN-2937.001.patch,
YARN-2937.002.patch, YARN-2937.003.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245160#comment-14245160
]
Varun Saxena commented on YARN-2937:
[~zjshen],
bq. What's the problem around Random?
There is a problem with Maths#abs.
{{Maths.abs(Long.MIN_VALUE)==Long.MIN_VALUE}} i.e. Maths.abs doesnt work with
lowest value of long. But Random may return that value. So changed Random to
RandomUtils to give only positive values. Maths.abs can probably be removed in
this case. Random has {{getInt}} method which can return positive values but no
corresponding method for nextLong
bq. Can we use IOUtils?
Yes, will use it.
bq. Is this removed because bufReader will consequently close fileReader too?
No. This has been removed because instance of class {{FileReader}} has been
removed and replaced with {{FileInputStream}} + {{InputStreamReader}}. This is
because FileReader doesnt allow us to set Charset encoding. And yes,
BufferedReader will close the underlying FileReader and FileReader will close
the underlying stream.
bq. Again, would you mind explaining a bit about what have been excluded in
findbugs-exclude.xml?
The exclusions are corresponding to *RV_RETURN_VALUE_IGNORED_BAD_PRACTICE*.
Findbugs was complaining about return value of {{ThreadPoolExecutor#submit}}
being ignored. This method returns a {{FutureT}} object. Generally
{{Future#get}} is called to check the return value of executor. But this method
is blocking and waits for thread execution to complete. If I call this, it
would break the current behavior. Tried it as well and some test cases failed.
Another alternative is to call {{Future#isDone}} but this most likely will
always return false if you check it immediately. So I see no point in checking
return value of call to submit. Hence, added it in exclusions. Findbugs was
raising issue for below 2 lines.
{code:title=ContainersLauncher.java:118|borderStyle=solid}
containerLauncher.submit(launch);
{code}
{code:title=SharedCacheUploadService.java:118|borderStyle=solid}
uploaderPool.submit(uploader);
{code}
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch, YARN-2937.001.patch,
YARN-2937.002.patch, YARN-2937.003.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243187#comment-14243187
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686671/YARN-2937.002.patch
against trunk revision b9f6d0c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6090//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6090//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch, YARN-2937.001.patch,
YARN-2937.002.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243381#comment-14243381
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686704/YARN-2937.003.patch
against trunk revision 0bcea11.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6094//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6094//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch, YARN-2937.001.patch,
YARN-2937.002.patch, YARN-2937.003.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243752#comment-14243752 ] Varun Saxena commented on YARN-2937: [~zjshen], can you review this one as well ? Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: HADOOP-11373.patch, YARN-2937.001.patch, YARN-2937.002.patch, YARN-2937.003.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241922#comment-14241922
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686345/YARN-2937.001.patch
against trunk revision 2e98ad3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 41 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDecommission
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAcls
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6074//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6074//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6074//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch, YARN-2937.001.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241929#comment-14241929 ] Varun Saxena commented on YARN-2937: Weird...Why are HDFS tests being run for a Yarn patch ? Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: HADOOP-11373.patch, YARN-2937.001.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[ https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240056#comment-14240056 ] Varun Saxena commented on YARN-2937: These test case failures may have to do with using Future#get(fix for RV_RETURN_VALUE_IGNORED_BAD_PRACTICE). Will check Fix new findbugs warnings in hadoop-yarn-nodemanager Key: YARN-2937 URL: https://issues.apache.org/jira/browse/YARN-2937 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Varun Saxena Fix For: 2.7.0 Attachments: HADOOP-11373.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2937) Fix new findbugs warnings in hadoop-yarn-nodemanager
[
https://issues.apache.org/jira/browse/YARN-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240078#comment-14240078
]
Hadoop QA commented on YARN-2937:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686067/HADOOP-11373.patch
against trunk revision 5776a41.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
org.apache.hadoop.yarn.server.nodemanager.containermanager.TestContainerManager
org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch
org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater
org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerShutdown
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6060//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6060//console
This message is automatically generated.
Fix new findbugs warnings in hadoop-yarn-nodemanager
Key: YARN-2937
URL: https://issues.apache.org/jira/browse/YARN-2937
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Varun Saxena
Assignee: Varun Saxena
Fix For: 2.7.0
Attachments: HADOOP-11373.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
