[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254663#comment-14254663
]
Hudson commented on YARN-2952:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #47 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/47/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254677#comment-14254677
]
Hudson commented on YARN-2952:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #781 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/781/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254740#comment-14254740
]
Hudson commented on YARN-2952:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1979 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1979/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
* hadoop-yarn-project/CHANGES.txt
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254754#comment-14254754
]
Hudson commented on YARN-2952:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #44 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/44/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254789#comment-14254789
]
Hudson commented on YARN-2952:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #48 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/48/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
* hadoop-yarn-project/CHANGES.txt
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254806#comment-14254806
]
Hudson commented on YARN-2952:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1998 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1998/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254395#comment-14254395
]
Hudson commented on YARN-2952:
--
FAILURE: Integrated in Hadoop-trunk-Commit #6765 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6765/])
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith
Sharmaks (jianhe: rev 808cba3821d5bc4267f69d14220757f01cd55715)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
*
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/LeveldbTimelineStore.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
* hadoop-yarn-project/CHANGES.txt
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.0
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247573#comment-14247573
]
Hadoop QA commented on YARN-2952:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12687061/0001-YARN-2952.patch
against trunk revision a095622.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 45 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6116//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6116//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-applicationhistoryservice.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6116//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6116//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6116//console
This message is automatically generated.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247581#comment-14247581
]
Jian He commented on YARN-2952:
---
looks good, +1
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245969#comment-14245969
]
Rohith commented on YARN-2952:
--
Test case failure and findbug warning are unrelated to this patch.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245522#comment-14245522
]
Rohith commented on YARN-2952:
--
Where ever LeveDB is used, it has been already taken care for getting current
version info. These won't cause any issues. Still I guarded in the upper layer
but RMStateStore has real issue.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245523#comment-14245523
]
Rohith commented on YARN-2952:
--
Kindly review the attached patch.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245588#comment-14245588
]
Hadoop QA commented on YARN-2952:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12687061/0001-YARN-2952.patch
against trunk revision cbfb996.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 45 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6110//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6110//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-applicationhistoryservice.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6110//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6110//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6110//console
This message is automatically generated.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-2952.patch
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1427#comment-1427
]
Rohith commented on YARN-2952:
--
+1 for issue, always base major version is considered as 1. But in real use
cases, base major version can be greater than 2 or 3 which installation itself
will fail.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244491#comment-14244491
]
Zhijie Shen commented on YARN-2952:
---
This problematic code has be propagated to multiple places where leveldb is
used, which need to be fixed together.
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect; The same thing might
happen to NM store, timeline store.
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2952) Incorrect version check in RMStateStore
[
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243585#comment-14243585
]
Jian He commented on YARN-2952:
---
we may change {{loadedVersion = Version.newInstance(1, 0);}} to
{{getCurrentVersion()}}
Incorrect version check in RMStateStore
---
Key: YARN-2952
URL: https://issues.apache.org/jira/browse/YARN-2952
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
In RMStateStore#checkVersion: if we modify tCURRENT_VERSION_INFO to 2.0,
it'll still store the version as 1.0 which is incorrect;
{code}
// if there is no version info, treat it as 1.0;
if (loadedVersion == null) {
loadedVersion = Version.newInstance(1, 0);
}
if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
LOG.info(Storing RM state version info + getCurrentVersion());
storeVersion();
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
