[jira] [Commented] (YARN-3282) DockerContainerExecutor should support environment variables setting
[ https://issues.apache.org/jira/browse/YARN-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341511#comment-14341511 ] Hadoop QA commented on YARN-3282: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701571/YARN-3282.01.patch against trunk revision 2e44b75. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The following test timeouts occurred in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.mapred.TestMRIntermediateDataEncryption Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6797//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6797//console This message is automatically generated. > DockerContainerExecutor should support environment variables setting > > > Key: YARN-3282 > URL: https://issues.apache.org/jira/browse/YARN-3282 > Project: Hadoop YARN > Issue Type: Improvement > Components: applications, nodemanager >Affects Versions: 2.6.0 >Reporter: Leitao Guo > Attachments: YARN-3282.01.patch > > > Currently, DockerContainerExecutor will mount "yarn.nodemanager.local-dirs" > and "yarn.nodemanager.log-dirs" to containers automatically. However > applications maybe need set more environment variables before launching > containers. > In our applications, just as the following command, we need to attach several > directories and set some environment variables to docker containers. > {code} > docker run -i -t -v /data/transcode:/data/tmp -v /etc/qcs:/etc/qcs -v > /mnt:/mnt -e VTC_MQTYPE=rabbitmq -e VTC_APP=ugc -e VTC_LOCATION=sh -e > VTC_RUNTIME=vtc sequenceiq/hadoop-docker:2.6.0 /bin/bash > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3282) DockerContainerExecutor should support environment variables setting
[ https://issues.apache.org/jira/browse/YARN-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341953#comment-14341953 ] Abin Shahab commented on YARN-3282: --- [~guoleitao], Can you not include everything you need inside the docker image? That's the premise of the docker container executor. It assumes that the user will provide a docker image that is self-sufficient and is not dependent on the nodemanager for any files or directories. > DockerContainerExecutor should support environment variables setting > > > Key: YARN-3282 > URL: https://issues.apache.org/jira/browse/YARN-3282 > Project: Hadoop YARN > Issue Type: Improvement > Components: applications, nodemanager >Affects Versions: 2.6.0 >Reporter: Leitao Guo > Attachments: YARN-3282.01.patch > > > Currently, DockerContainerExecutor will mount "yarn.nodemanager.local-dirs" > and "yarn.nodemanager.log-dirs" to containers automatically. However > applications maybe need set more environment variables before launching > containers. > In our applications, just as the following command, we need to attach several > directories and set some environment variables to docker containers. > {code} > docker run -i -t -v /data/transcode:/data/tmp -v /etc/qcs:/etc/qcs -v > /mnt:/mnt -e VTC_MQTYPE=rabbitmq -e VTC_APP=ugc -e VTC_LOCATION=sh -e > VTC_RUNTIME=vtc sequenceiq/hadoop-docker:2.6.0 /bin/bash > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3282) DockerContainerExecutor should support environment variables setting
[ https://issues.apache.org/jira/browse/YARN-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346315#comment-14346315 ] Leitao Guo commented on YARN-3282: -- Hi [~ashahab], thanks for your comments. I agree with you that a docker image should try to be self-sufficient, but in our scenarios, the data are stored in a remote shared storage system, we mount these storage as a local dirs to nodemanager, and only a few applications running in docker containers need to access these dirs. So these dirs are not suitable as "yarn.nodemanager.local-dirs", which are mounted to docker container as default. IMHO. I think an extra method to set environment variables for docker containers is necessary. > DockerContainerExecutor should support environment variables setting > > > Key: YARN-3282 > URL: https://issues.apache.org/jira/browse/YARN-3282 > Project: Hadoop YARN > Issue Type: Improvement > Components: applications, nodemanager >Affects Versions: 2.6.0 >Reporter: Leitao Guo > Attachments: YARN-3282.01.patch > > > Currently, DockerContainerExecutor will mount "yarn.nodemanager.local-dirs" > and "yarn.nodemanager.log-dirs" to containers automatically. However > applications maybe need set more environment variables before launching > containers. > In our applications, just as the following command, we need to attach several > directories and set some environment variables to docker containers. > {code} > docker run -i -t -v /data/transcode:/data/tmp -v /etc/qcs:/etc/qcs -v > /mnt:/mnt -e VTC_MQTYPE=rabbitmq -e VTC_APP=ugc -e VTC_LOCATION=sh -e > VTC_RUNTIME=vtc sequenceiq/hadoop-docker:2.6.0 /bin/bash > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)