[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368625#comment-14368625 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-trunk-Commit #7371 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7371/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368917#comment-14368917 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #137 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/137/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368939#comment-14368939 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-Yarn-trunk #871 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/871/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369429#comment-14369429 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #128 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/128/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369408#comment-14369408 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2069 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2069/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369534#comment-14369534 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2087 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2087/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java * hadoop-yarn-project/CHANGES.txt Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[ https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369496#comment-14369496 ] Hudson commented on YARN-3357: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #137 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/137/]) YARN-3357. Move TestFifoScheduler to FIFO package. Contributed by Rohith (devaraj: rev 93d0f4acc8454b7a460da8883fbd14f14a575370) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestFifoScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestApplicationMasterService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fifo/TestFifoScheduler.java Move TestFifoScheduler to FIFO package -- Key: YARN-3357 URL: https://issues.apache.org/jira/browse/YARN-3357 Project: Hadoop YARN Issue Type: Task Components: scheduler, test Reporter: Rohith Assignee: Rohith Attachments: 0001-YARN-3357.patch There are 2 test classes are found for fifo scheduler i.e # org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler # org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler. In these some test cases are common in both that does same functionality has been verified i.e testBlackListNodes. Tests from package org.apache.hadoop.yarn.server.resourcemanager can be merged with package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate duplicate tests -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[
https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367108#comment-14367108
]
Hadoop QA commented on YARN-3357:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705333/0001-YARN-3357.patch
against trunk revision 3411732.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7011//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7011//console
This message is automatically generated.
Move TestFifoScheduler to FIFO package
--
Key: YARN-3357
URL: https://issues.apache.org/jira/browse/YARN-3357
Project: Hadoop YARN
Issue Type: Task
Components: scheduler
Reporter: Rohith
Assignee: Rohith
Attachments: 0001-YARN-3357.patch
There are 2 test classes are found for fifo scheduler i.e
# org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler
#
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler.
In these some test cases are common in both that does same functionality has
been verified i.e testBlackListNodes. Tests from package
org.apache.hadoop.yarn.server.resourcemanager can be merged with package
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate
duplicate tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3357) Move TestFifoScheduler to FIFO package
[
https://issues.apache.org/jira/browse/YARN-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367030#comment-14367030
]
Rohith commented on YARN-3357:
--
Attaching the patch with following changes
# Moved all the tests from
org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler to
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
# Removed duplicated test which was testing same functionality in both the
classes i.e {{testBlackListNodes}}
# Other 2 test classes were using TestFifoScheduler as class name for logging
in test. I just corrected to its own classes.
Kindly review the patch
Move TestFifoScheduler to FIFO package
--
Key: YARN-3357
URL: https://issues.apache.org/jira/browse/YARN-3357
Project: Hadoop YARN
Issue Type: Task
Components: scheduler
Reporter: Rohith
Assignee: Rohith
Attachments: 0001-YARN-3357.patch
There are 2 test classes are found for fifo scheduler i.e
# org.apache.hadoop.yarn.server.resourcemanager.TestFifoScheduler
#
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler.
In these some test cases are common in both that does same functionality has
been verified i.e testBlackListNodes. Tests from package
org.apache.hadoop.yarn.server.resourcemanager can be merged with package
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo. And eliminate
duplicate tests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
