[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632483#comment-14632483 ] Hudson commented on YARN-3844: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2206 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2206/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c * hadoop-yarn-project/CHANGES.txt > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632477#comment-14632477 ] Hudson commented on YARN-3844: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #257 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/257/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632450#comment-14632450 ] Hudson commented on YARN-3844: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #249 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/249/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632442#comment-14632442 ] Hudson commented on YARN-3844: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2187 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2187/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632370#comment-14632370 ] Hudson commented on YARN-3844: -- FAILURE: Integrated in Hadoop-Yarn-trunk #990 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/990/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632365#comment-14632365 ] Hudson commented on YARN-3844: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #260 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/260/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631763#comment-14631763 ] Hudson commented on YARN-3844: -- FAILURE: Integrated in Hadoop-trunk-Commit #8181 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8181/]) YARN-3844. Make hadoop-yarn-project Native code -Wall-clean (Alan Burlison via Colin P. McCabe) (cmccabe: rev 419c51d233bd124eadb38ff013693576ec02c4f1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/configuration.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/CHANGES.txt > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 2.8.0 > > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631720#comment-14631720 ] Colin Patrick McCabe commented on YARN-3844: +1. Thanks, Alan. > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.007.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626225#comment-14626225
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 19s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 39s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 20s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 18s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | yarn tests | 6m 7s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 21m 19s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12745237/YARN-3844.007.patch |
| Optional Tests | javac unit |
| git revision | trunk / 4084eaf |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8530/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8530/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8530/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8530/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.007.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625371#comment-14625371 ] Alan Burlison commented on YARN-3844: - Oops yes, good catch - thanks. I'll change it to use PRId64 like the others, and I'll check to see if there are other instances elsewhere. > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.006.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625339#comment-14625339
]
Colin Patrick McCabe commented on YARN-3844:
{code}
snprintf(pid_buf, sizeof(pid_buf), "%ld", (int64_t)pid);
{code}
This will generate a warning on 32-bit
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.006.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625050#comment-14625050
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 17s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 35s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 20s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | yarn tests | 6m 2s | Tests failed in
hadoop-yarn-server-nodemanager. |
| | | 21m 8s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests |
hadoop.yarn.server.nodemanager.containermanager.container.TestContainer |
| |
hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService
|
| |
hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
|
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12745078/YARN-3844.006.patch |
| Optional Tests | javac unit |
| git revision | trunk / 19295b3 |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8521/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8521/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8521/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8521/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.006.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610546#comment-14610546
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 13s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 36s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 20s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | yarn tests | 6m 20s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 21m 34s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12743073/YARN-3844.005.patch |
| Optional Tests | javac unit |
| git revision | trunk / 80a68d6 |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8407/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8407/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8407/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8407/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.005.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[ https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609249#comment-14609249 ] Alan Burlison commented on YARN-3844: - Er yeah, that's because it is wrong - oops! Will fix. As this code is going to be built LP64 in most cases it's probably moot but I can go through and change it to long long if you like. > Make hadoop-yarn-project Native code -Wall-clean > > > Key: YARN-3844 > URL: https://issues.apache.org/jira/browse/YARN-3844 > Project: Hadoop YARN > Issue Type: Sub-task > Components: build >Affects Versions: 2.7.0 > Environment: As we specify -Wall as a default compilation flag, it > would be helpful if the Native code was -Wall-clean >Reporter: Alan Burlison >Assignee: Alan Burlison > Attachments: YARN-3844.001.patch, YARN-3844.002.patch, > YARN-3844.004.patch > > > As we specify -Wall as a default compilation flag, it would be helpful if the > Native code was -Wall-clean -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609240#comment-14609240
]
Colin Patrick McCabe commented on YARN-3844:
Thanks for looking at this, Alan.
{code}
printf("FAIL: process %s pid %ld did not exit\n", (long)cmd, child);
{code}
This doesn't seem correct. Casting the {{cmd}} string to a long?
I would prefer to cast the pid_t variables to {{long long}} rather than
{{long}}, to be completely sure.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.004.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609034#comment-14609034
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 49s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 6s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 41s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 36s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | yarn tests | 7m 1s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 23m 37s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742918/YARN-3844.004.patch |
| Optional Tests | javac unit |
| git revision | trunk / 147e020 |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8396/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8396/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8396/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8396/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.004.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608838#comment-14608838
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742902/YARN-3844.003.patch |
| Optional Tests | javac unit |
| git revision | trunk / 147e020 |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8393/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch,
> YARN-3844.003.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608680#comment-14608680
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 22s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | yarn tests | 6m 7s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 21m 32s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742872/YARN-3844.002.patch |
| Optional Tests | javac unit |
| git revision | trunk / 076948d |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8391/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8391/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8391/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8391/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch, YARN-3844.002.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3844) Make hadoop-yarn-project Native code -Wall-clean
[
https://issues.apache.org/jira/browse/YARN-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608605#comment-14608605
]
Hadoop QA commented on YARN-3844:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 14s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 35s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 18s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 5 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | yarn tests | 6m 3s | Tests passed in
hadoop-yarn-server-nodemanager. |
| | | 21m 20s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12741629/YARN-3844.001.patch |
| Optional Tests | javac unit |
| git revision | trunk / 076948d |
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8389/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-server-nodemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8389/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8389/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8389/console |
This message was automatically generated.
> Make hadoop-yarn-project Native code -Wall-clean
>
>
> Key: YARN-3844
> URL: https://issues.apache.org/jira/browse/YARN-3844
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: build
>Affects Versions: 2.7.0
> Environment: As we specify -Wall as a default compilation flag, it
> would be helpful if the Native code was -Wall-clean
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Attachments: YARN-3844.001.patch
>
>
> As we specify -Wall as a default compilation flag, it would be helpful if the
> Native code was -Wall-clean
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
