[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946165#comment-14946165 ] Naganarasimha G R commented on YARN-4215: - Thanks [~wangda] for reviewing and committing the patch > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946082#comment-14946082 ] Hudson commented on YARN-4215: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2401 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2401/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946038#comment-14946038 ] Hudson commented on YARN-4215: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #462 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/462/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945887#comment-14945887 ] Hudson commented on YARN-4215: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2431 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2431/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945845#comment-14945845 ] Hudson commented on YARN-4215: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #487 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/487/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945811#comment-14945811 ] Hudson commented on YARN-4215: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #496 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/496/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945753#comment-14945753 ] Hudson commented on YARN-4215: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #1225 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1225/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java * hadoop-yarn-project/CHANGES.txt > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945603#comment-14945603 ] Hudson commented on YARN-4215: -- FAILURE: Integrated in Hadoop-trunk-Commit #8577 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8577/]) YARN-4215. RMNodeLabels Manager Need to verify and replace node labels (wangda: rev 29a582ada0fe195989eca25e5a995895e178f4ea) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/RMNodeLabelsManager.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Fix For: 2.8.0 > > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945558#comment-14945558 ] Wangda Tan commented on YARN-4215: -- Patch looks good, committing... > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945491#comment-14945491 ] Naganarasimha G R commented on YARN-4215: - TestFifoScheduler is passing locally and seems like modifications over here will not impact this test case. > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944676#comment-14944676 ] Hadoop QA commented on YARN-4215: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 19m 48s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 9m 5s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 11m 28s | There were no new javadoc warning messages. | | {color:red}-1{color} | release audit | 0m 16s | The applied patch generated 1 release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 57s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 39s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 36s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 43s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | yarn tests | 59m 24s | Tests failed in hadoop-yarn-server-resourcemanager. | | | | 105m 0s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12765138/YARN-4215.v1.002.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 5f6edb3 | | Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9359/artifact/patchprocess/patchReleaseAuditProblems.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9359/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9359/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9359/console | This message was automatically generated. > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944608#comment-14944608 ] Hadoop QA commented on YARN-4215: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 18m 24s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 56s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 21s | There were no new javadoc warning messages. | | {color:red}-1{color} | release audit | 0m 15s | The applied patch generated 1 release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 51s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 31s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 30s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 56m 21s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 97m 47s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12765130/YARN-4215.v1.002.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 5f6edb3 | | Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9358/artifact/patchprocess/patchReleaseAuditProblems.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9358/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9358/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9358/console | This message was automatically generated. > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch, YARN-4215.v1.002.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944313#comment-14944313 ] Wangda Tan commented on YARN-4215: -- Thanks [~Naganarasimha]! Patch generally looks good to me, Only a few nits in the test: - I suggest to add one more test just to avoid regression in the future: If a host has label (node1:0 label=x). If someone update label of node1:0 to y. Scheduler should receive an event as well. - Could you check if labels of the events are expected? {code} 483 mgr.replaceLabelsOnNode(ImmutableMap.of(toNodeId("n1:1"), toSet("p1"), 484 toNodeId("n2:1"), toSet("p2"), toNodeId("n3"), toSet("p3"))); 485 assertTrue("Event should be sent when there is change in labels", 486 schedEventsHandler.receivedEvent); 487 assertEquals("3 node label mapping modified", 3, 488 schedEventsHandler.updatedNodeToLabels.size()); 489 schedEventsHandler.receivedEvent = false; {code} > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940044#comment-14940044 ] Naganarasimha G R commented on YARN-4215: - Release Audit warnings might not be related to the patch! May be once reviewed i can resubmit the patch > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4215) RMNodeLabels Manager Need to verify and replace node labels for the only modified Node Label Mappings in the request
[ https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939380#comment-14939380 ] Hadoop QA commented on YARN-4215: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 19m 11s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 8m 36s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 54s | There were no new javadoc warning messages. | | {color:red}-1{color} | release audit | 0m 16s | The applied patch generated 1 release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 54s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 33s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 34s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 56m 37s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 100m 14s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12764532/YARN-4215.v1.001.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 5db371f | | Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9316/artifact/patchprocess/patchReleaseAuditProblems.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9316/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9316/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9316/console | This message was automatically generated. > RMNodeLabels Manager Need to verify and replace node labels for the only > modified Node Label Mappings in the request > > > Key: YARN-4215 > URL: https://issues.apache.org/jira/browse/YARN-4215 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager >Reporter: Naganarasimha G R >Assignee: Naganarasimha G R > Labels: nodelabel, resourcemanager > Attachments: YARN-4215.v1.001.patch > > > Modified node Labels needs to be updated by the capacity scheduler holding a > lock hence its better to push events to scheduler only when there is actually > a change in the label mapping for a given node. -- This message was sent by Atlassian JIRA (v6.3.4#6332)