[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632852#comment-13632852 ] Hudson commented on YARN-444: - Integrated in Hadoop-Mapreduce-trunk #1401 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1401/]) YARN-444. Moved special container exit codes from YarnConfiguration to API where they belong. Contributed by Sandy Ryza. MAPREDUCE-5151. Updated MR AM to use standard exit codes from the API after YARN-444. Contributed by Sandy Ryza. (Revision 1468276) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468276 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ContainerExitStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerInfo.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.0.5-beta > > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444-2.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632816#comment-13632816 ] Hudson commented on YARN-444: - Integrated in Hadoop-Hdfs-trunk #1374 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1374/]) YARN-444. Moved special container exit codes from YarnConfiguration to API where they belong. Contributed by Sandy Ryza. MAPREDUCE-5151. Updated MR AM to use standard exit codes from the API after YARN-444. Contributed by Sandy Ryza. (Revision 1468276) Result = FAILURE vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468276 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ContainerExitStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerInfo.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.0.5-beta > > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444-2.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632743#comment-13632743 ] Hudson commented on YARN-444: - Integrated in Hadoop-Yarn-trunk #185 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/185/]) YARN-444. Moved special container exit codes from YarnConfiguration to API where they belong. Contributed by Sandy Ryza. MAPREDUCE-5151. Updated MR AM to use standard exit codes from the API after YARN-444. Contributed by Sandy Ryza. (Revision 1468276) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468276 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ContainerExitStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerInfo.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.0.5-beta > > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444-2.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632402#comment-13632402 ] Hudson commented on YARN-444: - Integrated in Hadoop-trunk-Commit #3615 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3615/]) YARN-444. Moved special container exit codes from YarnConfiguration to API where they belong. Contributed by Sandy Ryza. MAPREDUCE-5151. Updated MR AM to use standard exit codes from the API after YARN-444. Contributed by Sandy Ryza. (Revision 1468276) Result = SUCCESS vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468276 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ContainerExitStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ContainerStatus.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerInfo.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Fix For: 2.0.5-beta > > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444-2.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[
https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632353#comment-13632353
]
Hadoop QA commented on YARN-444:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578832/YARN-444-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/744//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/744//console
This message is automatically generated.
> Move special container exit codes from YarnConfiguration to API
> ---
>
> Key: YARN-444
> URL: https://issues.apache.org/jira/browse/YARN-444
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, applications/distributed-shell
>Affects Versions: 2.0.3-alpha
>Reporter: Sandy Ryza
>Assignee: Sandy Ryza
> Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch,
> YARN-444-2.patch, YARN-444.patch
>
>
> YarnConfiguration currently contains the special container exit codes
> INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100,
> and DISKS_FAILED = -101.
> These are not really not really related to configuration, and
> YarnConfiguration should not become a place to put miscellaneous constants.
> Per discussion on YARN-417, appmaster writers need to be able to provide
> special handling for them, so it might make sense to move these to their own
> user-facing class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632322#comment-13632322 ] Sandy Ryza commented on YARN-444: - Thanks Vinod. Uploaded a patch that applies cleanly on top of MAPREDUCE-4974. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444-2.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632147#comment-13632147 ] Vinod Kumar Vavilapalli commented on YARN-444: -- This looks good, checking it in.. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[
https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632130#comment-13632130
]
Hadoop QA commented on YARN-444:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578794/YARN-444-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/742//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/742//console
This message is automatically generated.
> Move special container exit codes from YarnConfiguration to API
> ---
>
> Key: YARN-444
> URL: https://issues.apache.org/jira/browse/YARN-444
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, applications/distributed-shell
>Affects Versions: 2.0.3-alpha
>Reporter: Sandy Ryza
>Assignee: Sandy Ryza
> Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch,
> YARN-444.patch
>
>
> YarnConfiguration currently contains the special container exit codes
> INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100,
> and DISKS_FAILED = -101.
> These are not really not really related to configuration, and
> YarnConfiguration should not become a place to put miscellaneous constants.
> Per discussion on YARN-417, appmaster writers need to be able to provide
> special handling for them, so it might make sense to move these to their own
> user-facing class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632080#comment-13632080 ] Sandy Ryza commented on YARN-444: - Sorry, had a stale version of trunk. Latest patch should apply. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444-2.patch, > YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[
https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632053#comment-13632053
]
Hadoop QA commented on YARN-444:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578769/YARN-444-2.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/741//console
This message is automatically generated.
> Move special container exit codes from YarnConfiguration to API
> ---
>
> Key: YARN-444
> URL: https://issues.apache.org/jira/browse/YARN-444
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, applications/distributed-shell
>Affects Versions: 2.0.3-alpha
>Reporter: Sandy Ryza
>Assignee: Sandy Ryza
> Attachments: YARN-444-1.patch, YARN-444-2.patch, YARN-444.patch
>
>
> YarnConfiguration currently contains the special container exit codes
> INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100,
> and DISKS_FAILED = -101.
> These are not really not really related to configuration, and
> YarnConfiguration should not become a place to put miscellaneous constants.
> Per discussion on YARN-417, appmaster writers need to be able to provide
> special handling for them, so it might make sense to move these to their own
> user-facing class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631978#comment-13631978 ] Sandy Ryza commented on YARN-444: - bq. As a logic extension of this, I think we should convert the ExitStatus into an object which holds... What would be the use of the meaning/description? ContainerStatus already contains a diagnostic string that in theory should be holding the same information, right? Uploading a patch that adds the annotations to ContainerExitStatus, removes the references to specific literals, and adds an enum to yarn_protos. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619584#comment-13619584 ] Bikas Saha commented on YARN-444: - IMO when the container exits because YARN took some specific action on it eg. killed due to preemption or killed due to memory then YARN should assign action specific exit status using new values defined inside ContainerExitStatus. Currently, NM kills the container and assigns its real exit code to exit status. So at the AM its hard to tell why the container exited. Of course, not as part of this jira. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619203#comment-13619203 ] Sandy Ryza commented on YARN-444: - Test failure is unrelated > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[
https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619200#comment-13619200
]
Hadoop QA commented on YARN-444:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576433/YARN-444-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestContainerLocalizer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/639//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/639//console
This message is automatically generated.
> Move special container exit codes from YarnConfiguration to API
> ---
>
> Key: YARN-444
> URL: https://issues.apache.org/jira/browse/YARN-444
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, applications/distributed-shell
>Affects Versions: 2.0.3-alpha
>Reporter: Sandy Ryza
>Assignee: Sandy Ryza
> Attachments: YARN-444-1.patch, YARN-444.patch
>
>
> YarnConfiguration currently contains the special container exit codes
> INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100,
> and DISKS_FAILED = -101.
> These are not really not really related to configuration, and
> YarnConfiguration should not become a place to put miscellaneous constants.
> Per discussion on YARN-417, appmaster writers need to be able to provide
> special handling for them, so it might make sense to move these to their own
> user-facing class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619151#comment-13619151 ] Sandy Ryza commented on YARN-444: - Ok, I am convinced. Uploading new patch with the change. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444-1.patch, YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618991#comment-13618991 ] Bikas Saha commented on YARN-444: - You can look QueueState, YarnApplicationState, NodeState, ContainerState etc in the API for inspiration. To me ContainerExitStatus.ABORTED reads better than ContainerExitStatuses.ABORTED. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618938#comment-13618938 ] Sandy Ryza commented on YARN-444: - My thinking behind the plurals was that using the singular makes it seems like a ContainerExitStatus is something that the class allows you to instantiate, where rather, in the manner of the Arrays or Collections classes, the class is more of a namespace for holding related static fields and methods. What do you think? I'll fix the comments when we decide which way to go. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618470#comment-13618470 ] Bikas Saha commented on YARN-444: - Patch looks mostly good. I wonder why the plural has been used in the name of the class when thats not the common pattern. The comments in ContainerStatus.java mix the plural and singular. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613210#comment-13613210 ] Sandy Ryza commented on YARN-444: - Simple patch moves exit statuses to a ContainerExitStatuses class and updates the references and documentation. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > Attachments: YARN-444.patch > > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-444) Move special container exit codes from YarnConfiguration to API
[ https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591088#comment-13591088 ] Bikas Saha commented on YARN-444: - I like the proposal to move them out of YARN configuration unless there was a specific reason to put them there. I would really like to not call these exit codes. It nice that the API is ContainerStatus.*getExitStatus()*. Exit codes may be returned when the container exits by itself without any action by YARN. When YARN takes an action (such as pre-empt, abort, kill due to memory etc) then it can set a YARN specific status to reflect that action. This status can be programmatically used by clients (such as the app client mentioned in the description) to take necessary action. > Move special container exit codes from YarnConfiguration to API > --- > > Key: YARN-444 > URL: https://issues.apache.org/jira/browse/YARN-444 > Project: Hadoop YARN > Issue Type: Improvement > Components: api, applications/distributed-shell >Affects Versions: 2.0.3-alpha >Reporter: Sandy Ryza >Assignee: Sandy Ryza > > YarnConfiguration currently contains the special container exit codes > INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100, > and DISKS_FAILED = -101. > These are not really not really related to configuration, and > YarnConfiguration should not become a place to put miscellaneous constants. > Per discussion on YARN-417, appmaster writers need to be able to provide > special handling for them, so it might make sense to move these to their own > user-facing class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
