[jira] [Commented] (YARN-4534) Remove the redundant symbol in yarn rmadmin help msg
[
https://issues.apache.org/jira/browse/YARN-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097936#comment-15097936
]
Lin Yiqun commented on YARN-4534:
-
Thanks [~ajisakaa] for review and commit!
> Remove the redundant symbol in yarn rmadmin help msg
>
>
> Key: YARN-4534
> URL: https://issues.apache.org/jira/browse/YARN-4534
> Project: Hadoop YARN
> Issue Type: Bug
>Affects Versions: 2.7.1
>Reporter: Lin Yiqun
>Assignee: Lin Yiqun
>Priority: Trivial
> Fix For: 2.8.0
>
> Attachments: YARN-4534.001.patch
>
>
> In rmadmin help, there is a redundant symbol ']' in
> {{-directlyAccessNodeLabelStore}} command. The msg is following:
> {code}
> bin/yarn rmadmin -help
> rmadmin is the command to execute YARN administrative commands.
> The full syntax is:
> yarn rmadmin [-refreshQueues] [-refreshNodes]
> [-refreshSuperUserGroupsConfiguration] [-refreshUserToGroupsMappings]
> [-refreshAdminAcls] [-refreshServiceAcl] [-getGroup [username]]
> [[-addToClusterNodeLabels [label1,label2,label3]]
> [-removeFromClusterNodeLabels [label1,label2,label3]] [-replaceLabelsOnNode
> [node1[:port]=label1,label2 node2[:port]=label1]
> [-directlyAccessNodeLabelStore]] [-help [cmd]]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4534) Remove the redundant symbol in yarn rmadmin help msg
[
https://issues.apache.org/jira/browse/YARN-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097665#comment-15097665
]
Hudson commented on YARN-4534:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9106 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/9106/])
YARN-4534. Remove the redundant symbol in yarn rmadmin help msg. (aajisaka: rev
62b0d6151362a9860d4d750e6e0d032882af68aa)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
> Remove the redundant symbol in yarn rmadmin help msg
>
>
> Key: YARN-4534
> URL: https://issues.apache.org/jira/browse/YARN-4534
> Project: Hadoop YARN
> Issue Type: Bug
>Affects Versions: 2.7.1
>Reporter: Lin Yiqun
>Assignee: Lin Yiqun
>Priority: Trivial
> Fix For: 2.8.0
>
> Attachments: YARN-4534.001.patch
>
>
> In rmadmin help, there is a redundant symbol ']' in
> {{-directlyAccessNodeLabelStore}} command. The msg is following:
> {code}
> bin/yarn rmadmin -help
> rmadmin is the command to execute YARN administrative commands.
> The full syntax is:
> yarn rmadmin [-refreshQueues] [-refreshNodes]
> [-refreshSuperUserGroupsConfiguration] [-refreshUserToGroupsMappings]
> [-refreshAdminAcls] [-refreshServiceAcl] [-getGroup [username]]
> [[-addToClusterNodeLabels [label1,label2,label3]]
> [-removeFromClusterNodeLabels [label1,label2,label3]] [-replaceLabelsOnNode
> [node1[:port]=label1,label2 node2[:port]=label1]
> [-directlyAccessNodeLabelStore]] [-help [cmd]]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4534) Remove the redundant symbol in yarn rmadmin help msg
[
https://issues.apache.org/jira/browse/YARN-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097596#comment-15097596
]
Akira AJISAKA commented on YARN-4534:
-
LGTM, +1.
> Remove the redundant symbol in yarn rmadmin help msg
>
>
> Key: YARN-4534
> URL: https://issues.apache.org/jira/browse/YARN-4534
> Project: Hadoop YARN
> Issue Type: Improvement
>Affects Versions: 2.7.1
>Reporter: Lin Yiqun
>Assignee: Lin Yiqun
> Attachments: YARN-4534.001.patch
>
>
> In rmadmin help, there is a redundant symbol ']' in
> {{-directlyAccessNodeLabelStore}} command. The msg is following:
> {code}
> bin/yarn rmadmin -help
> rmadmin is the command to execute YARN administrative commands.
> The full syntax is:
> yarn rmadmin [-refreshQueues] [-refreshNodes]
> [-refreshSuperUserGroupsConfiguration] [-refreshUserToGroupsMappings]
> [-refreshAdminAcls] [-refreshServiceAcl] [-getGroup [username]]
> [[-addToClusterNodeLabels [label1,label2,label3]]
> [-removeFromClusterNodeLabels [label1,label2,label3]] [-replaceLabelsOnNode
> [node1[:port]=label1,label2 node2[:port]=label1]
> [-directlyAccessNodeLabelStore]] [-help [cmd]]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4534) Remove the redundant symbol in yarn rmadmin help msg
[
https://issues.apache.org/jira/browse/YARN-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087013#comment-15087013
]
Lin Yiqun commented on YARN-4534:
-
The failed test seems not related. Kindly review.
> Remove the redundant symbol in yarn rmadmin help msg
>
>
> Key: YARN-4534
> URL: https://issues.apache.org/jira/browse/YARN-4534
> Project: Hadoop YARN
> Issue Type: Improvement
>Affects Versions: 2.7.1
>Reporter: Lin Yiqun
>Assignee: Lin Yiqun
> Attachments: YARN-4534.001.patch
>
>
> In rmadmin help, there is a redundant symbol ']' in
> {{-directlyAccessNodeLabelStore}} command. The msg is following:
> {code}
> bin/yarn rmadmin -help
> rmadmin is the command to execute YARN administrative commands.
> The full syntax is:
> yarn rmadmin [-refreshQueues] [-refreshNodes]
> [-refreshSuperUserGroupsConfiguration] [-refreshUserToGroupsMappings]
> [-refreshAdminAcls] [-refreshServiceAcl] [-getGroup [username]]
> [[-addToClusterNodeLabels [label1,label2,label3]]
> [-removeFromClusterNodeLabels [label1,label2,label3]] [-replaceLabelsOnNode
> [node1[:port]=label1,label2 node2[:port]=label1]
> [-directlyAccessNodeLabelStore]] [-help [cmd]]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4534) Remove the redundant symbol in yarn rmadmin help msg
[
https://issues.apache.org/jira/browse/YARN-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080745#comment-15080745
]
Hadoop QA commented on YARN-4534:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
53s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 24s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
33s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 13s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 13s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 45, now 45).
{color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
37s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 64m 19s {color}
| {color:red} hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 64m 33s {color}
| {color:red} hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 143m 14s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests | hadoop.yarn.client.TestGetGroups |
| JDK v1.8.0_66 Timed out junit tests |
org.apache.hadoop.yarn.client.cli.TestYarnCLI |
| | org.apache.hadoop.yarn.client.api.impl.TestYarnClient |
| | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient |
| | org.apache.hadoop.yarn.client.api.impl.TestNMClient |
| JDK v1.7.0_91 Failed junit tests | hadoop.yarn.client.TestGetGroups |
| JDK v1.7.0_91 Timed out junit tests |
org.apache.hadoop.yarn.client.cli.TestYarnCLI |
| | org.apache.hadoop.yarn.client.api.impl.Te
