[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610798#comment-15610798 ] Rohith Sharma K S commented on YARN-4555: - committing shortly.. > TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh > locale environment > -- > > Key: YARN-4555 > URL: https://issues.apache.org/jira/browse/YARN-4555 > Project: Hadoop YARN > Issue Type: Test > Components: nodemanager, test >Affects Versions: 2.7.1 >Reporter: Takashi Ohnishi >Assignee: Takashi Ohnishi >Priority: Minor > Attachments: YARN-4555.1.patch > > > In my env where LANG=ja_JP.UTF-8, the test fails with > {code} > --- > Test set: > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > --- > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.286 sec <<< > FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > testContainerLaunchError(org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor) > Time elapsed: 1.149 sec <<< FAILURE! > java.lang.AssertionError: Invalid Diagnostics message: Exception from > container-launch. > Container id: CONTAINER_ID > Exit code: 127 > Exception message: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディレクトリはありません > Stack trace: ExitCodeException exitCode=127: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディ>レクトリはありません > {code} > This is because the test code assertion assumes the English locale as below. > {code} > 250 public Object answer(InvocationOnMock invocationOnMock) > 251 throws Throwable { > 252 String diagnostics = (String) > invocationOnMock.getArguments()[0]; > 253 assertTrue("Invalid Diagnostics message: " + diagnostics, > 254 diagnostics.contains("No such file or directory")); > 255 return null; > 256 } > {code} > This exists on trunk, too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257573#comment-15257573 ] Hadoop QA commented on YARN-4555: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 35s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s {color} | {color:green} trunk passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 28s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 50s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s {color} | {color:green} trunk passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s {color} | {color:green} the patch passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 58s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s {color} | {color:green} the patch passed with JDK v1.8.0_92 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 59s {color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_92. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 11m 30s {color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 1s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:fbe3e86 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch | | JIRA Issue | YARN-4555 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux f0103d68cb50 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 8eadd71 | | Default Java | 1.7.0_95 | | Multi-JDK versio
[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114830#comment-15114830 ] Varun Vasudev commented on YARN-4555: - Patch should work with docker as well, no issue from that end. > TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh > locale environment > -- > > Key: YARN-4555 > URL: https://issues.apache.org/jira/browse/YARN-4555 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.7.1 >Reporter: Takashi Ohnishi >Assignee: Takashi Ohnishi >Priority: Minor > Attachments: YARN-4555.1.patch > > > In my env where LANG=ja_JP.UTF-8, the test fails with > {code} > --- > Test set: > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > --- > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.286 sec <<< > FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > testContainerLaunchError(org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor) > Time elapsed: 1.149 sec <<< FAILURE! > java.lang.AssertionError: Invalid Diagnostics message: Exception from > container-launch. > Container id: CONTAINER_ID > Exit code: 127 > Exception message: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディレクトリはありません > Stack trace: ExitCodeException exitCode=127: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディ>レクトリはありません > {code} > This is because the test code assertion assumes the English locale as below. > {code} > 250 public Object answer(InvocationOnMock invocationOnMock) > 251 throws Throwable { > 252 String diagnostics = (String) > invocationOnMock.getArguments()[0]; > 253 assertTrue("Invalid Diagnostics message: " + diagnostics, > 254 diagnostics.contains("No such file or directory")); > 255 return null; > 256 } > {code} > This exists on trunk, too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114820#comment-15114820 ] Rohith Sharma K S commented on YARN-4555: - I am not sure about the patch fix in different environment, I would like to take an opinion from who is recently working on docker. cc:/[~vvasudev] > TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh > locale environment > -- > > Key: YARN-4555 > URL: https://issues.apache.org/jira/browse/YARN-4555 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager >Affects Versions: 2.7.1 >Reporter: Takashi Ohnishi >Assignee: Takashi Ohnishi >Priority: Minor > Attachments: YARN-4555.1.patch > > > In my env where LANG=ja_JP.UTF-8, the test fails with > {code} > --- > Test set: > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > --- > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.286 sec <<< > FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > testContainerLaunchError(org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor) > Time elapsed: 1.149 sec <<< FAILURE! > java.lang.AssertionError: Invalid Diagnostics message: Exception from > container-launch. > Container id: CONTAINER_ID > Exit code: 127 > Exception message: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディレクトリはありません > Stack trace: ExitCodeException exitCode=127: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディ>レクトリはありません > {code} > This is because the test code assertion assumes the English locale as below. > {code} > 250 public Object answer(InvocationOnMock invocationOnMock) > 251 throws Throwable { > 252 String diagnostics = (String) > invocationOnMock.getArguments()[0]; > 253 assertTrue("Invalid Diagnostics message: " + diagnostics, > 254 diagnostics.contains("No such file or directory")); > 255 return null; > 256 } > {code} > This exists on trunk, too. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-englihsh locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087492#comment-15087492 ] Hadoop QA commented on YARN-4555: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 18s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s {color} | {color:green} trunk passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s {color} | {color:green} trunk passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 54s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s {color} | {color:green} trunk passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s {color} | {color:green} trunk passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s {color} | {color:green} the patch passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s {color} | {color:green} the patch passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 59s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s {color} | {color:green} the patch passed with JDK v1.8.0_66 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s {color} | {color:green} the patch passed with JDK v1.7.0_91 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 24s {color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 59s {color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 43s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:0ca8df7 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch | | JIRA Issue | YARN-4555 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 093b02e4a138 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 6702e7d | | Default Java | 1.7.0_91 | | Multi-JDK version