[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-english locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615478#comment-15615478 ] Takashi Ohnishi commented on YARN-4555: --- Thanks [~rohithsharma] for commtting ! > TestDefaultContainerExecutor#testContainerLaunchError fails on non-english > locale environment > - > > Key: YARN-4555 > URL: https://issues.apache.org/jira/browse/YARN-4555 > Project: Hadoop YARN > Issue Type: Test > Components: nodemanager, test >Affects Versions: 2.7.1 >Reporter: Takashi Ohnishi >Assignee: Takashi Ohnishi >Priority: Minor > Fix For: 2.9.0, 3.0.0-alpha2 > > Attachments: YARN-4555.1.patch > > > In my env where LANG=ja_JP.UTF-8, the test fails with > {code} > --- > Test set: > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > --- > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.286 sec <<< > FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > testContainerLaunchError(org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor) > Time elapsed: 1.149 sec <<< FAILURE! > java.lang.AssertionError: Invalid Diagnostics message: Exception from > container-launch. > Container id: CONTAINER_ID > Exit code: 127 > Exception message: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディレクトリはありません > Stack trace: ExitCodeException exitCode=127: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディ>レクトリはありません > {code} > This is because the test code assertion assumes the English locale as below. > {code} > 250 public Object answer(InvocationOnMock invocationOnMock) > 251 throws Throwable { > 252 String diagnostics = (String) > invocationOnMock.getArguments()[0]; > 253 assertTrue("Invalid Diagnostics message: " + diagnostics, > 254 diagnostics.contains("No such file or directory")); > 255 return null; > 256 } > {code} > This exists on trunk, too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-english locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610874#comment-15610874 ] Hadoop QA commented on YARN-4555: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 32s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 48s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 41s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 31m 42s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | YARN-4555 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12780967/YARN-4555.1.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 2346e7e50ab8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 9f32364 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/13533/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/13533/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > TestDefaultContainerExecutor#testContainerLaunchError fails on non-english > locale environment > - > > Key: YARN-4555 > URL: https://issues.apache.org/jira/browse/YARN-4555 > Project: Hadoop YARN > Issue Type: Test > Components: nodemanager, test >Affects Versions: 2.7.1 >Reporter: Takashi Ohnishi >Assignee: Takashi Ohnishi >
[jira] [Commented] (YARN-4555) TestDefaultContainerExecutor#testContainerLaunchError fails on non-english locale environment
[ https://issues.apache.org/jira/browse/YARN-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610851#comment-15610851 ] Hudson commented on YARN-4555: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10694 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10694/]) YARN-4555. TestDefaultContainerExecutor#testContainerLaunchError fails (rohithsharmaks: rev b110c4b5e82d8310f13a22bba1c8afbcca80144f) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDefaultContainerExecutor.java > TestDefaultContainerExecutor#testContainerLaunchError fails on non-english > locale environment > - > > Key: YARN-4555 > URL: https://issues.apache.org/jira/browse/YARN-4555 > Project: Hadoop YARN > Issue Type: Test > Components: nodemanager, test >Affects Versions: 2.7.1 >Reporter: Takashi Ohnishi >Assignee: Takashi Ohnishi >Priority: Minor > Fix For: 2.9.0, 3.0.0-alpha2 > > Attachments: YARN-4555.1.patch > > > In my env where LANG=ja_JP.UTF-8, the test fails with > {code} > --- > Test set: > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > --- > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.286 sec <<< > FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor > testContainerLaunchError(org.apache.hadoop.yarn.server.nodemanager.TestDefaultContainerExecutor) > Time elapsed: 1.149 sec <<< FAILURE! > java.lang.AssertionError: Invalid Diagnostics message: Exception from > container-launch. > Container id: CONTAINER_ID > Exit code: 127 > Exception message: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディレクトリはありません > Stack trace: ExitCodeException exitCode=127: bash: > target/TestDefaultContainerExecutor/localDir/default_container_executor.sh: > そのようなファイルやディ>レクトリはありません > {code} > This is because the test code assertion assumes the English locale as below. > {code} > 250 public Object answer(InvocationOnMock invocationOnMock) > 251 throws Throwable { > 252 String diagnostics = (String) > invocationOnMock.getArguments()[0]; > 253 assertTrue("Invalid Diagnostics message: " + diagnostics, > 254 diagnostics.contains("No such file or directory")); > 255 return null; > 256 } > {code} > This exists on trunk, too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org