[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222543#comment-15222543 ] Hudson commented on YARN-4895: -- FAILURE: Integrated in Hadoop-trunk-Commit #9543 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9543/]) Missing file for YARN-4895. (arun suresh: rev 5686caa9fcb59759c9286385575f31e407a97c16) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/TestResourceUtilization.java > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch, YARN-4895.002.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222428#comment-15222428 ] Hudson commented on YARN-4895: -- FAILURE: Integrated in Hadoop-trunk-Commit #9542 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9542/]) YARN-4895. Add subtractFrom method to ResourceUtilization class. (arun suresh: rev 82621e38a0445832998bc00693279e23a98605c1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceUtilization.java > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch, YARN-4895.002.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221851#comment-15221851 ] Karthik Kambatla commented on YARN-4895: +1 > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch, YARN-4895.002.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221550#comment-15221550 ] Varun Vasudev commented on YARN-4895: - The latest patch looks fine to me. Please go ahead and commit it. > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch, YARN-4895.002.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220041#comment-15220041 ] Arun Suresh commented on YARN-4895: --- Actually.. let me hold off on this till end of day.. [~vvasudev], let me know if your comments on https://issues.apache.org/jira/browse/YARN-4895?focusedCommentId=15218803=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15218803 have been addressed to your satisfaction > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch, YARN-4895.002.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220032#comment-15220032 ] Arun Suresh commented on YARN-4895: --- +1, Thanks for the patch [~kkaranasos] will commit this shortly.. > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch, YARN-4895.002.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[
https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219170#comment-15219170
]
Hadoop QA commented on YARN-4895:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
36s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 45s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 8s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 57s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 21s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 50s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 8s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 8s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 27s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s
{color} | {color:green} hadoop-yarn-api in the patch passed with JDK v1.8.0_74.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 55s
{color} | {color:green} hadoop-yarn-common in the patch passed with JDK
v1.8.0_74. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s
{color} | {color:green} hadoop-yarn-api in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 11s
{color} | {color:green} hadoop-yarn-common in the patch passed with JDK
v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 5s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[
https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218803#comment-15218803
]
Konstantinos Karanasos commented on YARN-4895:
--
Thanks, [~vvasudev].
bq. the function name "subtractFrom" implies that you're going to subtract the
memory and cpu of the object from the values that are passed to the function
and return a new object.
I see your point. However, given that it is not a static method, {{addTo}} and
{{subtractFrom}} seem OK to me.
Think that you will have something like {{resourceUtil.addTo(...)}} or
{{resourceUtil.subtractFrom(...)}}, which I think makes sense. What do you
think?
bq. doesn't seem related to this patch - did you add it just as a good to have?
True, but as you point out, I think it's good to have, and it will also be
needed for YARN-2883.
bq. It looks like there are no tests for the ResourceUtilization class at all.
Can you please add some tests?
Yep, will do.
> Add subtractFrom method to ResourceUtilization class
>
>
> Key: YARN-4895
> URL: https://issues.apache.org/jira/browse/YARN-4895
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Konstantinos Karanasos
>Assignee: Konstantinos Karanasos
> Attachments: YARN-4895.001.patch
>
>
> In ResourceUtilization class, there is already an addTo method.
> For completeness, here we are adding the dual subtractFrom method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[
https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217647#comment-15217647
]
Varun Vasudev commented on YARN-4895:
-
# [~kkaranasos] - the function name "subtractFrom" implies that you're going to
subtract the memory and cpu of the object from the values that are passed to
the function and return a new object. Maybe just name it "subtract"? On a
similar note, "addTo" should really be called just "add".
# {code}
+ @Public
+ @Unstable
+ public static ResourceUtilization newInstance(
+ ResourceUtilization resourceUtil) {
+return newInstance(resourceUtil.getPhysicalMemory(),
+resourceUtil.getVirtualMemory(), resourceUtil.getCPU());
+ }
{code}
doesn't seem related to this patch - did you add it just as a good to have?
# It looks like there are no tests for the ResourceUtilization class at all.
Can you please add some tests?
> Add subtractFrom method to ResourceUtilization class
>
>
> Key: YARN-4895
> URL: https://issues.apache.org/jira/browse/YARN-4895
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Konstantinos Karanasos
>Assignee: Konstantinos Karanasos
> Attachments: YARN-4895.001.patch
>
>
> In ResourceUtilization class, there is already an addTo method.
> For completeness, here we are adding the dual subtractFrom method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217291#comment-15217291 ] Sunil G commented on YARN-4895: --- Thanks [~kkaranasos] for the clarification. > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216869#comment-15216869 ] Konstantinos Karanasos commented on YARN-4895: -- Thanks for the feedback, [~sunilg]. Given that this is a utility method, I believe we should not need to worry about what value is passed as a parameter. This should be handled by the caller. > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4895) Add subtractFrom method to ResourceUtilization class
[ https://issues.apache.org/jira/browse/YARN-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216658#comment-15216658 ] Sunil G commented on YARN-4895: --- Hi [~kkaranasos] Do we need to worry about -ve cases here? Or will it be handled in caller end? > Add subtractFrom method to ResourceUtilization class > > > Key: YARN-4895 > URL: https://issues.apache.org/jira/browse/YARN-4895 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Konstantinos Karanasos >Assignee: Konstantinos Karanasos > Attachments: YARN-4895.001.patch > > > In ResourceUtilization class, there is already an addTo method. > For completeness, here we are adding the dual subtractFrom method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
