[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-07-06 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365036#comment-15365036
 ] 

Hudson commented on YARN-5227:
--

SUCCESS: Integrated in Hadoop-trunk-Commit #10055 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10055/])
YARN-5227. Yarn logs command: no need to specify applicationId when (jianhe: 
rev d169f5052fe83debcea7cf2f317dcd990890a857)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestLogsCLI.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/LogsCLI.java


> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Fix For: 2.9.0
>
> Attachments: YARN-5227.001.patch, YARN-5227.002.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-07-06 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363914#comment-15363914
 ] 

Gergely Novák commented on YARN-5227:
-

[~jianhe] No, it's not.

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch, YARN-5227.002.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-07-05 Thread Jian He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363261#comment-15363261
 ] 

Jian He commented on YARN-5227:
---

[~GergelyNovak], is the unit failure related to this patch ?

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch, YARN-5227.002.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-27 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352220#comment-15352220
 ] 

Hadoop QA commented on YARN-5227:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 28s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 
51s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 21s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 22s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
28s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s 
{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The 
patch generated 6 new + 84 unchanged - 2 fixed = 90 total (was 86) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 20s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
33s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 12s {color} 
| {color:red} hadoop-yarn-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
17s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 21m 35s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.client.cli.TestLogsCLI |
|   | hadoop.yarn.client.api.impl.TestYarnClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:85209cc |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12814000/YARN-5227.002.patch |
| JIRA Issue | YARN-5227 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux af3c01ea5ee7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 7d20704 |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-YARN-Build/12147/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-YARN-Build/12147/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-YARN-Build/12147/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/12147/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Bu

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-27 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352196#comment-15352196
 ] 

Gergely Novák commented on YARN-5227:
-

Thanks for the comments, updated patch #2 with the suggested error message and 
refactor.

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch, YARN-5227.002.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-27 Thread Xuan Gong (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352066#comment-15352066
 ] 

Xuan Gong commented on YARN-5227:
-

[~GergelyNovak]
Thanks for working on this. The logic looks good to me. But let us re-factory a 
little bit. We could do something like:
{code}
ApplicationId appId = null;
ContainerId containerId = null;
if (appIdStr != null) {
  try {
appId = ApplicationId.fromString(appIdStr);
  } catch (Exception e) {
System.err.println("Invalid ApplicationId specified");
return -1;
  }
} 

if (containerIdStr != null) {
  try {
containerId = ContainerId.fromString(containerIdStr);
if (appId == null) {
  appId = containerId.getApplicationAttemptId().getApplicationId();
} else if(!containerId.getApplicationAttemptId().getApplicationId()
.equals(appId)) {
  System.err.println("The Application:" + appId
  + " does not have the container:" + containerId);
  return -1;
}
  } catch (Exception e) {
  System.err.println("Invalid ContainerId specified");
  return -1;  
  }
}
{code}

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-27 Thread Jian He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351816#comment-15351816
 ] 

Jian He commented on YARN-5227:
---

i see, thanks for the explanation !

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-25 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349709#comment-15349709
 ] 

Gergely Novák commented on YARN-5227:
-

If both the appId and the containerId are specified, the appId will be 
interpreted in the block you quoted and the containerId will be interpreted in 
line 233-241:
{code}
if (containerId == null) {
  containerId = ContainerId.fromString(containerIdStr);
  if (!containerId.getApplicationAttemptId().getApplicationId()
  .equals(appId)) {
System.err.println("The Application:" + appId
+ " does not have the container:" + containerId);
return -1;
  }
}
{code}

I will change the error message in the next patch according to your suggestion.

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-24 Thread Jian He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348949#comment-15348949
 ] 

Jian He commented on YARN-5227:
---

oh,  I misread. I interpreted as "If containerId is specified, appId should be 
null".
May be change the message to be something like "ERROR: Both applicationId and 
containerId are not specified.  One of them must be specified."

For below logic, if both appId and containerId are specified, containerId will 
not be interpreted ? Then it will fail
{code}
if (appIdStr != null) {
  try {
appId = ApplicationId.fromString(appIdStr);
  } catch (Exception e) {
System.err.println("Invalid ApplicationId specified");
return -1;
  }
} else {
  try {
containerId = ContainerId.fromString(containerIdStr);
appId = containerId.getApplicationAttemptId().getApplicationId();
  } catch (Exception e) {
System.err.println("Invalid ContainerId specified");
return -1;
  }
}
{code}

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-24 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348929#comment-15348929
 ] 

Gergely Novák commented on YARN-5227:
-

We fail if neither of them is specified ({{appIdStr == null && containerIdStr 
== null}}). 

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-24 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348900#comment-15348900
 ] 

Hadoop QA commented on YARN-5227:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 35s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 
0s {color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 
44s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 22s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
30s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
17s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s 
{color} | {color:red} hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The 
patch generated 6 new + 84 unchanged - 2 fixed = 90 total (was 86) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 19s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 
33s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 12s {color} 
| {color:red} hadoop-yarn-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
17s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 22s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.client.cli.TestLogsCLI |
|   | hadoop.yarn.client.api.impl.TestYarnClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:85209cc |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12813147/YARN-5227.001.patch |
| JIRA Issue | YARN-5227 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux f6022fee326e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / bf74dbf |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-YARN-Build/12127/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-YARN-Build/12127/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-YARN-Build/12127/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/12127/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-B

[jira] [Commented] (YARN-5227) yarn logs command: no need to specify -applicationId when specifying containerId

2016-06-24 Thread Jian He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348860#comment-15348860
 ] 

Jian He commented on YARN-5227:
---

thanks for working on this. 
The error message seems contradicting with the logic. not sure what the 
intention is. 
We should not fail if appId and containerId are specified at the same time. 
Just that, the appId can be optional if containerId is specified.
{code}
if (appIdStr == null && containerIdStr == null) {
  System.err.println("ApplicationId can only be null "
  + " if the containerId is specified!");
  printHelpMessage(printOpts);
  return -1;
}
{code}

> yarn logs command: no need to specify -applicationId when specifying 
> containerId
> 
>
> Key: YARN-5227
> URL: https://issues.apache.org/jira/browse/YARN-5227
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Jian He
>Assignee: Gergely Novák
> Attachments: YARN-5227.001.patch
>
>
> No need to specify -applicaionId when specifying containerId, because 
> applicationId is retrievable from containerId



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org