[jira] [Commented] (YARN-5450) Enhance logging for Cluster.java around InetSocketAddress
[
https://issues.apache.org/jira/browse/YARN-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410641#comment-15410641
]
Varun Saxena commented on YARN-5450:
[~vrushalic], thanks for the patch.
Will move this JIRA to Mapreduce project as the change is strictly in MapReduce
project.
A couple of comments:
# In my opinion, there is no need to check LOG#isInfoEnabled because logs are
typically at INFO level anyway. Our codebase if full of logging at INFO level
without the check.
# I am not 100% sure of the use case but I think we should move the log
statement above the check for clientprotocolprovider being null because
exception is thrown there. And this log will be more useful if a
clientprotocolprovider implementation cannot be picked. Maybe move this log
above the for loop ?
{code}
138 if (null == clientProtocolProvider || null == client) {
139 throw initEx;
140 }
141 if (LOG.isInfoEnabled() && jobTrackAddr != null) {
142 LOG.info("Initialized Cluster for source=" +
jobTrackAddr.toString());
143 }
{code}
3. Change {{LOG.info("Initializing Cluster for source=}} to
{{LOG.info("Initializing Cluster for job tracker }} ?
> Enhance logging for Cluster.java around InetSocketAddress
> -
>
> Key: YARN-5450
> URL: https://issues.apache.org/jira/browse/YARN-5450
> Project: Hadoop YARN
> Issue Type: New Feature
> Components: yarn
>Reporter: sarun singla
>Assignee: Vrushali C
>Priority: Minor
> Labels: YARN
> Attachments: YARN-5450.01.patch
>
>
> We need to add more logging for cluster.java class around "
> initialize(InetSocketAddress jobTrackAddr, Configuration conf) " method to
> give better logging like about the source of the property.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5450) Enhance logging for Cluster.java around InetSocketAddress
[ https://issues.apache.org/jira/browse/YARN-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408461#comment-15408461 ] Vrushali C commented on YARN-5450: -- Cool, thanks [~sarun]. Perhaps someone can commit this in when they get the chance. > Enhance logging for Cluster.java around InetSocketAddress > - > > Key: YARN-5450 > URL: https://issues.apache.org/jira/browse/YARN-5450 > Project: Hadoop YARN > Issue Type: New Feature > Components: yarn >Reporter: sarun singla >Assignee: Vrushali C >Priority: Minor > Labels: YARN > Attachments: YARN-5450.01.patch > > > We need to add more logging for cluster.java class around " > initialize(InetSocketAddress jobTrackAddr, Configuration conf) " method to > give better logging like about the source of the property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5450) Enhance logging for Cluster.java around InetSocketAddress
[ https://issues.apache.org/jira/browse/YARN-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407967#comment-15407967 ] sarun singla commented on YARN-5450: [~vrushalic] this looks good to me. > Enhance logging for Cluster.java around InetSocketAddress > - > > Key: YARN-5450 > URL: https://issues.apache.org/jira/browse/YARN-5450 > Project: Hadoop YARN > Issue Type: New Feature > Components: yarn >Reporter: sarun singla >Assignee: Vrushali C >Priority: Minor > Labels: YARN > Attachments: YARN-5450.01.patch > > > We need to add more logging for cluster.java class around " > initialize(InetSocketAddress jobTrackAddr, Configuration conf) " method to > give better logging like about the source of the property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5450) Enhance logging for Cluster.java around InetSocketAddress
[ https://issues.apache.org/jira/browse/YARN-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406891#comment-15406891 ] Li Lu commented on YARN-5450: - Patch LGTM. [~sarun] could you please verify if this would be fine with your suggested use case? Thanks! > Enhance logging for Cluster.java around InetSocketAddress > - > > Key: YARN-5450 > URL: https://issues.apache.org/jira/browse/YARN-5450 > Project: Hadoop YARN > Issue Type: New Feature > Components: yarn >Reporter: sarun singla >Assignee: Vrushali C >Priority: Minor > Labels: YARN > Attachments: YARN-5450.01.patch > > > We need to add more logging for cluster.java class around " > initialize(InetSocketAddress jobTrackAddr, Configuration conf) " method to > give better logging like about the source of the property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5450) Enhance logging for Cluster.java around InetSocketAddress
[ https://issues.apache.org/jira/browse/YARN-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406783#comment-15406783 ] Vrushali C commented on YARN-5450: -- Hi [~sarun] Did you get a chance to look at the patch? thanks Vrushali > Enhance logging for Cluster.java around InetSocketAddress > - > > Key: YARN-5450 > URL: https://issues.apache.org/jira/browse/YARN-5450 > Project: Hadoop YARN > Issue Type: New Feature > Components: yarn >Reporter: sarun singla >Assignee: Vrushali C >Priority: Minor > Labels: YARN > Attachments: YARN-5450.01.patch > > > We need to add more logging for cluster.java class around " > initialize(InetSocketAddress jobTrackAddr, Configuration conf) " method to > give better logging like about the source of the property. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5450) Enhance logging for Cluster.java around InetSocketAddress
[
https://issues.apache.org/jira/browse/YARN-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399899#comment-15399899
]
Hadoop QA commented on YARN-5450:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
52s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
48s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
51s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 1s
{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 14s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12821059/YARN-5450.01.patch |
| JIRA Issue | YARN-5450 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 195bcd1e05cd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 95f2b98 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/12566/testReport/ |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/12566/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Enhance logging for Cluster.java around InetSocketAddress
> -
>
> Key: YARN-5450
> URL: https://issues.apache.org/jira/browse/YARN-5450
> Project: Hadoop YARN
> Issue Type: New Feature
> Components: yarn
>Reporter: sarun singla
>Assignee: Vrushali C
>Priority:
