[jira] [Commented] (YARN-553) Have GetNewApplicationResponse generate a directly usable ApplicationSubmissionContext
[ https://issues.apache.org/jira/browse/YARN-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13678201#comment-13678201 ] Hadoop QA commented on YARN-553: {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12586672/yarn-553-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1157//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1157//console This message is automatically generated. > Have GetNewApplicationResponse generate a directly usable > ApplicationSubmissionContext > -- > > Key: YARN-553 > URL: https://issues.apache.org/jira/browse/YARN-553 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Affects Versions: 2.0.3-alpha >Reporter: Harsh J >Assignee: Karthik Kambatla >Priority: Minor > Attachments: yarn-553-1.patch, yarn-553-2.patch > > > Right now, we're doing multiple steps to create a relevant > ApplicationSubmissionContext for a pre-received GetNewApplicationResponse. > {code} > GetNewApplicationResponse newApp = yarnClient.getNewApplication(); > ApplicationId appId = newApp.getApplicationId(); > ApplicationSubmissionContext appContext = > Records.newRecord(ApplicationSubmissionContext.class); > appContext.setApplicationId(appId); > {code} > A simplified way may be to have the GetNewApplicationResponse itself provide > a helper method that builds a usable ApplicationSubmissionContext for us. > Something like: > {code} > GetNewApplicationResponse newApp = yarnClient.getNewApplication(); > ApplicationSubmissionContext appContext = > newApp.generateApplicationSubmissionContext(); > {code} > [The above method can also take an arg for the container launch spec, or > perhaps pre-load defaults like min-resource, etc. in the returned object, > aside of just associating the application ID automatically.] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-553) Have GetNewApplicationResponse generate a directly usable ApplicationSubmissionContext
[ https://issues.apache.org/jira/browse/YARN-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677793#comment-13677793 ] Hadoop QA commented on YARN-553: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12586656/yarn-553-1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/1154//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1154//console This message is automatically generated. > Have GetNewApplicationResponse generate a directly usable > ApplicationSubmissionContext > -- > > Key: YARN-553 > URL: https://issues.apache.org/jira/browse/YARN-553 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Affects Versions: 2.0.3-alpha >Reporter: Harsh J >Assignee: Karthik Kambatla >Priority: Minor > Attachments: yarn-553-1.patch > > > Right now, we're doing multiple steps to create a relevant > ApplicationSubmissionContext for a pre-received GetNewApplicationResponse. > {code} > GetNewApplicationResponse newApp = yarnClient.getNewApplication(); > ApplicationId appId = newApp.getApplicationId(); > ApplicationSubmissionContext appContext = > Records.newRecord(ApplicationSubmissionContext.class); > appContext.setApplicationId(appId); > {code} > A simplified way may be to have the GetNewApplicationResponse itself provide > a helper method that builds a usable ApplicationSubmissionContext for us. > Something like: > {code} > GetNewApplicationResponse newApp = yarnClient.getNewApplication(); > ApplicationSubmissionContext appContext = > newApp.generateApplicationSubmissionContext(); > {code} > [The above method can also take an arg for the container launch spec, or > perhaps pre-load defaults like min-resource, etc. in the returned object, > aside of just associating the application ID automatically.] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-553) Have GetNewApplicationResponse generate a directly usable ApplicationSubmissionContext
[ https://issues.apache.org/jira/browse/YARN-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648828#comment-13648828 ] Karthik Kambatla commented on YARN-553: --- Given that {{GetNewApplicationResponse}} and {{ApplicationSubmissionContext}} are both records with PB impls, I feel we should leave them alone. Instead, we can always add {{getNewApplicationSubmissionContext()}} method(s) to {{YarnClient}} directly so users could just do {code} ApplicationSubmissionContext appContext = yarnClient.getNewApplicationSubmissionContext()}} {code} > Have GetNewApplicationResponse generate a directly usable > ApplicationSubmissionContext > -- > > Key: YARN-553 > URL: https://issues.apache.org/jira/browse/YARN-553 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Affects Versions: 2.0.3-alpha >Reporter: Harsh J >Assignee: Karthik Kambatla >Priority: Minor > > Right now, we're doing multiple steps to create a relevant > ApplicationSubmissionContext for a pre-received GetNewApplicationResponse. > {code} > GetNewApplicationResponse newApp = yarnClient.getNewApplication(); > ApplicationId appId = newApp.getApplicationId(); > ApplicationSubmissionContext appContext = > Records.newRecord(ApplicationSubmissionContext.class); > appContext.setApplicationId(appId); > {code} > A simplified way may be to have the GetNewApplicationResponse itself provide > a helper method that builds a usable ApplicationSubmissionContext for us. > Something like: > {code} > GetNewApplicationResponse newApp = yarnClient.getNewApplication(); > ApplicationSubmissionContext appContext = > newApp.generateApplicationSubmissionContext(); > {code} > [The above method can also take an arg for the container launch spec, or > perhaps pre-load defaults like min-resource, etc. in the returned object, > aside of just associating the application ID automatically.] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira