[jira] [Commented] (YARN-572) Remove duplication of data in Container
[ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655084#comment-13655084 ] Vinod Kumar Vavilapalli commented on YARN-572: -- Zhijie, if you plan to do that, we should just close this and do that separately. I didn't close it so others (Sid/Bikas who mentioned this before) can have the final call. > Remove duplication of data in Container > > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both > the Container class as well as in the ContainerToken object that the > Container object already contains. It would be good to remove this level of > duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-572) Remove duplication of data in Container
[ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655046#comment-13655046 ] Zhijie Shen commented on YARN-572: -- ContainerTokenIdentifier, ContainerTokenSelector, ContainerManagerSecurityInfo move to server.security of server-common, BuilderUtils.newContainerToken moves to YarnServerBuilderUtils.newContainerToken > Remove duplication of data in Container > > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both > the Container class as well as in the ContainerToken object that the > Container object already contains. It would be good to remove this level of > duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-572) Remove duplication of data in Container
[ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655024#comment-13655024 ] Vinod Kumar Vavilapalli commented on YARN-572: -- ContainerToken is in a sense already non-interpretable, see org.apache.hadoop.yarn.api.records.ContainerToken and its super class : the ID is already a ByteBuffer. What we need to do is move ContainerTokenIdentifier off to server-common, so that Client will have absolutely have no way of interpreting the ByteBuffer. Arguably, they could still do it, but at that point, it isn't supported clearly. > Remove duplication of data in Container > > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both > the Container class as well as in the ContainerToken object that the > Container object already contains. It would be good to remove this level of > duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-572) Remove duplication of data in Container
[ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655018#comment-13655018 ] Hitesh Shah commented on YARN-572: -- Assuming that the ContainerToken is going to be changed into a bytebuffer to hide from the AM, the duplication of fields will be necessary. @Sid, @Vinod, can you confirm on the bytebuffer change? In that case, we can close this jira out. > Remove duplication of data in Container > > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both > the Container class as well as in the ContainerToken object that the > Container object already contains. It would be good to remove this level of > duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-572) Remove duplication of data in Container
[ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654958#comment-13654958 ] Zhijie Shen commented on YARN-572: -- And in some cases, the three fields are set while container token is null in a Container object, e.g., MRAppBenchmark, LocalContainerAllocator. Therefore, if three fields are removed from Container, we need to constructor a ContainerTokenIdentifier object just to hold the three values in these cases. > Remove duplication of data in Container > > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both > the Container class as well as in the ContainerToken object that the > Container object already contains. It would be good to remove this level of > duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-572) Remove duplication of data in Container
[ https://issues.apache.org/jira/browse/YARN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654946#comment-13654946 ] Zhijie Shen commented on YARN-572: -- There are three fields that are duplicate in Container and ContainerTokenIdentifier: 1. ContainerId 2. NodeId 3. Resource Though the fields are duplicated, it seems not good to remove them from Container. 1 and 2 are used to compare the Container objects and the getters of all the three are referred in multiple places tens of times. > Remove duplication of data in Container > > > Key: YARN-572 > URL: https://issues.apache.org/jira/browse/YARN-572 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Hitesh Shah >Assignee: Zhijie Shen > > Most of the information needed to launch a container is duplicated in both > the Container class as well as in the ContainerToken object that the > Container object already contains. It would be good to remove this level of > duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
