[jira] [Commented] (YARN-6126) Obtaining app logs for Running application fails with "Unable to parse json from webservice. Error:"

2017-01-26 Thread Xuan Gong (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840670#comment-15840670
 ] 

Xuan Gong commented on YARN-6126:
-

It is because:
1) if partial log aggregation is enabled, the object ("containerLogsInfo") is 
JSONArray type
2) if not, the object("containerLogsInfo") is JSONObject

We should handle both of them. Uploaded a patch to fix it. 

It is hard to add a unit test, but do the manual test and verify it works fine.

> Obtaining app logs for Running application fails with "Unable to parse json 
> from webservice. Error:"
> 
>
> Key: YARN-6126
> URL: https://issues.apache.org/jira/browse/YARN-6126
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Xuan Gong
>Assignee: Xuan Gong
>
> After YARN-6099, we can output aggregated log files info as well as local log 
> files info if we enabled partial log aggregation. This breaks the original 
> logic in logsCLI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6126) Obtaining app logs for Running application fails with "Unable to parse json from webservice. Error:"

2017-01-26 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840842#comment-15840842
 ] 

Hadoop QA commented on YARN-6126:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m 
21s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 15s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-6126 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12849610/YARN-6126.trunk.1.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux d772eb8553ee 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 7bc333a |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/14765/testReport/ |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/14765/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Obtaining app logs for Running application fails with "Unable to parse json 
> from webservice. Error:"
> 
>
> Key: YARN-6126
> URL: https://issues.apache.org/jira/browse/YARN-6126
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Sumana Sathish
>Assignee: Xuan Gong
>

[jira] [Commented] (YARN-6126) Obtaining app logs for Running application fails with "Unable to parse json from webservice. Error:"

2017-01-27 Thread Junping Du (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842383#comment-15842383
 ] 

Junping Du commented on YARN-6126:
--

Sorry for missing this part in reviewing YARN-6099. The fix looks good. Will 
commit it shortly.

> Obtaining app logs for Running application fails with "Unable to parse json 
> from webservice. Error:"
> 
>
> Key: YARN-6126
> URL: https://issues.apache.org/jira/browse/YARN-6126
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Sumana Sathish
>Assignee: Xuan Gong
> Attachments: YARN-6126.branch-2.1.patch, YARN-6126.trunk.1.patch
>
>
> After YARN-6099, we can output aggregated log files info as well as local log 
> files info if we enabled partial log aggregation. This breaks the original 
> logic in logsCLI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-6126) Obtaining app logs for Running application fails with "Unable to parse json from webservice. Error:"

2017-01-27 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842962#comment-15842962
 ] 

Hudson commented on YARN-6126:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11185 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11185/])
YARN-6126. Obtaining app logs for Running application fails with json 
(junping_du: rev 1a16431bd0df52d2df32c594f8b9b506c2101ad8)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/LogsCLI.java


> Obtaining app logs for Running application fails with "Unable to parse json 
> from webservice. Error:"
> 
>
> Key: YARN-6126
> URL: https://issues.apache.org/jira/browse/YARN-6126
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Sumana Sathish
>Assignee: Xuan Gong
> Fix For: 2.9.0
>
> Attachments: YARN-6126.branch-2.1.patch, YARN-6126.trunk.1.patch
>
>
> After YARN-6099, we can output aggregated log files info as well as local log 
> files info if we enabled partial log aggregation. This breaks the original 
> logic in logsCLI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org