[jira] [Commented] (YARN-634) Introduce a SerializedException
[
https://issues.apache.org/jira/browse/YARN-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653619#comment-13653619
]
Hadoop QA commented on YARN-634:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12582583/YARN-634.patch.2
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/908//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/908//console
This message is automatically generated.
Introduce a SerializedException
---
Key: YARN-634
URL: https://issues.apache.org/jira/browse/YARN-634
Project: Hadoop YARN
Issue Type: Sub-task
Affects Versions: 2.0.4-alpha
Reporter: Siddharth Seth
Assignee: Siddharth Seth
Attachments: YARN-634.patch.2, YARN-634.txt
LocalizationProtocol sends an exception over the wire. This currently uses
YarnRemoteException. Post YARN-627, this needs to be changed and a new
serialized exception is required.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-634) Introduce a SerializedException
[ https://issues.apache.org/jira/browse/YARN-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652769#comment-13652769 ] Vinod Kumar Vavilapalli commented on YARN-634: -- bq. We don't need YarnRemoteException.getRemoteException* methods at all now? I meant RPCUtil.getRemoteException* methods bq. Sure. An unwind method would've been ideal. I'll add this for now, and we can think of removing it if no longer required when unwind is implemented. Unwind will be better. We can punt this. bq. SerializedException is really just a yarn record to captures an error, which is the payload on most of these FailureEvents. It's part of a method response payload as against being thrown by the method call itself. So I don't really see a reason to wind/unwind this at the edge. I'd prefer leaving this as is, unless you feel strongly about it. We'll definitely need and unwrap API. Going by the class_name logic, we also don't need getMessage() and getRemoteTrace() in SerializedException once we have unwind? I'd rather implement unwrap instead of adding all this unnecessary functionality. Introduce a SerializedException --- Key: YARN-634 URL: https://issues.apache.org/jira/browse/YARN-634 Project: Hadoop YARN Issue Type: Sub-task Affects Versions: 2.0.4-alpha Reporter: Siddharth Seth Assignee: Siddharth Seth Attachments: YARN-634.txt LocalizationProtocol sends an exception over the wire. This currently uses YarnRemoteException. Post YARN-627, this needs to be changed and a new serialized exception is required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-634) Introduce a SerializedException
[
https://issues.apache.org/jira/browse/YARN-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652375#comment-13652375
]
Hadoop QA commented on YARN-634:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12582354/YARN-634.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/896//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/896//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/896//console
This message is automatically generated.
Introduce a SerializedException
---
Key: YARN-634
URL: https://issues.apache.org/jira/browse/YARN-634
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.0.4-alpha
Reporter: Siddharth Seth
Assignee: Siddharth Seth
Attachments: YARN-634.txt
LocalizationProtocol sends an exception over the wire. This currently uses
YarnRemoteException. Post YARN-627, this needs to be changed and a new
serialized exception is required.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-634) Introduce a SerializedException
[ https://issues.apache.org/jira/browse/YARN-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13652617#comment-13652617 ] Siddharth Seth commented on YARN-634: - bq. Move SerializedException to be in server-api for now? We can move it to public api when needed. Sure. Will move this over. bq. We don't need YarnRemoteException.getRemoteException* methods at all now? Agree it is a massive change - I can file a follow up ticket. On SerializedException, or on YarnRemoteException ? YarnRemoteException should not require these methods - since the client will see the exception thrown by the server. SerializedException requires an unwind method - which needs to be added. Prefer doing this in a separate jira though; this one is more of a refactor. bq. Can you expose SerializedExceptionProto.class_name also in SerializedException? We found it wanting in few JIRAs. Sure. An unwind method would've been ideal. I'll add this for now, and we can think of removing it if no longer required when unwind is implemented. bq. Seems like if just have an unwind method on SerializedException, most of NM changes are unnecessary : ContainerResourceFailedEvent, LocalizedResource, ResourceFailedLocalizationEvent. Basically we can simply use SerializedException at the edge and wind/unwind before and after sending across the wire. SerializedException is really just a yarn record to captures an error, which is the payload on most of these FailureEvents. It's part of a method response payload as against being thrown by the method call itself. So I don't really see a reason to wind/unwind this at the edge. I'd prefer leaving this as is, unless you feel strongly about it. Introduce a SerializedException --- Key: YARN-634 URL: https://issues.apache.org/jira/browse/YARN-634 Project: Hadoop YARN Issue Type: Sub-task Affects Versions: 2.0.4-alpha Reporter: Siddharth Seth Assignee: Siddharth Seth Attachments: YARN-634.txt LocalizationProtocol sends an exception over the wire. This currently uses YarnRemoteException. Post YARN-627, this needs to be changed and a new serialized exception is required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
