[jira] [Commented] (YARN-673) Remove yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656641#comment-13656641 ] Siddharth Seth commented on YARN-673: - [~hitesh] That works as well. We can then defer generating separate documentation. bq. Currently the default.xml files are XSDed and avail in the docs http://hadoop.apache.org/docs/r2.0.4-alpha/index.html , see the last section 'Configuration' in the side menu Thanks for pointing that out. We could use what Hitesh mentioned - and continue to leave the *-default.xml files for documentation. Later, these could be converted to match the rest of the documentation if required. > Remove yarn-default.xml > --- > > Key: YARN-673 > URL: https://issues.apache.org/jira/browse/YARN-673 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Siddharth Seth > > The default configuration files serve 2 purposes > 1. Documenting available config parameters, and their default values. > 2. Specifying default values for these parameters. > An xml file hidden inside a jar is not necessarily the best way to document > parameters. This could be moved into the documentation itself. > Default values already exist in code for most parameters. There's no need to > specify them in two places. We need to make sure defaults exist for all > parameters before attempting this. > Having default configuration files just bloats job conf files; over 450 > parameters, out of which <20 are likely job specific params. JobConf files > end up being rather big, and the memory footprint of the conf object is large > (>300KB last I checked). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-673) Remove yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656498#comment-13656498 ] Alejandro Abdelnur commented on YARN-673: - Currently the default.xml files are XSDed and avail in the docs http://hadoop.apache.org/docs/r2.0.4-alpha/index.html , see the last section 'Configuration' in the side menu > Remove yarn-default.xml > --- > > Key: YARN-673 > URL: https://issues.apache.org/jira/browse/YARN-673 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Siddharth Seth > > The default configuration files serve 2 purposes > 1. Documenting available config parameters, and their default values. > 2. Specifying default values for these parameters. > An xml file hidden inside a jar is not necessarily the best way to document > parameters. This could be moved into the documentation itself. > Default values already exist in code for most parameters. There's no need to > specify them in two places. We need to make sure defaults exist for all > parameters before attempting this. > Having default configuration files just bloats job conf files; over 450 > parameters, out of which <20 are likely job specific params. JobConf files > end up being rather big, and the memory footprint of the conf object is large > (>300KB last I checked). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-673) Remove yarn-default.xml
[
https://issues.apache.org/jira/browse/YARN-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656348#comment-13656348
]
Hitesh Shah commented on YARN-673:
--
How about:
{code}
---
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
+++
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
@@ -38,7 +38,6 @@
private static final String YARN_SITE_XML_FILE = "yarn-site.xml";
static {
-Configuration.addDefaultResource(YARN_DEFAULT_XML_FILE);
Configuration.addDefaultResource(YARN_SITE_XML_FILE);
}
{code}
And optionally also, move yarn-default.xml out of the jar and make it part of
the tar/rpm under a conf.default/ directory.
> Remove yarn-default.xml
> ---
>
> Key: YARN-673
> URL: https://issues.apache.org/jira/browse/YARN-673
> Project: Hadoop YARN
> Issue Type: Improvement
>Reporter: Siddharth Seth
>
> The default configuration files serve 2 purposes
> 1. Documenting available config parameters, and their default values.
> 2. Specifying default values for these parameters.
> An xml file hidden inside a jar is not necessarily the best way to document
> parameters. This could be moved into the documentation itself.
> Default values already exist in code for most parameters. There's no need to
> specify them in two places. We need to make sure defaults exist for all
> parameters before attempting this.
> Having default configuration files just bloats job conf files; over 450
> parameters, out of which <20 are likely job specific params. JobConf files
> end up being rather big, and the memory footprint of the conf object is large
> (>300KB last I checked).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-673) Remove yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656343#comment-13656343 ] Siddharth Seth commented on YARN-673: - The documentation will be part of the source tree, so keeping it up to date should not be any tougher. Grepping through *-default.xml is really only for developers - and that should be possible on the documentation as well. Since these files sit insider jars - I don't see how they serve as documentation iac. > Remove yarn-default.xml > --- > > Key: YARN-673 > URL: https://issues.apache.org/jira/browse/YARN-673 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Siddharth Seth > > The default configuration files serve 2 purposes > 1. Documenting available config parameters, and their default values. > 2. Specifying default values for these parameters. > An xml file hidden inside a jar is not necessarily the best way to document > parameters. This could be moved into the documentation itself. > Default values already exist in code for most parameters. There's no need to > specify them in two places. We need to make sure defaults exist for all > parameters before attempting this. > Having default configuration files just bloats job conf files; over 450 > parameters, out of which <20 are likely job specific params. JobConf files > end up being rather big, and the memory footprint of the conf object is large > (>300KB last I checked). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-673) Remove yarn-default.xml
[ https://issues.apache.org/jira/browse/YARN-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655073#comment-13655073 ] Karthik Kambatla commented on YARN-673: --- While I understand that having two different default values in the default.xml and code could be error-prone, I believe we should be careful about removing yarn-default.xml altogether. Particularly because moving it further from the code would make it even harder to ensure the documentation reflects the same default as the code. Also, it is a lot easier to grep through default.xml for defaults than documentation. > Remove yarn-default.xml > --- > > Key: YARN-673 > URL: https://issues.apache.org/jira/browse/YARN-673 > Project: Hadoop YARN > Issue Type: Improvement >Reporter: Siddharth Seth > > The default configuration files serve 2 purposes > 1. Documenting available config parameters, and their default values. > 2. Specifying default values for these parameters. > An xml file hidden inside a jar is not necessarily the best way to document > parameters. This could be moved into the documentation itself. > Default values already exist in code for most parameters. There's no need to > specify them in two places. We need to make sure defaults exist for all > parameters before attempting this. > Having default configuration files just bloats job conf files; over 450 > parameters, out of which <20 are likely job specific params. JobConf files > end up being rather big, and the memory footprint of the conf object is large > (>300KB last I checked). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
