[jira] [Commented] (YARN-6883) AllocationFileLoaderService.reloadAllocations() should use a switch statement in the main tag parsing loop instead of the if/else-if/...
[
https://issues.apache.org/jira/browse/YARN-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122088#comment-16122088
]
Daniel Templeton commented on YARN-6883:
Sweet. I'll close this one when YARN-6885 is committed.
> AllocationFileLoaderService.reloadAllocations() should use a switch statement
> in the main tag parsing loop instead of the if/else-if/...
>
>
> Key: YARN-6883
> URL: https://issues.apache.org/jira/browse/YARN-6883
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Larry Lo
>Priority: Minor
> Labels: newbie
>
> {code}if ("queue".equals(element.getTagName()) ||
> "pool".equals(element.getTagName())) {
> queueElements.add(element);
> } else if ("user".equals(element.getTagName())) {
> ...{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6883) AllocationFileLoaderService.reloadAllocations() should use a switch statement in the main tag parsing loop instead of the if/else-if/...
[
https://issues.apache.org/jira/browse/YARN-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122082#comment-16122082
]
Larry Lo commented on YARN-6883:
Sure! Please close this issue and I will find other JIRAs.
> AllocationFileLoaderService.reloadAllocations() should use a switch statement
> in the main tag parsing loop instead of the if/else-if/...
>
>
> Key: YARN-6883
> URL: https://issues.apache.org/jira/browse/YARN-6883
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Larry Lo
>Priority: Minor
> Labels: newbie
>
> {code}if ("queue".equals(element.getTagName()) ||
> "pool".equals(element.getTagName())) {
> queueElements.add(element);
> } else if ("user".equals(element.getTagName())) {
> ...{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6883) AllocationFileLoaderService.reloadAllocations() should use a switch statement in the main tag parsing loop instead of the if/else-if/...
[
https://issues.apache.org/jira/browse/YARN-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122068#comment-16122068
]
Daniel Templeton commented on YARN-6883:
If it's alright with you I'll close this JIRA as handled by YARN-6885. There
are lots of other open JIRAs to tackle! :)
> AllocationFileLoaderService.reloadAllocations() should use a switch statement
> in the main tag parsing loop instead of the if/else-if/...
>
>
> Key: YARN-6883
> URL: https://issues.apache.org/jira/browse/YARN-6883
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Larry Lo
>Priority: Minor
> Labels: newbie
>
> {code}if ("queue".equals(element.getTagName()) ||
> "pool".equals(element.getTagName())) {
> queueElements.add(element);
> } else if ("user".equals(element.getTagName())) {
> ...{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6883) AllocationFileLoaderService.reloadAllocations() should use a switch statement in the main tag parsing loop instead of the if/else-if/...
[
https://issues.apache.org/jira/browse/YARN-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122063#comment-16122063
]
Larry Lo commented on YARN-6883:
It looks like the same issue to change from if/else=if to switch statement in
the same Class but different methods.
Should I keep to fix this issue or something else?
> AllocationFileLoaderService.reloadAllocations() should use a switch statement
> in the main tag parsing loop instead of the if/else-if/...
>
>
> Key: YARN-6883
> URL: https://issues.apache.org/jira/browse/YARN-6883
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Larry Lo
>Priority: Minor
> Labels: newbie
>
> {code}if ("queue".equals(element.getTagName()) ||
> "pool".equals(element.getTagName())) {
> queueElements.add(element);
> } else if ("user".equals(element.getTagName())) {
> ...{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6883) AllocationFileLoaderService.reloadAllocations() should use a switch statement in the main tag parsing loop instead of the if/else-if/...
[
https://issues.apache.org/jira/browse/YARN-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121919#comment-16121919
]
Daniel Templeton commented on YARN-6883:
I think this issue may be being subsumed into YARN-6885.
> AllocationFileLoaderService.reloadAllocations() should use a switch statement
> in the main tag parsing loop instead of the if/else-if/...
>
>
> Key: YARN-6883
> URL: https://issues.apache.org/jira/browse/YARN-6883
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Assignee: Larry Lo
>Priority: Minor
> Labels: newbie
>
> {code}if ("queue".equals(element.getTagName()) ||
> "pool".equals(element.getTagName())) {
> queueElements.add(element);
> } else if ("user".equals(element.getTagName())) {
> ...{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-6883) AllocationFileLoaderService.reloadAllocations() should use a switch statement in the main tag parsing loop instead of the if/else-if/...
[
https://issues.apache.org/jira/browse/YARN-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121176#comment-16121176
]
Larry Lo commented on YARN-6883:
Thanks to Daniel for filling this form, I would like to take this task, thanks!
> AllocationFileLoaderService.reloadAllocations() should use a switch statement
> in the main tag parsing loop instead of the if/else-if/...
>
>
> Key: YARN-6883
> URL: https://issues.apache.org/jira/browse/YARN-6883
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
>Affects Versions: 3.0.0-alpha4
>Reporter: Daniel Templeton
>Priority: Minor
> Labels: newbie
>
> {code}if ("queue".equals(element.getTagName()) ||
> "pool".equals(element.getTagName())) {
> queueElements.add(element);
> } else if ("user".equals(element.getTagName())) {
> ...{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
