[jira] [Commented] (YARN-7058) Add null check in AMRMClientImpl#getMatchingRequest

2017-09-13 Thread Akira Ajisaka (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164273#comment-16164273
 ] 

Akira Ajisaka commented on YARN-7058:
-

Backported to branch-2. Closing this as duplicate. Thanks [~sarutak] for the 
report!

> Add null check in AMRMClientImpl#getMatchingRequest
> ---
>
> Key: YARN-7058
> URL: https://issues.apache.org/jira/browse/YARN-7058
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: client
>Affects Versions: 2.9.0
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
> Attachments: YARN-7058-branch-2.001.patch
>
>
> As of YARN-4889, the behavior of AMRMClientImpl#getMatchingRequests has 
> slightly changed.
> After YARN-4889, the method will throw NPE if the method is called before 
> calling addContainerRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-7058) Add null check in AMRMClientImpl#getMatchingRequest

2017-09-13 Thread Akira Ajisaka (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164265#comment-16164265
 ] 

Akira Ajisaka commented on YARN-7058:
-

Thank you for the information. I verified the commit of YARN-5753 on trunk can 
be cherry-picked to branch-2 cleanly, so I'll cherry-pick this.

> Add null check in AMRMClientImpl#getMatchingRequest
> ---
>
> Key: YARN-7058
> URL: https://issues.apache.org/jira/browse/YARN-7058
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: client
>Affects Versions: 2.9.0
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
> Attachments: YARN-7058-branch-2.001.patch
>
>
> As of YARN-4889, the behavior of AMRMClientImpl#getMatchingRequests has 
> slightly changed.
> After YARN-4889, the method will throw NPE if the method is called before 
> calling addContainerRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-7058) Add null check in AMRMClientImpl#getMatchingRequest

2017-09-12 Thread Kousuke Saruta (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162922#comment-16162922
 ] 

Kousuke Saruta commented on YARN-7058:
--

I found YARN-5753 resolved this issue for trunk but backport seems not to be 
done for branch-2.

> Add null check in AMRMClientImpl#getMatchingRequest
> ---
>
> Key: YARN-7058
> URL: https://issues.apache.org/jira/browse/YARN-7058
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: client
>Affects Versions: 2.9.0
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
> Attachments: YARN-7058-branch-2.001.patch
>
>
> As of YARN-4889, the behavior of AMRMClientImpl#getMatchingRequests has 
> slightly changed.
> After YARN-4889, the method will throw NPE if the method is called before 
> calling addContainerRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-7058) Add null check in AMRMClientImpl#getMatchingRequest

2017-09-12 Thread Akira Ajisaka (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162706#comment-16162706
 ] 

Akira Ajisaka commented on YARN-7058:
-

Hi [~sarutak], does this problem occur on trunk as well? If so, would you 
create a patch for trunk?

> Add null check in AMRMClientImpl#getMatchingRequest
> ---
>
> Key: YARN-7058
> URL: https://issues.apache.org/jira/browse/YARN-7058
> Project: Hadoop YARN
>  Issue Type: Bug
>  Components: client
>Affects Versions: 2.9.0
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
> Attachments: YARN-7058-branch-2.001.patch
>
>
> As of YARN-4889, the behavior of AMRMClientImpl#getMatchingRequests has 
> slightly changed.
> After YARN-4889, the method will throw NPE if the method is called before 
> calling addContainerRequest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-7058) Add null check in AMRMClientImpl#getMatchingRequest

2017-08-21 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135415#comment-16135415
 ] 

Hadoop QA commented on YARN-7058:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
13s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} branch-2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} branch-2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
26s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} branch-2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} branch-2 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 14s{color} | {color:orange} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 9 new + 
61 unchanged - 9 fixed = 70 total (was 70) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}109m 16s{color} 
| {color:red} hadoop-yarn-client in the patch failed with JDK v1.7.0_151. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
44s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}144m 55s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.7.0_151 Timed out junit tests | 
org.apache.hadoop.yarn.client.TestRMFailover |
|   | org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling |
|   | org.apache.hadoop.yarn.client.cli.TestYarnCLI |
|   | org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA |
|   | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient |
|   | org.apache.hadoop.yarn.client.api.impl.TestYarnClient |
|   | org.apache.hadoop.yarn.client.api.impl.TestNMClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:5e40efe |
| JIRA Issue | YARN-7058 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12882881/YARN-7058-branch-2.001.patch
 |
| Optional Tests |  asflicense  compile

[jira] [Commented] (YARN-7058) Add null check in AMRMClientImpl#getMatchingRequest

2017-08-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134454#comment-16134454
 ] 

Hadoop QA commented on YARN-7058:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
18s{color} | {color:green} branch-2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} branch-2 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
25s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
13s{color} | {color:green} branch-2 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} branch-2 passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 13s{color} | {color:orange} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 10 new 
+ 61 unchanged - 9 fixed = 71 total (was 70) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
14s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}124m 50s{color} 
| {color:red} hadoop-yarn-client in the patch failed with JDK v1.7.0_151. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
32s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}159m 35s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_144 Failed junit tests | 
hadoop.yarn.client.api.impl.TestAMRMClient |
| JDK v1.7.0_151 Timed out junit tests | 
org.apache.hadoop.yarn.client.TestRMFailover |
|   | org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling |
|   | org.apache.hadoop.yarn.client.cli.TestYarnCLI |
|   | org.apache.hadoop.yarn.client.TestHedgingRequestRMFailoverProxyProvider |
|   | org.apache.hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA |
|   | org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA |
|   | org.apache.hadoop.yarn.client.api.impl.TestAMRMClient |
|   | org.apache.hadoop.yarn.client.api.impl.TestYarnClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |