[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237691#comment-16237691 ] Subru Krishnan commented on YARN-7434: -- Thanks [~elgoiri] for the fix and [~curino] for the review. > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Fix For: 2.9.0, 3.0.0, 3.1.0 > > Attachments: YARN-7434.000.patch, YARN-7434.001.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[
https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237034#comment-16237034
]
Hadoop QA commented on YARN-7434:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 55s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 3s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
33s{color} | {color:green} hadoop-yarn-server-router in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | YARN-7434 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12895539/YARN-7434.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 930aea808160 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 1700adc |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/18327/testReport/ |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/18327/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237104#comment-16237104 ] Hudson commented on YARN-7434: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13183 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13183/]) YARN-7434. Router getApps REST invocation fails with multiple RMs. (inigoiri: rev 6fc09beac497b40928b6b0524d83ecf6e7abf932) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Fix For: 2.9.0, 3.0.0 > > Attachments: YARN-7434.000.patch, YARN-7434.001.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237072#comment-16237072 ] Íñigo Goiri commented on YARN-7434: --- YETUS only complained about the tests which we are tracking in YARN-7435 as this is a release blocker. Committing to trunk and cherry picking to branch-3.0, branch-2 and branch-2.9. > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Attachments: YARN-7434.000.patch, YARN-7434.001.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236932#comment-16236932 ] Íñigo Goiri commented on YARN-7434: --- I added YARN-7435 to track the addition of end to end tests. > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Attachments: YARN-7434.000.patch, YARN-7434.001.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236916#comment-16236916 ] Subru Krishnan commented on YARN-7434: -- Thanks [~elgoiri] for the patch, couple of comments: * Can we move the local copy of members outside of *clone* as its invoked in loop? * The patch itself looks quite straightforward but I am not sure how involved it is add multi-thread, i.e. multi - RM tests? > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Attachments: YARN-7434.000.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236911#comment-16236911 ] Íñigo Goiri commented on YARN-7434: --- This one patch should apply to both branches. The issue might be that the supresswarning might give issues with Java 8. If that's the case, we will need a different patch for trunk. > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Attachments: YARN-7434.000.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236910#comment-16236910 ] Carlo Curino commented on YARN-7434: Thanks [~elgoiri] for the patch. LGTM, let's wait for Yetus. Also as soon as this is checked by YETUS please upload the version for branch-2/branch-2.9. > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Attachments: YARN-7434.000.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7434) Router getApps REST invocation fails with multiple RMs
[ https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236872#comment-16236872 ] Íñigo Goiri commented on YARN-7434: --- For testing this, we need a federated mini YARN cluster with a couple Resource Managers. > Router getApps REST invocation fails with multiple RMs > -- > > Key: YARN-7434 > URL: https://issues.apache.org/jira/browse/YARN-7434 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Subru Krishnan >Assignee: Íñigo Goiri >Priority: Critical > Attachments: YARN-7434.000.patch > > > Router uses threads to invoke getApps in parallel with multiple RMs and has a > concurrency bug caused by sharing of the HTTP request object. This jira > tracks the changes to fix the multi-threading issue by cloning the request. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
