[jira] [Commented] (YARN-7594) TestNMWebServices.testGetNMResourceInfo fails on trunk
[ https://issues.apache.org/jira/browse/YARN-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274755#comment-16274755 ] genericqa commented on YARN-7594: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 6s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m 5s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 38s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 12s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 0s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 16s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 17m 18s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 67m 15s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | YARN-7594 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12900227/YARN-7594.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 3cf5d27acac5 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 556aea3 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/18751/testReport/ | | Max. process+thread count | 331 (vs. ulimit of 5000) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/18751/console | | Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > TestNMWebServices.testGetNMResourceInfo fails
[jira] [Commented] (YARN-7594) TestNMWebServices.testGetNMResourceInfo fails on trunk
[ https://issues.apache.org/jira/browse/YARN-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274672#comment-16274672 ] Sunil G commented on YARN-7594: --- pending jenkins.. patch looks good. > TestNMWebServices.testGetNMResourceInfo fails on trunk > -- > > Key: YARN-7594 > URL: https://issues.apache.org/jira/browse/YARN-7594 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager, webapp >Reporter: Gergely Novák >Assignee: Gergely Novák > Attachments: YARN-7594.001.patch > > > {code} > // Access resource-2 should fail (null NMResourceInfo returned). > JSONObject json = response.getEntity(JSONObject.class); > assertIncludesException(json); > {code} > fails with > {noformat} > java.lang.AssertionError ... > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.assertIncludesException(TestNMWebServices.java:541) > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.testGetNMResourceInfo(TestNMWebServices.java:461)... > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7594) TestNMWebServices.testGetNMResourceInfo fails on trunk
[ https://issues.apache.org/jira/browse/YARN-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274664#comment-16274664 ] Gergely Novák commented on YARN-7594: - Attached a trivial patch to solve this. > TestNMWebServices.testGetNMResourceInfo fails on trunk > -- > > Key: YARN-7594 > URL: https://issues.apache.org/jira/browse/YARN-7594 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager, webapp >Reporter: Gergely Novák >Assignee: Gergely Novák > Attachments: YARN-7594.001.patch > > > {code} > // Access resource-2 should fail (null NMResourceInfo returned). > JSONObject json = response.getEntity(JSONObject.class); > assertIncludesException(json); > {code} > fails with > {noformat} > java.lang.AssertionError ... > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.assertIncludesException(TestNMWebServices.java:541) > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.testGetNMResourceInfo(TestNMWebServices.java:461)... > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7594) TestNMWebServices.testGetNMResourceInfo fails on trunk
[ https://issues.apache.org/jira/browse/YARN-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274652#comment-16274652 ] Sunil G commented on YARN-7594: --- Thanks [~GergelyNovak]. Yes, we are now returning empty json to avoid 500 error from UI when this resource is not found. Could you please help to fix test case. > TestNMWebServices.testGetNMResourceInfo fails on trunk > -- > > Key: YARN-7594 > URL: https://issues.apache.org/jira/browse/YARN-7594 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager, webapp >Reporter: Gergely Novák >Assignee: Gergely Novák > Attachments: YARN-7594.001.patch > > > {code} > // Access resource-2 should fail (null NMResourceInfo returned). > JSONObject json = response.getEntity(JSONObject.class); > assertIncludesException(json); > {code} > fails with > {noformat} > java.lang.AssertionError ... > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.assertIncludesException(TestNMWebServices.java:541) > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.testGetNMResourceInfo(TestNMWebServices.java:461)... > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7594) TestNMWebServices.testGetNMResourceInfo fails on trunk
[ https://issues.apache.org/jira/browse/YARN-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274440#comment-16274440 ] Gergely Novák commented on YARN-7594: - Since YARN-7573 {{getNMResourceInfo()}} doesn't throw Exception for wrong resource name, but returns an emtpy JSON. > TestNMWebServices.testGetNMResourceInfo fails on trunk > -- > > Key: YARN-7594 > URL: https://issues.apache.org/jira/browse/YARN-7594 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager, webapp >Reporter: Gergely Novák > > {code} > // Access resource-2 should fail (null NMResourceInfo returned). > JSONObject json = response.getEntity(JSONObject.class); > assertIncludesException(json); > {code} > fails with > {noformat} > java.lang.AssertionError ... > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.assertIncludesException(TestNMWebServices.java:541) > at > org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices.testGetNMResourceInfo(TestNMWebServices.java:461)... > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org