[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336567#comment-16336567
]
Gour Saha commented on YARN-7766:
-
[~jianhe], now that we have the config property to override the default, I
think your followup suggestions totally make sense. I filed YARN-7799 on your
behalf to capture this.
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Fix For: 3.1.0
>
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch,
> YARN-7766.003.patch, YARN-7766.004.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336274#comment-16336274
]
Hudson commented on YARN-7766:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13539 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/13539/])
YARN-7766. Introduce a new config property for YARN Service dependency (jianhe:
rev a72cdcc47a1b3a4fcadbc9e12bd1bae2bbf04d83)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/utils/CoreFileSystem.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/provider/tarball/TarballProviderService.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/client/ServiceClient.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/conf/YarnServiceConf.java
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AppAdminClient.java
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Fix For: 3.1.0
>
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch,
> YARN-7766.003.patch, YARN-7766.004.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336246#comment-16336246
]
Jian He commented on YARN-7766:
---
I'm wondering if below makes sense to be a followup item.
Currently, if user doesn't supply location when run yarn app -enableFastLaunch,
the jars will be put under this location
{code}
hdfs:///yarn-services//service-dep.tar.gz
{code}
Since API server is embedded in RM, should RM look for this location too if
"yarn.service.framework.path" is not specified ?
And if "yarn.service.framework.path" is not specified and still the file
doesn't exist at above default location, I think RM can try to upload the jars
to above default location instead, currently RM is uploading the jars to the
location defined by below code. This folder is per app and also inconsistent
with CLI location.
{code}
protected Path addJarResource(String serviceName,
Map localResources)
throws IOException, SliderException {
Path libPath = fs.buildClusterDirPath(serviceName);
{code}
By doing this, the next time a submission request comes, RM doesn't need to
upload the jars again.
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Fix For: 3.1.0
>
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch,
> YARN-7766.003.patch, YARN-7766.004.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336142#comment-16336142
]
genericqa commented on YARN-7766:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 22m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
12m 26s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
22s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 2s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 4 new + 314 unchanged - 4 fixed = 318 total (was 318) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 4s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 27m
35s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
37s{color} | {color:green} hadoop-yarn-services-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}128m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | YARN-7766 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12907295/YARN-7766.004.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 50120e47bf30 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 6347b22 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335930#comment-16335930
]
Gour Saha commented on YARN-7766:
-
[~jianhe], uploaded a 004 patch rebased to latest trunk and a console msg
update.
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch,
> YARN-7766.003.patch, YARN-7766.004.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333152#comment-16333152
]
Gour Saha commented on YARN-7766:
-
[~jianhe], thank you for reviewing the patch. I incorporated your suggestion
and uploaded 003 patch.
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch,
> YARN-7766.003.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333002#comment-16333002
]
Jian He commented on YARN-7766:
---
{code}
public int actionDependency(String destinationFolder, boolean overwrite)
throws IOException, YarnException {
String currentUser = RegistryUtils.currentUser();
LOG.info("Running command as user {}", currentUser);
Path dependencyLibTarGzip = fs.getDependencyTarGzip(true,
destinationFolder);
{code}
- For above code, feel like we don't need to pass in a 'true' flag (this
avoids the other chain of caller changes which passes in "false"). We can do
special code handling right in here something like below ?
{code}
if (destinationFolder == null) {
destinationFolder = String.format(YarnServiceConstants.DEPENDENCY_DIR,
VersionInfo.getVersion());
}
Path dependencyLibTarGzip = new Path(destinationFolder,
YarnServiceConstants.DEPENDENCY_TAR_GZ_FILE_NAME
+ YarnServiceConstants.DEPENDENCY_TAR_GZ_FILE_EXT);
{code}
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331924#comment-16331924
]
genericqa commented on YARN-7766:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
49s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 45s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 1s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 3 new + 345 unchanged - 2 fixed = 348 total (was 347) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 27s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 27m
39s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
30s{color} | {color:green} hadoop-yarn-services-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 94m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | YARN-7766 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12906772/YARN-7766.002.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 8a2b5335b2e8 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20
11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9e4f52d |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331833#comment-16331833
]
Gour Saha commented on YARN-7766:
-
Fixing 1 checkstyle issue with 002 patch. The other 3 adheres to the existing
formatting in the class, so did not want to break it. The test failure is
unrelated to this patch.
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Attachments: YARN-7766.001.patch, YARN-7766.002.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331663#comment-16331663
]
genericqa commented on YARN-7766:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 58s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
21s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 58s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 4 new + 347 unchanged - 2 fixed = 351 total (was 349) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 25s{color} | {color:green} patch has no errors when building and testing our
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 27m 7s{color}
| {color:red} hadoop-yarn-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
27s{color} | {color:green} hadoop-yarn-services-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 90m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.client.api.impl.TestAMRMClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | YARN-7766 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12906735/YARN-7766.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 3e8019a75483 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31
19:38:41 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 37f4696 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs |
[jira] [Commented] (YARN-7766) Introduce a new config property for YARN Service dependency tarball location
[
https://issues.apache.org/jira/browse/YARN-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331570#comment-16331570
]
Gour Saha commented on YARN-7766:
-
[~jianhe], please review the patch when you get a chance.
> Introduce a new config property for YARN Service dependency tarball location
>
>
> Key: YARN-7766
> URL: https://issues.apache.org/jira/browse/YARN-7766
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications, client, yarn-native-services
>Reporter: Gour Saha
>Assignee: Gour Saha
>Priority: Major
> Attachments: YARN-7766.001.patch
>
>
> Introduce a new config property (something like _yarn.service.framework.path_
> in-line with _mapreduce.application.framework.path_) for YARN Service
> dependency tarball location. This will provide flexibility to the
> user/cluster-admin to upload the dependency tarball to a location of their
> choice. If this config property is not set, YARN Service client will default
> to uploading all dependency jars from the client-host's classpath for every
> service launch request (as it does today).
> Also, accept an optional destination HDFS location for *-enableFastLaunch*
> command, to specify the location where user/cluster-admin wants to upload the
> tarball. If not specified, let's default it to the location we use today. The
> cluster-admin still needs to set _yarn.service.framework.path_ to this
> default location otherwise it will not be used. So the command-line will
> become something like this -
> {code:java}
> yarn app -enableFastLaunch []{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
