[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-13 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511350#comment-16511350
 ] 

Íñigo Goiri commented on YARN-8405:
---

Thanks [~rohithsharma] for the cherry-pick!

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Fix For: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.4
>
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-12 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510588#comment-16510588
 ] 

Rohith Sharma K S commented on YARN-8405:
-

bq. Could you also cherry pick to branch-2.9?
Done

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Fix For: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.4
>
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-12 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509824#comment-16509824
 ] 

Íñigo Goiri commented on YARN-8405:
---

Thank you [~rohithsharma] for catching this.
Could you also cherry pick to branch-2.9?
There is a commit that is not there but I think it should still apply cleanly.

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Fix For: 2.10.0, 3.2.0, 3.1.1, 3.0.4
>
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-12 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509529#comment-16509529
 ] 

Hudson commented on YARN-8405:
--

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #14403 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14403/])
YARN-8405. RM zk-state-store.parent-path ACLs has been changed since 
(rohithsharmaks: rev 2df73dace06cfd2b3193a14cd455297f8f989617)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStoreZKClientConnections.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/ZKConfigurationStore.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java


> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-12 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509513#comment-16509513
 ] 

Rohith Sharma K S commented on YARN-8405:
-

test failures are unrelated to patch.. committing shortly. 

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-11 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508719#comment-16508719
 ] 

genericqa commented on YARN-8405:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
14m 49s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
27s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
48s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 29m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 29m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m  7s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 
18s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 
22s{color} | {color:green} hadoop-hdfs-rbf in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
16s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 68m 40s{color} 
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
38s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}232m 12s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy |
|   | 
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueManagementDynamicEditPolicy
 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8405 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12927333/YARN-8405.003.patch |
|

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-11 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508491#comment-16508491
 ] 

Rohith Sharma K S commented on YARN-8405:
-

Ahh.. I see it :-)  Apologies for missing it. 

+1 lgtm.. pending jenkins

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-11 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508453#comment-16508453
 ] 

Íñigo Goiri commented on YARN-8405:
---

bq. My concern on patch is ZKCuratorManager is utils class which is already 
released. This would cause a problem right?

What we have in [^YARN-8405.003.patch] should be backwards compatible right?
The old method is still there and it has the same semantics.

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Assignee: Íñigo Goiri
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-11 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508412#comment-16508412
 ] 

Rohith Sharma K S commented on YARN-8405:
-

thanks [~elgoiri] for patch!
My concern on patch is ZKCuratorManager is utils class which is already 
released. This would cause a problem right? 

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-11 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508377#comment-16508377
 ] 

Íñigo Goiri commented on YARN-8405:
---

Thanks [~rohithsharma], I updated the patch with the old method and the new 
test part.

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch, YARN-8405.003.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-08 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506794#comment-16506794
 ] 

Rohith Sharma K S commented on YARN-8405:
-

[~elgoiri] would you please update the patch with test case?

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-08 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505866#comment-16505866
 ] 

Rohith Sharma K S commented on YARN-8405:
-

thanks [~elgoiri] for the patch. 
# Since ZKCuratorManager is in util class, changing public API would be an 
issue. Instead of changing existing API, we can add new method with 
_createRootDirRecursively(String path, List zkAcl)_

bq. do you have a test proposal?
You can change permission values to verify it. Note that 
TestZKRMStateStore#testZKRootPathAcls verifies for /rmstore/ZKRMStateRoot but 
not to /rmstore. Below is the test code that fails without patch. 
{code}
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
index 4cba2664d15..6c421157158 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
@@ -419,13 +419,14 @@ private static boolean verifyZKACL(String id, String 
scheme, int perm,
   public void testZKRootPathAcls() throws Exception {
 StateChangeRequestInfo req = new StateChangeRequestInfo(
 HAServiceProtocol.RequestSource.REQUEST_BY_USER);
-String rootPath =
-YarnConfiguration.DEFAULT_ZK_RM_STATE_STORE_PARENT_PATH + "/" +
-ZKRMStateStore.ROOT_ZNODE_NAME;
+String parentPath = 
YarnConfiguration.DEFAULT_ZK_RM_STATE_STORE_PARENT_PATH;
+String rootPath = parentPath + "/" + ZKRMStateStore.ROOT_ZNODE_NAME;

 // Start RM with HA enabled
 Configuration conf =
 createHARMConf("rm1,rm2", "rm1", 1234, false, curatorTestingServer);
+conf.set(YarnConfiguration.RM_ZK_ACL, "world:anyone:rwca");
+int perm = 23;// rwca=1+2+4+16
 ResourceManager rm = new MockRM(conf);
 rm.start();
 rm.getRMContext().getRMAdminService().transitionToActive(req);
@@ -436,10 +437,16 @@ public void testZKRootPathAcls() throws Exception {
 verifyZKACL("digest", "localhost", Perms.CREATE | Perms.DELETE, acls);
 verifyZKACL(
 "world", "anyone", Perms.ALL ^ (Perms.CREATE | Perms.DELETE), acls);
+
+acls =
+((ZKRMStateStore) 
rm.getRMContext().getStateStore()).getACL(parentPath);
+assertEquals(1, acls.size());
+assertEquals(perm, acls.get(0).getPerms());
 rm.close();

 // Now start RM with HA disabled. NoAuth Exception should not be thrown.
 conf.setBoolean(YarnConfiguration.RM_HA_ENABLED, false);
+conf.set(YarnConfiguration.RM_ZK_ACL, YarnConfiguration.DEFAULT_RM_ZK_ACL);
 rm = new MockRM(conf);
 rm.start();
 rm.getRMContext().getRMAdminService().transitionToActive(req);
{code}

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-07 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505552#comment-16505552
 ] 

Íñigo Goiri commented on YARN-8405:
---

[^YARN-8405.002.patch] looks like it does the trick; not sure why it's giving 
the FindBugs.
I fixed a couple deprecated uses of old keys in the related tests but I 
couldn't really figure how to test this.
The current unit tests do some pass on this but they don't really check the 
root.
I tried to add something but nothing really went through the code.
[~rohithsharma], do you have a test proposal?

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch, YARN-8405.001.patch, 
> YARN-8405.002.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-07 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505547#comment-16505547
 ] 

genericqa commented on YARN-8405:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m 
 3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
40s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
14m 59s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
22s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
45s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 28m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
10m 54s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 
10s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 
17s{color} | {color:green} hadoop-hdfs-rbf in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
16s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 68m 20s{color} 
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
37s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}230m 57s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8405 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12926967/YARN-8405.002.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-07 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505188#comment-16505188
 ] 

genericqa commented on YARN-8405:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m 
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m  
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 24s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
12s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
53s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
24s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch 
failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 16m 
20s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 16m 20s{color} 
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
3m  9s{color} | {color:orange} root: The patch generated 1 new + 33 unchanged - 
3 fixed = 34 total (was 36) {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
28s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch 
failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red}  3m 
22s{color} | {color:red} patch has errors when building and testing our client 
artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
23s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch 
failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m 
58s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
12s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 28s{color} 
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
24s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}117m 47s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8405 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12926943/YARN-8405.001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux cfd12a4c1b9e 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 
11:50:30 UTC 2017 x86_64 x86_64

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-07 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505182#comment-16505182
 ] 

genericqa commented on YARN-8405:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 27m 
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 30m  
3s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  3m 
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
18m 34s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
24s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
7s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
27s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch 
failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 18m 
17s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 18m 17s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  3m 
 3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m 
30s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch 
failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedclient {color} | {color:red}  3m 
53s{color} | {color:red} patch has errors when building and testing our client 
artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  
8s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m 
24s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m 
44s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
48s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  1m 34s{color} 
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}150m 42s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8405 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12926934/YARN-8405.000.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 90b772b41c9a

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773

2018-06-07 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504988#comment-16504988
 ] 

Íñigo Goiri commented on YARN-8405:
---

It looks like {{TestZKRMStateStore#testZKRootPathAcls()}} should have caught 
this.
However, as the unit test just uses default ACLs, I don't think it is testing 
much.

> RM zk-state-store.parent-path ACLs has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path acls has been changed since HADOOP-14773

2018-06-07 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504983#comment-16504983
 ] 

Íñigo Goiri commented on YARN-8405:
---

Thanks [~rohithsharma], you are completely right.
I posted [^YARN-8405.000.patch] with the fix itself.
This needs some unit test too; let me see what we can do here.

> RM zk-state-store.parent-path acls has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
> Attachments: YARN-8405.000.patch
>
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path acls has been changed since HADOOP-14773

2018-06-07 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504937#comment-16504937
 ] 

Rohith Sharma K S commented on YARN-8405:
-

HADOOP-14741 added ZKCuratorManager. The method in create() send null zkAcl. 
But in ZKRMStateStore, this method send zkAcl value. 
{code}
/**
   * Create a ZNode.
   * @param path Path of the ZNode.
   * @return If the ZNode was created.
   * @throws Exception If it cannot contact Zookeeper.
   */
  public boolean create(final String path) throws Exception {
return create(path, null);
  }
{code}

> RM zk-state-store.parent-path acls has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path acls has been changed since HADOOP-14773

2018-06-07 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504906#comment-16504906
 ] 

Íñigo Goiri commented on YARN-8405:
---

Thanks [~rohithsharma] for reporting.
I'm trying to check in the 
[patch|https://issues.apache.org/jira/secure/attachment/12881994/HADOOP-14773-001.patch]
 what was the part I missed.
I believe the issue must come from HADOOP-14741 where we moved from RM_ZK_ACL 
to ZK_ACL.

> RM zk-state-store.parent-path acls has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 2.9.0, 3.1.0
>Reporter: Rohith Sharma K S
>Priority: Major
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8405) RM zk-state-store.parent-path acls has been changed since HADOOP-14773

2018-06-07 Thread Rohith Sharma K S (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504659#comment-16504659
 ] 

Rohith Sharma K S commented on YARN-8405:
-

Below is the difference  
*Before* :
{code}
[zk: localhost:2181(CONNECTED) 0] getAcl /rmstore
'sasl,'rm
: cdrwa
{code}

*After*:
{code}
[zk: localhost:2181(CONNECTED) 1] getAcl /rmstore
'world,'anyone
: cdrwa
[zk: localhost:2181(CONNECTED) 2] getAcl /rmstore/ZKRMStateRoot
'sasl,'rm
: rwa
'digest,'ctr-e138-1518143905142-346048-01-08.test.site:C1u8x7GQW9SdBpprg1Gov7bAAf8=
: cd
{code}


The reason is while creating parent node recursively, ACLs are not set. Once 
parent node is created, then for further node creation acls are set. 
cc:/ [~subru] [~elgoiri]

> RM zk-state-store.parent-path acls has been changed since HADOOP-14773
> --
>
> Key: YARN-8405
> URL: https://issues.apache.org/jira/browse/YARN-8405
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Rohith Sharma K S
>Priority: Major
>
> HADOOP-14773 changes the ACL for 
> yarn.resourcemanager.zk-state-store.parent-path. Earlier to HADOOP-14773, 
> /rmstore used set acls with yarn.resourcemanager.zk-acl value. But now  
> behavior changed from setting acls to parent node. As a result, parent node 
> /rmstore is set to default acl. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org