[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-10 Thread Szilard Nemeth (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539097#comment-16539097
 ] 

Szilard Nemeth commented on YARN-8502:
--

Thanks [~giovanni.fumarola] for the quick responses and for the commit!

> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-10 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539092#comment-16539092
 ] 

Hudson commented on YARN-8502:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14551 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14551/])
YARN-8502. Use path strings consistently for webservice endpoints in (gifuma: 
rev 82ac3aa6d0a83235cfac2805a444dd26efe5f9ce)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWSConsts.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMWebServices.java


> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-10 Thread Giovanni Matteo Fumarola (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539009#comment-16539009
 ] 

Giovanni Matteo Fumarola commented on YARN-8502:


Thanks [~snemeth] for working on this.
Committed to trunk.

> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-10 Thread Giovanni Matteo Fumarola (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538998#comment-16538998
 ] 

Giovanni Matteo Fumarola commented on YARN-8502:


Ok. I will open a Jira to fix those.
+1 from my side.
Committing to trunk.

> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-10 Thread Szilard Nemeth (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538764#comment-16538764
 ] 

Szilard Nemeth commented on YARN-8502:
--

Hey [~giovanni.fumarola]!
I would vote for a separate jira as the thing you mentioned not strictly 
related to constants or endpoint paths and maybe could confuse anyone looking 
into git log.
Thanks!

> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-09 Thread Giovanni Matteo Fumarola (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537326#comment-16537326
 ] 

Giovanni Matteo Fumarola commented on YARN-8502:


Thanks [~snemeth] for working on this.
I took a look at RMWebServices and I have a comment:

updateSchedulerConfiguration and checkUserAccessToQueue should be defined in 
{{*RMWebServiceProtocol*}} and be implemented in \{{RMWebServices}} and 
\{{RouterWebServices}}. We can fix in this Jira or I can open a new one.

> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-09 Thread Bibin A Chundatt (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537128#comment-16537128
 ] 

Bibin A Chundatt commented on YARN-8502:


+1 LGTM

> Use path strings consistently for webservice endpoints in RMWebServices
> ---
>
> Key: YARN-8502
> URL: https://issues.apache.org/jira/browse/YARN-8502
> Project: Hadoop YARN
>  Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Szilard Nemeth
>Priority: Major
> Attachments: YARN-8502-001.patch
>
>
> Currently there are 2 types of endpoint path definitions: 
> 1. with string, example: 
> @Path("/apps/{appid}/appattempts/{appattemptid}/containers/{containerid}")
> 2. with constant, example: 
> @Path(RMWSConsts.APPS_APPID_APPATTEMPTS_APPATTEMPTID_CONTAINERS)
> Most preferably, constants should be used for all Paths.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-8502) Use path strings consistently for webservice endpoints in RMWebServices

2018-07-07 Thread genericqa (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535830#comment-16535830
 ] 

genericqa commented on YARN-8502:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 
 6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 55s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 17s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 68m 
44s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
27s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}127m 23s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | YARN-8502 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12930645/YARN-8502-001.patch |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 077e27d56626 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 936e0df |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/21182/testReport/ |
| Max. process+thread count | 852 (vs. ulimit of 1) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/21182/console |
| Powered by | Apache Yetus