[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[ https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726204#comment-13726204 ] Mayank Bansal commented on YARN-956: Thanks [~vinodkv] and [~zjshen] for review. I am updating the patch with your comments and test case. For this one we don't need to use RM classes so we are good in that case. Thanks, Mayank [YARN-321] Add History Store interface and testable in-memory HistoryStorage Key: YARN-956 URL: https://issues.apache.org/jira/browse/YARN-956 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Mayank Bansal Attachments: YARN-956-1.patch, YARN-956-2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[
https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726214#comment-13726214
]
Hadoop QA commented on YARN-956:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12595372/YARN-956-3.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1638//console
This message is automatically generated.
[YARN-321] Add History Store interface and testable in-memory HistoryStorage
Key: YARN-956
URL: https://issues.apache.org/jira/browse/YARN-956
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Vinod Kumar Vavilapalli
Assignee: Mayank Bansal
Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[ https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726873#comment-13726873 ] Zhijie Shen commented on YARN-956: -- One more thought about HistoryStorage. Does HistoryStorage need to extend AbstractService, such that we can make use of the life cycle: init() can be used to prepare the storage and stop() can be used to release the storage. For In-memory HistoryStorage, these two steps may be not necessary, because the memory will be eventually released by GC. However, FileSystem HistoryStorage will need these two steps (see YARN-975). However, I think it's good to be consistent among all the implementations. Other implementations, such as DB HistoryStorage, may also need to the steps to setup the connection and to disconnect. Thoughts? [YARN-321] Add History Store interface and testable in-memory HistoryStorage Key: YARN-956 URL: https://issues.apache.org/jira/browse/YARN-956 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Mayank Bansal Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[ https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726956#comment-13726956 ] Mayank Bansal commented on YARN-956: Its intresting however not sure if we absolutely need it as of now. For HDFS file open and close I don't think we need explicit init and stop. I will suggest to wait for others implementation and at that point if we need it we can definately consider this option. Thoughts? Thanks, Mayank [YARN-321] Add History Store interface and testable in-memory HistoryStorage Key: YARN-956 URL: https://issues.apache.org/jira/browse/YARN-956 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Mayank Bansal Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[
https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724971#comment-13724971
]
Zhijie Shen commented on YARN-956:
--
WRT ApplicationHistoryReader, do you think the APIs should throw Throwable as
well? For example, the APIs may fail due to the abnormal I/O.
[~mayank_bansal], would you please fix the javadoc warnings of
ApplicationHistoryReader in this patch as well? Please make sure of
\{@link \} is imported. Thanks!
[YARN-321] Add History Store interface and testable in-memory HistoryStorage
Key: YARN-956
URL: https://issues.apache.org/jira/browse/YARN-956
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Vinod Kumar Vavilapalli
Assignee: Mayank Bansal
Attachments: YARN-956-1.patch, YARN-956-2.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[ https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725818#comment-13725818 ] Zhijie Shen commented on YARN-956: -- bq. Can you also write a test for InMemory storage. This will be a good starting point to begin writing tests for AHS. Tx, [~vinodkv], I recall one problem. WRT the test, if it has reference to RM, I think it's good to be placed either in resourcemanager or server-test sub-project, instead of applicationhistoryservice sub-project. This is because resourcemanager sub-project will eventually refer applicationhistoryservice. Then, if applicationhistoryservice already has the dependency on resourcemanager, there will be cyclic dependency. Recall the issue in YARN-641. [YARN-321] Add History Store interface and testable in-memory HistoryStorage Key: YARN-956 URL: https://issues.apache.org/jira/browse/YARN-956 Project: Hadoop YARN Issue Type: Sub-task Reporter: Vinod Kumar Vavilapalli Assignee: Mayank Bansal Attachments: YARN-956-1.patch, YARN-956-2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-956) [YARN-321] Add History Store interface and testable in-memory HistoryStorage
[
https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724644#comment-13724644
]
Hadoop QA commented on YARN-956:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12595082/YARN-956-2.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1618//console
This message is automatically generated.
[YARN-321] Add History Store interface and testable in-memory HistoryStorage
Key: YARN-956
URL: https://issues.apache.org/jira/browse/YARN-956
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Vinod Kumar Vavilapalli
Assignee: Mayank Bansal
Attachments: YARN-956-1.patch, YARN-956-2.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
