[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728847#comment-13728847 ] Hudson commented on YARN-994: - SUCCESS: Integrated in Hadoop-Yarn-trunk #291 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/291/]) YARN-994. HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1510070) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch, YARN-994.2.patch, YARN-994.3.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728892#comment-13728892 ] Hudson commented on YARN-994: - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1508 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1508/]) YARN-994. HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1510070) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch, YARN-994.2.patch, YARN-994.3.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728690#comment-13728690 ] Hudson commented on YARN-994: - SUCCESS: Integrated in Hadoop-trunk-Commit #4209 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4209/]) YARN-994. HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly (Xuan Gong via bikas) (bikas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1510070) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch, YARN-994.2.patch, YARN-994.3.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[
https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726087#comment-13726087
]
Hadoop QA commented on YARN-994:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12595350/YARN-994.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1635//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1635//console
This message is automatically generated.
HeartBeat thread in AMRMClientAsync does not handle runtime exception
correctly
---
Key: YARN-994
URL: https://issues.apache.org/jira/browse/YARN-994
Project: Hadoop YARN
Issue Type: Bug
Reporter: Xuan Gong
Assignee: Xuan Gong
Attachments: YARN-994.1.patch, YARN-994.2.patch
YARN-654 performs sanity checks for parameters of public methods in
AMRMClient. Those may create runtime exception.
Currently, heartBeat thread in AMRMClientAsync only captures IOException and
YarnException, and will not handle Runtime Exception properly.
Possible solution can be: heartbeat thread will catch throwable and notify
the callbackhandler thread via existing savedException
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726713#comment-13726713 ] Bikas Saha commented on YARN-994: - Code change looks good. The new test is a copy paste of the existing testAMRMClientAsyncException(). Can we please reuse the code and simply pass a checked and unchecked exception to the same code from 2 different tests? HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch, YARN-994.2.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726800#comment-13726800 ] Xuan Gong commented on YARN-994: Yes, new patch will fix this HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch, YARN-994.2.patch, YARN-994.3.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[
https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726904#comment-13726904
]
Hadoop QA commented on YARN-994:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12595473/YARN-994.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1641//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1641//console
This message is automatically generated.
HeartBeat thread in AMRMClientAsync does not handle runtime exception
correctly
---
Key: YARN-994
URL: https://issues.apache.org/jira/browse/YARN-994
Project: Hadoop YARN
Issue Type: Bug
Reporter: Xuan Gong
Assignee: Xuan Gong
Attachments: YARN-994.1.patch, YARN-994.2.patch, YARN-994.3.patch
YARN-654 performs sanity checks for parameters of public methods in
AMRMClient. Those may create runtime exception.
Currently, heartBeat thread in AMRMClientAsync only captures IOException and
YarnException, and will not handle Runtime Exception properly.
Possible solution can be: heartbeat thread will catch throwable and notify
the callbackhandler thread via existing savedException
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726972#comment-13726972 ] Bikas Saha commented on YARN-994: - +1. Thanks for the fix Xuan! Committing to trunk and branch-2. HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch, YARN-994.2.patch, YARN-994.3.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13726039#comment-13726039 ] Xuan Gong commented on YARN-994: Yes, i will do that HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[
https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724071#comment-13724071
]
Hadoop QA commented on YARN-994:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12594880/YARN-994.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:
org.apache.hadoop.yarn.client.api.impl.TestNMClient
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1615//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1615//console
This message is automatically generated.
HeartBeat thread in AMRMClientAsync does not handle runtime exception
correctly
---
Key: YARN-994
URL: https://issues.apache.org/jira/browse/YARN-994
Project: Hadoop YARN
Issue Type: Bug
Reporter: Xuan Gong
Assignee: Xuan Gong
Attachments: YARN-994.1.patch
YARN-654 performs sanity checks for parameters of public methods in
AMRMClient. Those may create runtime exception.
Currently, heartBeat thread in AMRMClientAsync only captures IOException and
YarnException, and will not handle Runtime Exception properly.
Possible solution can be: heartbeat thread will catch throwable and notify
the callbackhandler thread via existing savedException
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724097#comment-13724097 ] Xuan Gong commented on YARN-994: Test failure is related HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (YARN-994) HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly
[ https://issues.apache.org/jira/browse/YARN-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724098#comment-13724098 ] Xuan Gong commented on YARN-994: Sorry, test failure is un-related HeartBeat thread in AMRMClientAsync does not handle runtime exception correctly --- Key: YARN-994 URL: https://issues.apache.org/jira/browse/YARN-994 Project: Hadoop YARN Issue Type: Bug Reporter: Xuan Gong Assignee: Xuan Gong Attachments: YARN-994.1.patch YARN-654 performs sanity checks for parameters of public methods in AMRMClient. Those may create runtime exception. Currently, heartBeat thread in AMRMClientAsync only captures IOException and YarnException, and will not handle Runtime Exception properly. Possible solution can be: heartbeat thread will catch throwable and notify the callbackhandler thread via existing savedException -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
